From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.7880.1574954386331090194 for ; Thu, 28 Nov 2019 07:19:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aR3zwOa2; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574954385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q5lCPSWvitfOUh4nHihZRTCIHZ3WM/+YmGp5XCr86As=; b=aR3zwOa2+Qz7giK2aeAqQnDmulwFHnC8mLE/4Yf5hjktjrPPgThmpG4TYJ8s5aSbcj1qug 3jXDj/LAtJGscp52Yar4b+gH1IG1QLAgF3yqcv5ykWJOsbdQSFNlfabmhYmO806ab87wB6 6dDW2rCTa6y2lcx9erKlScbERCIZg/k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-4A-yQBCBMgKBqyhaB6ePKw-1; Thu, 28 Nov 2019 10:19:44 -0500 Received: by mail-wr1-f71.google.com with SMTP id f8so8741887wrw.21 for ; Thu, 28 Nov 2019 07:19:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q5lCPSWvitfOUh4nHihZRTCIHZ3WM/+YmGp5XCr86As=; b=Kj1dpe6ZrgCf3En5FozZXwPzz9U7j4w6M4NO+7gbnLk+2N+BnW0ww+RSgw9Vyzv6ia +quAdkojAeGO9QNjpry/PZUDjZPMc8lhlrZCpNs1rJR+JJbjJhnhXv5okiKlRKWlSgg+ x6t71+e7JqgCKj4f9yUfiUrdiGtmAav9DJ6yswab5MEFH/1jNjJPkr57CA+ySe6frUA2 dWMqp8Yuo8RtXI5D30s05aYFpTGVqx4oJiMIeiB/Kjq9X3GVJaUG2jFgdAjkiPhgIV8W ReOdRQsFmru03+rWwftTDgRwuyQzs3ZIUayhvN0eegP9doVsjMWIFeMSBN/YPLF4nHWi sPeA== X-Gm-Message-State: APjAAAUu8oBQTHXjPc4TkqgqDGi0Oe8VOTYRBWDwBuCUW1qsit/yHtAo xtoPgKoQDPgh3mpT2XHveFHjDKEYm+LX1jHMERdLyAi1JhsNM5X55jQAj7s0iNOwq8F+06ggVbo GJp6Oep/cx0/YCA== X-Received: by 2002:adf:ec48:: with SMTP id w8mr955163wrn.19.1574954383197; Thu, 28 Nov 2019 07:19:43 -0800 (PST) X-Google-Smtp-Source: APXvYqwI22OE00+B0RHV8PXrMad7UJVupkMHS5zG4fqH8ATACx1+tZIE/QkSV/PYlFhUyzm+NHCNfg== X-Received: by 2002:adf:ec48:: with SMTP id w8mr955146wrn.19.1574954382977; Thu, 28 Nov 2019 07:19:42 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id m9sm22713433wro.66.2019.11.28.07.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 07:19:42 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg: Fixes to static code analysis hits To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com Cc: Jiaxin Wu , Siyuan Fu References: <20191128144606.2040-1-maciej.rabeda@linux.intel.com> <20191128144606.2040-2-maciej.rabeda@linux.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <84a623df-467a-275e-0921-31d05ff723b5@redhat.com> Date: Thu, 28 Nov 2019 16:19:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191128144606.2040-2-maciej.rabeda@linux.intel.com> X-MC-Unique: 4A-yQBCBMgKBqyhaB6ePKw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 11/28/19 3:46 PM, Maciej Rabeda via Groups.Io wrote: > Introducing fixes to memory leak issues identified by static code analysis > tool. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Maciej Rabeda > --- > NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 1 + > NetworkPkg/Ip4Dxe/Ip4If.c | 6 +++++- > NetworkPkg/TcpDxe/TcpDispatcher.c | 1 + > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c > index 4f8393cb36ce..613b42149cc1 100644 > --- a/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c > +++ b/NetworkPkg/Dhcp6Dxe/Dhcp6Io.c > @@ -203,6 +203,7 @@ Dhcp6EnqueueRetry ( > // > // Unexpected message type. > // > + FreePool(TxCb); OK. > return EFI_DEVICE_ERROR; > } > > diff --git a/NetworkPkg/Ip4Dxe/Ip4If.c b/NetworkPkg/Ip4Dxe/Ip4If.c > index 53a333037f94..348f2e076aed 100644 > --- a/NetworkPkg/Ip4Dxe/Ip4If.c > +++ b/NetworkPkg/Ip4Dxe/Ip4If.c > @@ -491,9 +491,13 @@ Ip4CreateInterface ( > IP4_INTERFACE *Interface; > EFI_SIMPLE_NETWORK_MODE SnpMode; > > + if (Mnp == NULL) { > + return NULL; > + } You are fixing existing code, so this is OK. However I wonder why not use: ASSERT (Mnp != NULL); > + > Interface = AllocatePool (sizeof (IP4_INTERFACE)); > > - if ((Interface == NULL) || (Mnp == NULL)) { > + if (Interface == NULL) { > return NULL; > } > > diff --git a/NetworkPkg/TcpDxe/TcpDispatcher.c b/NetworkPkg/TcpDxe/TcpDispatcher.c > index 86beaf8cc513..9ae08ccc1c56 100644 > --- a/NetworkPkg/TcpDxe/TcpDispatcher.c > +++ b/NetworkPkg/TcpDxe/TcpDispatcher.c > @@ -390,6 +390,7 @@ TcpAttachPcb ( > ); > if (EFI_ERROR (Status)) { > IpIoRemoveIp (IpIo, Tcb->IpInfo); > + FreePool (Tcb); OK. Reviewed-by: Philippe Mathieu-Daude > return Status; > } > >