Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS

["Laszlo Ersek" <lersek@redhat.com>]

On 04/29/19 15:35, Ard Biesheuvel wrote:
> On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas <mw@semihalf.com> wrote:
>>
>> Latest change allowed to add dependency on NvVarStoreFormattedLib
>> for the DXE_DRIVER modules. Although effectively it is hooked
>> using the 'NULL' class, extend the LIBRARY_CLASS with according
>> type for consistency sake.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Pushed as 038f929c921c..e2d3a25f1a31
> 
> Thanks!
> 
>> ---
>>  EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> index 98a0049..e2eed26 100644
>> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> @@ -25,7 +25,7 @@
>>    FILE_GUID                      = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
>>    MODULE_TYPE                    = BASE
>>    VERSION_STRING                 = 1.0
>> -  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
>> +  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
>>    CONSTRUCTOR                    = NvVarStoreFormattedInitialize
>>
>>  [Sources]
>> --
>> 2.7.4
>>

Thank you both!
Laszlo