From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Mon, 29 Apr 2019 08:18:21 -0700
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id EB35558569;
	Mon, 29 Apr 2019 15:18:15 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-31.rdu2.redhat.com [10.10.121.31])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 9F0466928F;
	Mon, 29 Apr 2019 15:18:13 +0000 (UTC)
Subject: Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
 Leif Lindholm <leif.lindholm@linaro.org>, =?UTF-8?B?SmFuIETEhWJyb8Wb?=
 <jsd@semihalf.com>, Grzegorz Jaszczyk <jaz@semihalf.com>,
 Jici Gao <Jici.Gao@arm.com>, "Tian, Feng" <feng.tian@intel.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Gao, Liming" <liming.gao@intel.com>
References: <1556356592-8614-1-git-send-email-mw@semihalf.com>
 <CAKv+Gu8eAVvdW_Ot3dQ7_yLh++-fbSX0aJ934ktg1Fq+Sy437w@mail.gmail.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <84b28c93-599f-6880-05bc-793120a51b87@redhat.com>
Date: Mon, 29 Apr 2019 17:18:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu8eAVvdW_Ot3dQ7_yLh++-fbSX0aJ934ktg1Fq+Sy437w@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 29 Apr 2019 15:18:16 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/29/19 15:35, Ard Biesheuvel wrote:
> On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas <mw@semihalf.com> wrote:
>>
>> Latest change allowed to add dependency on NvVarStoreFormattedLib
>> for the DXE_DRIVER modules. Although effectively it is hooked
>> using the 'NULL' class, extend the LIBRARY_CLASS with according
>> type for consistency sake.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Pushed as 038f929c921c..e2d3a25f1a31
> 
> Thanks!
> 
>> ---
>>  EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> index 98a0049..e2eed26 100644
>> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> @@ -25,7 +25,7 @@
>>    FILE_GUID                      = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
>>    MODULE_TYPE                    = BASE
>>    VERSION_STRING                 = 1.0
>> -  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
>> +  LIBRARY_CLASS                  = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
>>    CONSTRUCTOR                    = NvVarStoreFormattedInitialize
>>
>>  [Sources]
>> --
>> 2.7.4
>>

Thank you both!
Laszlo