* [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS
@ 2019-04-27 9:16 Marcin Wojtas
2019-04-29 13:35 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Wojtas @ 2019-04-27 9:16 UTC (permalink / raw)
To: devel
Cc: leif.lindholm, ard.biesheuvel, mw, jsd, jaz, Jici.Gao, feng.tian,
michael.d.kinney, liming.gao, lersek
Latest change allowed to add dependency on NvVarStoreFormattedLib
for the DXE_DRIVER modules. Although effectively it is hooked
using the 'NULL' class, extend the LIBRARY_CLASS with according
type for consistency sake.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
index 98a0049..e2eed26 100644
--- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
+++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
@@ -25,7 +25,7 @@
FILE_GUID = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
+ LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
CONSTRUCTOR = NvVarStoreFormattedInitialize
[Sources]
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS
2019-04-27 9:16 [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS Marcin Wojtas
@ 2019-04-29 13:35 ` Ard Biesheuvel
2019-04-29 15:18 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2019-04-29 13:35 UTC (permalink / raw)
To: Marcin Wojtas
Cc: edk2-devel-groups-io, Leif Lindholm, Jan Dąbroś,
Grzegorz Jaszczyk, Jici Gao, Tian, Feng, Kinney, Michael D,
Gao, Liming, Laszlo Ersek
On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Latest change allowed to add dependency on NvVarStoreFormattedLib
> for the DXE_DRIVER modules. Although effectively it is hooked
> using the 'NULL' class, extend the LIBRARY_CLASS with according
> type for consistency sake.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 038f929c921c..e2d3a25f1a31
Thanks!
> ---
> EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> index 98a0049..e2eed26 100644
> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> @@ -25,7 +25,7 @@
> FILE_GUID = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> + LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
> CONSTRUCTOR = NvVarStoreFormattedInitialize
>
> [Sources]
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS
2019-04-29 13:35 ` Ard Biesheuvel
@ 2019-04-29 15:18 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2019-04-29 15:18 UTC (permalink / raw)
To: Ard Biesheuvel, Marcin Wojtas
Cc: edk2-devel-groups-io, Leif Lindholm, Jan Dąbroś,
Grzegorz Jaszczyk, Jici Gao, Tian, Feng, Kinney, Michael D,
Gao, Liming
On 04/29/19 15:35, Ard Biesheuvel wrote:
> On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas <mw@semihalf.com> wrote:
>>
>> Latest change allowed to add dependency on NvVarStoreFormattedLib
>> for the DXE_DRIVER modules. Although effectively it is hooked
>> using the 'NULL' class, extend the LIBRARY_CLASS with according
>> type for consistency sake.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Pushed as 038f929c921c..e2d3a25f1a31
>
> Thanks!
>
>> ---
>> EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> index 98a0049..e2eed26 100644
>> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> @@ -25,7 +25,7 @@
>> FILE_GUID = 78f76ae8-ae62-4455-8148-c3a7ebaaa3f3
>> MODULE_TYPE = BASE
>> VERSION_STRING = 1.0
>> - LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
>> + LIBRARY_CLASS = NvVarStoreFormattedLib|PEIM DXE_RUNTIME_DRIVER DXE_DRIVER DXE_SMM_DRIVER
>> CONSTRUCTOR = NvVarStoreFormattedInitialize
>>
>> [Sources]
>> --
>> 2.7.4
>>
Thank you both!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-29 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-27 9:16 [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS Marcin Wojtas
2019-04-29 13:35 ` Ard Biesheuvel
2019-04-29 15:18 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox