From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 53A002194EB70
 for <edk2-devel@lists.01.org>; Mon, 18 Feb 2019 03:45:12 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 9E66BD6561;
 Mon, 18 Feb 2019 11:45:11 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-242.rdu2.redhat.com
 [10.10.120.242])
 by smtp.corp.redhat.com (Postfix) with ESMTP id C62D1194B4;
 Mon, 18 Feb 2019 11:45:09 +0000 (UTC)
To: Jordan Justen <jordan.l.justen@intel.com>, edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Julien Grall <julien.grall@linaro.org>
References: <20190216081824.684-1-jordan.l.justen@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <84dd0b25-904d-4640-5775-b9ce1df8d742@redhat.com>
Date: Mon, 18 Feb 2019 12:45:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190216081824.684-1-jordan.l.justen@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Mon, 18 Feb 2019 11:45:11 +0000 (UTC)
Subject: Re: [PATCH] OvmfPkg/build.sh: Enable flash for qemu 3 or later
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2019 11:45:13 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/16/19 09:18, Jordan Justen wrote:
> The check for 1.[1-9][0-9].* was removed since qemu jumped to 2.0
> after 1.7.
> 
> Changed 2.*.* to [2-9].*.* to match major releases 3 - 9.
> 
> Added [1-9][0-9]*.*.* to match major releses >= 10.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 6821742e7a..97863b09f2 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -215,7 +215,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>                     grep -o -E 'version [0-9]+\.[0-9]+\.[0-9]+' | \
>                       awk '{print $2}')
>    case $qemu_version in
> -    1.[6-9].*|1.[1-9][0-9].*|2.*.*)
> +    1.[6-9].*|[2-9].*.*|[1-9][0-9]*.*.*)
>        ENABLE_FLASH=yes
>        ;;
>    esac
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo