From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Tan, Dun" <dun.tan@intel.com>
Cc: "Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Xu, Min M" <min.m.xu@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber
Date: Fri, 5 Jan 2024 14:56:23 +0100 [thread overview]
Message-ID: <84ec1806-f42e-4fbf-2ee2-96ce2496478a@redhat.com> (raw)
In-Reply-To: <MN6PR11MB8244B646E3D362D486961DCE8C662@MN6PR11MB8244.namprd11.prod.outlook.com>
On 1/5/24 13:55, Ni, Ray wrote:
>>> - if (ProcessorNumber != 0) {
>>> + //
>>> + // Lower 24 bits contains the actual processor number.
>>> + //
>>> + if ((ProcessorNumber & (CPU_V2_EXTENDED_TOPOLOGY - 1)) != 0) {
> I suggest we explicitly use BIT24 instead of CPU_V2_EXTENDED_TOPOLOGY.
> Using BIT24 clearly tells that processor number only occupies the lower 24 bits.
Yes, I've noticed this discrepancy too; I agree BIT24 is clearer here!
>
>
>>> return EFI_NOT_FOUND;
>>> }
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113287): https://edk2.groups.io/g/devel/message/113287
Mute This Topic: https://groups.io/mt/103518743/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-05 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 7:32 [edk2-devel] [PATCH 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp duntan
2024-01-04 7:32 ` [edk2-devel] [PATCH 1/2] UefiCpuPkg: Retrive EXTENDED_PROCESSOR_INFORMATION duntan
2024-01-04 14:53 ` Laszlo Ersek
2024-01-05 9:24 ` duntan
2024-01-05 12:56 ` Ni, Ray
2024-01-05 13:59 ` Laszlo Ersek
2024-01-04 7:32 ` [edk2-devel] [PATCH 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber duntan
2024-01-04 14:43 ` Laszlo Ersek
2024-01-05 12:55 ` Ni, Ray
2024-01-05 13:56 ` Laszlo Ersek [this message]
2024-01-08 3:57 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ec1806-f42e-4fbf-2ee2-96ce2496478a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox