Re: [PATCH 7/7] ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command line

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/24/20 9:53 AM, Laszlo Ersek wrote:
> Port the DSC file changes from the similarly titled OvmfPkg patch in this
> series to ArmVirtPkg.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Per Sundstrom <per_sundstrom@yahoo.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2681
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   ArmVirtPkg/ArmVirtQemu.dsc       | 13 +++++++++++++
>   ArmVirtPkg/ArmVirtQemuKernel.dsc | 13 +++++++++++++
>   2 files changed, 26 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 1233f1ece484..3f649c91d8d6 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -58,6 +58,7 @@ [LibraryClasses.common]
>     VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf
>     QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
>     QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
> +  QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf
>     QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
>   
>     ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> @@ -256,6 +257,12 @@ [PcdsDynamicDefault.common]
>     gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE
>   
> +  #
> +  # IPv4 and IPv6 PXE Boot support.
> +  #
> +  gEfiNetworkPkgTokenSpaceGuid.PcdIPv4PXESupport|0x01
> +  gEfiNetworkPkgTokenSpaceGuid.PcdIPv6PXESupport|0x01
> +
>     #
>     # TPM2 support
>     #
> @@ -430,6 +437,12 @@ [Components.common]
>     # Networking stack
>     #
>   !include NetworkPkg/NetworkComponents.dsc.inc
> +
> +  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf {
> +    <LibraryClasses>
> +      NULL|OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf
> +  }
> +
>   !if $(NETWORK_TLS_ENABLE) == TRUE
>     NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf {
>       <LibraryClasses>
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 0af91f21b7b7..2a6fd6bc06be 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -56,6 +56,7 @@ [LibraryClasses.common]
>     VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf
>     QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf
>     QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
> +  QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/QemuFwCfgSimpleParserLib.inf
>     QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
>   
>     ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.inf
> @@ -239,6 +240,12 @@ [PcdsDynamicDefault.common]
>     gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE
>   
> +  #
> +  # IPv4 and IPv6 PXE Boot support.
> +  #
> +  gEfiNetworkPkgTokenSpaceGuid.PcdIPv4PXESupport|0x01
> +  gEfiNetworkPkgTokenSpaceGuid.PcdIPv6PXESupport|0x01
> +
>   ################################################################################
>   #
>   # Components Section - list of all EDK II Modules needed by this Platform
> @@ -369,6 +376,12 @@ [Components.common]
>     # Networking stack
>     #
>   !include NetworkPkg/NetworkComponents.dsc.inc
> +
> +  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf {
> +    <LibraryClasses>
> +      NULL|OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf
> +  }
> +
>   !if $(NETWORK_TLS_ENABLE) == TRUE
>     NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf {
>       <LibraryClasses>
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>