From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.6524.1588078053451801711 for ; Tue, 28 Apr 2020 05:47:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SP2xu/Mf; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588078052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KfCI1vh6At1BrctiPx44QR/OGc7ABY2UNOEp37w1eLc=; b=SP2xu/MfMULGy4bW+ddIBiM5EFSYMPUYugqg49V0RuKkbEh4WizASs0SDjqFbD40wfywY6 KZZv3K6qlzbv7h9g4bOW3zLXgnxXJXJXSPkj/i8GldCbzQYLzmCp7egGbiKJtikpf0G89V fxNRC5jZbRVkBwGA2/8Ks4IQyxogjQk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-B8vrO5IYM8Ov3peYYtVrVQ-1; Tue, 28 Apr 2020 08:47:31 -0400 X-MC-Unique: B8vrO5IYM8Ov3peYYtVrVQ-1 Received: by mail-wr1-f69.google.com with SMTP id q10so12254954wrv.10 for ; Tue, 28 Apr 2020 05:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EhZPPIm/SE1EEx9TM6dmghnUJz6B/xb1BqvFi8BEt0Y=; b=bkzlswSNG22mJjLL3HtGYAn3BRQZkF0rnRhHlFAibwhYY+g0f7mSSIOayCFDxDHvew 1Vu9vwpQ+uRdFIhGJfnHFOZlq9tyIT6GH+fud4VyuOWRHfuZpYMlpwKuHeeXv9+k2m9k 5JZHWlcmbSt7SODm+6K/Nrx4UEkHLlHuUtxvgKDlpsv84q3vSnb+4/brvTLb0K1VKtLa 3p+iZz0QoSYfyaZyhXnZFrzSbHi1CvuiGKYE9dk02Hv8+YXd6tjCmy8d/QxnMJS2qvZc lP3EYT83Zw4SfYJgbdJ1hhB6vGNUdrgfuJ4b7/qBOKWqkeHiZ/olrPniK5MALis21kTv KVAg== X-Gm-Message-State: AGi0PubrIVYMFDTwkYJ4kBTcPkyUV2cTtvxLV/zCpj5OvGxvm81fSGzA uyo41lGYtllDD9fD04BkCA9xG9X5JNmGvhPzAVCDer2bRhS5xWoO/sdVTOQqj5qZFluyx4kUWDO u8Vaim1o8nG57rw== X-Received: by 2002:adf:f990:: with SMTP id f16mr30616310wrr.33.1588078049922; Tue, 28 Apr 2020 05:47:29 -0700 (PDT) X-Google-Smtp-Source: APiQypJoaC0bsE6oR0voMKJT0tuIZohI0coSSchz0GT/ak8u2NhyNE1rF5xrx9CWrw6egwASlwkAgQ== X-Received: by 2002:adf:f990:: with SMTP id f16mr30616298wrr.33.1588078049760; Tue, 28 Apr 2020 05:47:29 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id e13sm15919534wrp.15.2020.04.28.05.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 05:47:28 -0700 (PDT) Subject: Re: [PATCH 7/7] ArmVirtPkg: control PXEv4 / PXEv6 boot support from the QEMU command line To: Laszlo Ersek , edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , Per Sundstrom References: <20200424075353.8489-1-lersek@redhat.com> <20200424075353.8489-8-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <84ed04e9-16f8-fc8b-450f-9395e743a36e@redhat.com> Date: Tue, 28 Apr 2020 14:47:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200424075353.8489-8-lersek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/24/20 9:53 AM, Laszlo Ersek wrote: > Port the DSC file changes from the similarly titled OvmfPkg patch in this > series to ArmVirtPkg. >=20 > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Per Sundstrom > Cc: Philippe Mathieu-Daud=C3=A9 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2681 > Signed-off-by: Laszlo Ersek > --- > ArmVirtPkg/ArmVirtQemu.dsc | 13 +++++++++++++ > ArmVirtPkg/ArmVirtQemuKernel.dsc | 13 +++++++++++++ > 2 files changed, 26 insertions(+) >=20 > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 1233f1ece484..3f649c91d8d6 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -58,6 +58,7 @@ [LibraryClasses.common] > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDev= iceLib.inf > QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.= inf > + QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/Qemu= FwCfgSimpleParserLib.inf > QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuL= oadImageLib.inf > =20 > ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformL= ibNull.inf > @@ -256,6 +257,12 @@ [PcdsDynamicDefault.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0 > gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE > =20 > + # > + # IPv4 and IPv6 PXE Boot support. > + # > + gEfiNetworkPkgTokenSpaceGuid.PcdIPv4PXESupport|0x01 > + gEfiNetworkPkgTokenSpaceGuid.PcdIPv6PXESupport|0x01 > + > # > # TPM2 support > # > @@ -430,6 +437,12 @@ [Components.common] > # Networking stack > # > !include NetworkPkg/NetworkComponents.dsc.inc > + > + NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf { > + > + NULL|OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf > + } > + > !if $(NETWORK_TLS_ENABLE) =3D=3D TRUE > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf { > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKer= nel.dsc > index 0af91f21b7b7..2a6fd6bc06be 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -56,6 +56,7 @@ [LibraryClasses.common] > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDev= iceLib.inf > QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.= inf > + QemuFwCfgSimpleParserLib|OvmfPkg/Library/QemuFwCfgSimpleParserLib/Qemu= FwCfgSimpleParserLib.inf > QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuL= oadImageLib.inf > =20 > ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemIn= foLib.inf > @@ -239,6 +240,12 @@ [PcdsDynamicDefault.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0 > gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE > =20 > + # > + # IPv4 and IPv6 PXE Boot support. > + # > + gEfiNetworkPkgTokenSpaceGuid.PcdIPv4PXESupport|0x01 > + gEfiNetworkPkgTokenSpaceGuid.PcdIPv6PXESupport|0x01 > + > #######################################################################= ######### > # > # Components Section - list of all EDK II Modules needed by this Platfo= rm > @@ -369,6 +376,12 @@ [Components.common] > # Networking stack > # > !include NetworkPkg/NetworkComponents.dsc.inc > + > + NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf { > + > + NULL|OvmfPkg/Library/PxeBcPcdProducerLib/PxeBcPcdProducerLib.inf > + } > + > !if $(NETWORK_TLS_ENABLE) =3D=3D TRUE > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf { > >=20 Reviewed-by: Philippe Mathieu-Daude