Re: [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 5/12/20 7:15 PM, Leif Lindholm wrote:
> On Tue, May 12, 2020 at 18:41:17 +0200, Ard Biesheuvel wrote:
>> This is a followup to Samer's v1 [0], and incorporates all the delta
>> changes posted for review over the past couple of days. This is a
>> roundup of all that work, and therefore supersedes it.
>>
>> It provides an implementation of the SimpleNetworkProtocol for the
>> Raspberry Pi4's GENET network controller, in a way that adheres to the
>> UEFI driver model.
>>
>> The original submission was provided by Jared, based on Jeremy's MAC
>> programming-only driver and the existing BSD driver for the GENET IP.
>> Cumulative changes and fixes as well as review feedback were provided
>> by all of the below.
>>
>> Changes since v2:
>> - replace 'master' include with per C file includes of the required
>>    headers
>> - add comments describing the PHY registers to GenericPhy.h
>> - split off patch #5 from subsequent ConfigDxe change
>> - other minor style fixes suggested by Leif
>> - add Leif's ack where given
> 
> Thanks!
> For remaining patches in set:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 

Pushed as bfa32ac70a75..8977ff44a573

Thanks all!