From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.10565.1589304090117886122
 for <devel@edk2.groups.io>;
 Tue, 12 May 2020 10:21:30 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CFD01FB;
	Tue, 12 May 2020 10:21:29 -0700 (PDT)
Received: from [192.168.1.81] (unknown [10.37.8.255])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18FB23F305;
	Tue, 12 May 2020 10:21:26 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: philmd@redhat.com, Pete Batard <pete@akeo.ie>,
 Jared McNeill <jmcneill@invisible.ca>,
 Andrei Warkentin <awarkentin@vmware.com>,
 Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
 Jeremy Linton <jeremy.linton@arm.com>
References: <20200512164125.28139-1-ard.biesheuvel@arm.com>
 <20200512171539.GM21486@vanye>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <85034ab1-a72e-eccd-a89d-f6fb49cbba3b@arm.com>
Date: Tue, 12 May 2020 19:21:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200512171539.GM21486@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 5/12/20 7:15 PM, Leif Lindholm wrote:
> On Tue, May 12, 2020 at 18:41:17 +0200, Ard Biesheuvel wrote:
>> This is a followup to Samer's v1 [0], and incorporates all the delta
>> changes posted for review over the past couple of days. This is a
>> roundup of all that work, and therefore supersedes it.
>>
>> It provides an implementation of the SimpleNetworkProtocol for the
>> Raspberry Pi4's GENET network controller, in a way that adheres to the
>> UEFI driver model.
>>
>> The original submission was provided by Jared, based on Jeremy's MAC
>> programming-only driver and the existing BSD driver for the GENET IP.
>> Cumulative changes and fixes as well as review feedback were provided
>> by all of the below.
>>
>> Changes since v2:
>> - replace 'master' include with per C file includes of the required
>>    headers
>> - add comments describing the PHY registers to GenericPhy.h
>> - split off patch #5 from subsequent ConfigDxe change
>> - other minor style fixes suggested by Leif
>> - add Leif's ack where given
> 
> Thanks!
> For remaining patches in set:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 

Pushed as bfa32ac70a75..8977ff44a573

Thanks all!