From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.16035.1591196585353620959 for ; Wed, 03 Jun 2020 08:03:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V7xd4hTs; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591196584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oay/7gPdJ2+jOTNA1iMaCYh9C6h4KTeWVtpGYpn8Bzc=; b=V7xd4hTsD7PB5n6CrZSjQk/uhMAORs4ZsSl4c4w0uHRa7g092AcHAapMarFi9Ghi0ISbyw eeTfpVbTXUF3frP3UAPW6ZYorBjJ/5eEFcO0aT8xfotpMCH6480HIaRoL61qwErttvdku+ QP5gC0fmC9H32LELusqZwjcYUXGKPps= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-WanQcHb1NIGPZlC4Qtl17A-1; Wed, 03 Jun 2020 11:03:00 -0400 X-MC-Unique: WanQcHb1NIGPZlC4Qtl17A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E56D180B737; Wed, 3 Jun 2020 15:02:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-50.ams2.redhat.com [10.36.115.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FF125D9CD; Wed, 3 Jun 2020 15:02:41 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules. From: "Laszlo Ersek" To: devel@edk2.groups.io, eric.dong@intel.com Cc: Jiewen Yao , Jian J Wang , Chao Zhang , Min Xu References: <20200603031806.1699-1-eric.dong@intel.com> <20200603031806.1699-3-eric.dong@intel.com> Message-ID: <851c4c47-979a-cc69-3517-5beaa6cf49e3@redhat.com> Date: Wed, 3 Jun 2020 17:02:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/03/20 16:57, Laszlo Ersek wrote: > On 06/03/20 05:18, Dong, Eric wrote: >> Signed-off-by: Eric Dong >> Cc: Jiewen Yao >> Cc: Jian J Wang >> Cc: Chao Zhang >> Cc: Min Xu >> --- >> Maintainers.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 954dc567e0..573084e086 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/ >> R: Qi Zhang >> R: Rahul Kumar >> >> +SecurityPkg: Secure boot related modules >> +F: SecurityPkg/Library/DxeImageVerificationLib/ >> +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/ >> +F: SecurityPkg/Library/AuthVariableLib/ >> +R: Min Xu >> + >> ShellPkg >> F: ShellPkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg >> > > (1) please replace "security boot" with "secure boot" in the subject. > > with that fixed: > > Acked-by: Laszlo Ersek > (2) If I remember correctly, we originally wanted the section headers in the Maintainers.txt file to remain alphabetically sorted. This patch would create disorder: SecurityPkg: Tcg related modules SecurityPkg: Secure boot related modules Therefore please add the "SecurityPkg: Secure boot related modules" section above the "SecurityPkg: Tcg related modules" section. With (1) and (2) fixed: Acked-by: Laszlo Ersek (Now I do realize there is already some disorder in the Maintainers.txt file; I'll post a patch for fixing the OvmfPkg-related ones.) Thanks Laszlo