From: "Lin, Derek (HPS SW)" <derek.lin2@hpe.com>
To: Bob Feng <bob.c.feng@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include
Date: Wed, 16 Oct 2019 19:02:11 -0700 [thread overview]
Message-ID: <8529.1571277731931002832@groups.io> (raw)
In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16154B6BD@SHSMSX104.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
Hi Phillippe,
Yeah, I forgot to fill my example. Thanks for the catch.
It is exactly as Bob mentioned, #include MACRO(xxx.h).
There are silicon code use macro to separate definitions, and use the approach to reuse code. Like:
#define PATH(x) <silicon1/x.h> // in platform 1
#define PATH(x) <silicon2/x.h> // in platform 2
#include PATH(abc.h) // in common code
[-- Attachment #2: Type: text/html, Size: 434 bytes --]
prev parent reply other threads:[~2019-10-17 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 6:17 [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include Lin, Derek (HPS SW)
2019-10-16 11:53 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-17 0:38 ` Bob Feng
2019-10-17 2:02 ` Lin, Derek (HPS SW) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8529.1571277731931002832@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox