Re: [edk2-devel] [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI

["Laszlo Ersek" <lersek@redhat.com>]

On 11/10/20 18:36, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
>
> There is a plan to make MD5 disable as default.
> The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES
> would be introduced to enable MD5. Make the
> definition ahead of the change to avoid build
> error after the MACRO changed.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  NetworkPkg/Network.dsc.inc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc
> index 16f090a187..b761df900b 100644
> --- a/NetworkPkg/Network.dsc.inc
> +++ b/NetworkPkg/Network.dsc.inc
> @@ -30,6 +30,11 @@
>  [LibraryClasses]
>  !include NetworkPkg/NetworkLibs.dsc.inc
>
> +[BuildOptions]
> +!if $(NETWORK_ISCSI_ENABLE) == TRUE
> +  *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES
> +!endif
> +
>  !if $(PLATFORMX64_ENABLE) == TRUE
>  [Components.X64]
>  !include NetworkPkg/NetworkComponents.dsc.inc
>

I was not CC'd on this patch.

Comment (2) in my review of

  [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: Enable MD5 while enable iSCSI

actually relates to this patch. (I made that comment there because I was
not CC'd on the present patch, and I'm learning of the present patch
only now, after having reviewed the ArmVirtQemu patch.)

I'll repeat the same points here:


(2a) The patch should create the following file:

  NetworkPkg/NetworkBuildOptions.dsc.inc

with the following contents:

> # Network DSC include file for the [BuildOptions*] sections of all
> # Architectures.
> #
> # This file can be included in the [BuildOptions*] section(s) of a platform
> # DSC file by using "!include NetworkPkg/NetworkBuildOptions.dsc.inc", to
> # specify the C language feature test macros (eg., API deprecation macros)
> # according to the flags described in "NetworkDefines.dsc.inc".
>
> !if $(NETWORK_ISCSI_ENABLE) == TRUE
>   MSFT:*_*_*_CC_FLAGS = /D ENABLE_MD5_DEPRECATED_INTERFACES
>   INTEL:*_*_*_CC_FLAGS = /D ENABLE_MD5_DEPRECATED_INTERFACES
>   GCC:*_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES
>   RVCT:*_*_*_CC_FLAGS = -DENABLE_MD5_DEPRECATED_INTERFACES
> !endif


(2b) The patch should append (or insert) the following section to
"NetworkPkg/Network.dsc.inc":

> [BuildOptions]
> !include NetworkPkg/NetworkBuildOptions.dsc.inc

Thanks,
Laszlo