From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.14276.1605133121460917792 for ; Wed, 11 Nov 2020 14:18:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gsJ/nSM/; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605133120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lq+G6DzUa86h5x25oeuPD3Olaxf1VlevOBS0X+iix6w=; b=gsJ/nSM/779pfCAJsKAXu4yr1jB/OkatUiz/QWxpXVJQKGpuVQmSPw+IKyr681gpM3VptB vmBAUWVdOc6OmoRelOla2umxwUGi4RfqVPIBeTGefQ/BDP6l6uFfK/ZypQ+g57zHOcn+pO 5BNvdJVm2PsH7tJb0LDFY9Zf+8V40gQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-Pw_JPsxgMEq1qrhldaNdeQ-1; Wed, 11 Nov 2020 17:18:38 -0500 X-MC-Unique: Pw_JPsxgMEq1qrhldaNdeQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2FBD107465A; Wed, 11 Nov 2020 22:18:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-85.ams2.redhat.com [10.36.113.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8700F7366F; Wed, 11 Nov 2020 22:18:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu References: <20201110173651.54036-1-zhichao.gao@intel.com> <20201110173651.54036-5-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <853f46a3-f189-e267-28eb-d74095dc5094@redhat.com> Date: Wed, 11 Nov 2020 23:18:35 +0100 MIME-Version: 1.0 In-Reply-To: <20201110173651.54036-5-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/10/20 18:36, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES > would be introduced to enable MD5. Make the > definition ahead of the change to avoid build > error after the MACRO changed. > > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Zhichao Gao > --- > NetworkPkg/Network.dsc.inc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc > index 16f090a187..b761df900b 100644 > --- a/NetworkPkg/Network.dsc.inc > +++ b/NetworkPkg/Network.dsc.inc > @@ -30,6 +30,11 @@ > [LibraryClasses] > !include NetworkPkg/NetworkLibs.dsc.inc > > +[BuildOptions] > +!if $(NETWORK_ISCSI_ENABLE) == TRUE > + *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES > +!endif > + > !if $(PLATFORMX64_ENABLE) == TRUE > [Components.X64] > !include NetworkPkg/NetworkComponents.dsc.inc > I was not CC'd on this patch. Comment (2) in my review of [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: Enable MD5 while enable iSCSI actually relates to this patch. (I made that comment there because I was not CC'd on the present patch, and I'm learning of the present patch only now, after having reviewed the ArmVirtQemu patch.) I'll repeat the same points here: (2a) The patch should create the following file: NetworkPkg/NetworkBuildOptions.dsc.inc with the following contents: > # Network DSC include file for the [BuildOptions*] sections of all > # Architectures. > # > # This file can be included in the [BuildOptions*] section(s) of a platform > # DSC file by using "!include NetworkPkg/NetworkBuildOptions.dsc.inc", to > # specify the C language feature test macros (eg., API deprecation macros) > # according to the flags described in "NetworkDefines.dsc.inc". > > !if $(NETWORK_ISCSI_ENABLE) == TRUE > MSFT:*_*_*_CC_FLAGS = /D ENABLE_MD5_DEPRECATED_INTERFACES > INTEL:*_*_*_CC_FLAGS = /D ENABLE_MD5_DEPRECATED_INTERFACES > GCC:*_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES > RVCT:*_*_*_CC_FLAGS = -DENABLE_MD5_DEPRECATED_INTERFACES > !endif (2b) The patch should append (or insert) the following section to "NetworkPkg/Network.dsc.inc": > [BuildOptions] > !include NetworkPkg/NetworkBuildOptions.dsc.inc Thanks, Laszlo