From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.7262.1649169997456082794
 for <devel@edk2.groups.io>;
 Tue, 05 Apr 2022 07:46:37 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Dcl7K7mL;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.46.36])
	by linux.microsoft.com (Postfix) with ESMTPSA id 2A9BD20DFD72;
	Tue,  5 Apr 2022 07:46:36 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2A9BD20DFD72
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1649169996;
	bh=/ihvnL7AMJOMSqKHQVrCC8cQL94jkdx0JtnSOHSX9bQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=Dcl7K7mLbLEtUyrQKbuKloCpMVprEB1yI2XVOIuN7NGRybV30ASoFK4PIBKh4U0Fr
	 KyybnFe4jRZ/uhPmhJMgDHPSWY4Ot4IQKCAmzMHbVwXU1rYu12kxUrSjmZgz1qlndk
	 8J5iZStPmls+17gU5rJ3yxYVOfC2IFDWg3SfH0fw=
Message-ID: <85400393-0b1e-6efa-b5c5-34b2bb2a4823@linux.microsoft.com>
Date: Tue, 5 Apr 2022 10:46:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default
To: Rebecca Cran <quic_rcran@quicinc.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>
References: <20220210161927.1847-1-mikuback@linux.microsoft.com>
 <7ab3cb92-85e1-c8ec-fc4e-20ae84a65c2f@quicinc.com>
 <d12c1b4f-4706-2a20-a9e5-6d434d65b832@linux.microsoft.com>
 <788b70e7-3d38-dbd1-35a9-39eab17ac0fd@quicinc.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <788b70e7-3d38-dbd1-35a9-39eab17ac0fd@quicinc.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

It is printed in the error log. For your current PR:
https://github.com/tianocore/edk2/pull/2744

The results are printed in "Standard_Error_Output.log":
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=47584&view=ms.vss-test-web.build-test-results-tab&runId=346168&resultId=100012&paneView=attachments

These are the results:

"""
Files with formatting errors:
  Formatting errors in Library/ArmSmcLib/ArmSmc.c
  --- /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
  +++ 
/home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c.uncrustify_plugin
  @@ -25,10 +25,10 @@
  IN OUT UINTN  *Arg1 OPTIONAL,
  IN OUT UINTN  *Arg2 OPTIONAL,
  IN OUT UINTN  *Arg3 OPTIONAL
  -)
  +  )
  {
  ARM_SMC_ARGS  Args;
  -  UINTN    ErrorCode;
  +  UINTN         ErrorCode;

  ZeroMem (&Args, sizeof (ARM_SMC_ARGS));

  @@ -80,7 +80,7 @@
  IN     UINTN  Function,
  IN OUT UINTN  *Arg1 OPTIONAL,
  IN OUT UINTN  *Arg2 OPTIONAL,
  -  OUT UINTN *Arg3 OPTIONAL
  +  OUT UINTN     *Arg3 OPTIONAL
  )
  {
  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
  @@ -102,7 +102,7 @@
  IN OUT UINTN  *Arg1 OPTIONAL,
  OUT UINTN     *Arg2 OPTIONAL,
  OUT UINTN     *Arg3 OPTIONAL
  -)
  +  )
  {
  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
  }
"""

These diffs can get very verbose and will overwhelm people if printed to 
standard console output. They are cleanly separated here.

Thanks,
Michael

On 4/5/2022 10:31 AM, Rebecca Cran wrote:
> So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix 
> anything, because we don't output TestSuites.xml to the console: if I 
> introduce a code style issue into a branch, CI still only prints the 
> following:
> 
> PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test NO-TARGET --
> WARNING - A file header template is not specified in the config file.
> WARNING - A function header template is not specified in the config file.
> ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
> returned 1
> ERROR - Overall Build Status: Error
> PROGRESS - There were 1 failures out of 13 attempts
> 
> 
> Could we get the diff printed *there* too?
>