From: rebecca@bluestop.org
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Cc: Ting Ye <ting.ye@intel.com>, Gang Wei <gang.wei@intel.com>,
Jian Wang <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD
Date: Sat, 20 Apr 2019 11:18:19 -0600 [thread overview]
Message-ID: <8544dcc5-7817-fd5a-abe1-98ee00e6400a@bluestop.org> (raw)
In-Reply-To: <CAKv+Gu-YeMjpuKCCMLDwypbqB5MMNc6g1zcmdvqeWqV2fAydbQ@mail.gmail.com>
On 2019-04-20 05:28, Ard Biesheuvel wrote:
>
> This is slightly odd. The host architecture shouldn't really matter,
> and so if we end up calling different code in UEFI when built on *BSD,
> there is differently something wrong. Or am I missing something?
No, that's a good point. I guess it's something we don't ever call.
In fact, OVMF continues to build after removing crypto/uid.c (which
contains the OPENSSL_issetugid definition) from
CryptoPkg/Library/OpensslLib/OpensslLib.inf and
CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf .
--
Rebecca Cran
next prev parent reply other threads:[~2019-04-20 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 22:38 [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD rebecca
2019-04-20 11:28 ` [edk2-devel] " Ard Biesheuvel
2019-04-20 11:30 ` Ard Biesheuvel
2019-04-20 17:18 ` rebecca [this message]
2019-04-22 13:46 ` Wang, Jian J
2019-04-24 9:25 ` Philippe Mathieu-Daudé
2019-04-24 19:17 ` Laszlo Ersek
2019-04-24 19:29 ` rebecca
2019-04-24 19:36 ` rebecca
2019-04-25 1:06 ` Wang, Jian J
2019-04-26 13:55 ` rebecca
2019-04-26 13:56 ` Andrew Fish
2019-04-26 14:07 ` rebecca
2019-04-26 20:19 ` Laszlo Ersek
2019-04-27 0:06 ` rebecca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8544dcc5-7817-fd5a-abe1-98ee00e6400a@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox