Re: [edk2-devel] [PATCH v2 1/3] Revert "OvmfPkg/QemuKernelLoaderFsDxe: don't expose kernel command line"

["Dov Murik" <dovmurik@linux.ibm.com>]

On 24/06/2021 16:46, Laszlo Ersek wrote:
> On 06/17/21 14:16, Dov Murik wrote:
>> This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441.
>>
>> Manually fixed conflicts in:
>>   OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c
>>
>> Note that besides re-exposing the kernel command line as a file in the
>> synthetic filesystem, we also revert back to AllocatePool instead of
>> AllocatePages.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
>> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
>> ---
>>  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> (1) The bugzilla ticket should be referenced in the commit message,
> above your signoff:
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
> 

Will do. Maybe worth adding a mention of this requirement in your
contributor guide [1].

[1] https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05


> With that update:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!

-Dov