From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.3040.1624784293673788811 for ; Sun, 27 Jun 2021 01:58:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=IfaKo2he; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15R8Y7pf018616; Sun, 27 Jun 2021 04:58:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=m+Q+16SSxy+nGNKMf1HTW8NsG3khevw+IaIZv20ET+E=; b=IfaKo2heqda1kWrvKwhplZf4rMpF7k/UG9hX0gSN2k1sIPBQFFuQOiV4tmy6QTSJhXar 04zRi8UWH9SN0EmZ037iPv4FupY4gRKUHmgfwXAoJPRoLl/6juxym49V2lLCX+sCGEWB dfn4pVgMo1iI3wPCe+4lyRlQ3k3/NbCXNqIucJg1b6h4SaaJnxXA6/nc+Gu0xdQRrr9z oqrsjB0Fr/AhX4Sj9hrq0vwyPEzlsdjpl0mZvAg2Ijj24bEqnftD20OU4q07Deq+inVA 29CFvZeODfm7aS5vTnRI+giuPQ31CBBV+KP6okdtnERzPyRbgFNJmeXoQsAl1ztyGKNl xQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 39enpqgg27-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 04:58:12 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15R8ovGi065627; Sun, 27 Jun 2021 04:58:12 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 39enpqgg1y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 04:58:11 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15R8qEIJ014485; Sun, 27 Jun 2021 08:58:10 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04ams.nl.ibm.com with ESMTP id 39duv8gbdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 08:58:10 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15R8w7qe33685956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 27 Jun 2021 08:58:07 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 52CF6A4062; Sun, 27 Jun 2021 08:58:07 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33DEFA405B; Sun, 27 Jun 2021 08:58:05 +0000 (GMT) Received: from [9.160.49.135] (unknown [9.160.49.135]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 27 Jun 2021 08:58:04 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v2 1/3] Revert "OvmfPkg/QemuKernelLoaderFsDxe: don't expose kernel command line" To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum , dovmurik@linux.ibm.com References: <20210617121700.2883073-1-dovmurik@linux.ibm.com> <20210617121700.2883073-2-dovmurik@linux.ibm.com> <833fb66f-fa38-c8d0-ffef-d4115cf6a2b5@redhat.com> From: "Dov Murik" Message-ID: <856ff524-4d5e-3238-f034-fed34529f4ac@linux.ibm.com> Date: Sun, 27 Jun 2021 11:58:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <833fb66f-fa38-c8d0-ffef-d4115cf6a2b5@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: JOvyNn8nhSdgMyMqvW4oXJFG8_eRwgqk X-Proofpoint-ORIG-GUID: gjSHFs4cGGEWmA4nxQ4reytcOlB2VrMJ X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-06-26_15:2021-06-25,2021-06-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106270061 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24/06/2021 16:46, Laszlo Ersek wrote: > On 06/17/21 14:16, Dov Murik wrote: >> This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441. >> >> Manually fixed conflicts in: >> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c >> >> Note that besides re-exposing the kernel command line as a file in the >> synthetic filesystem, we also revert back to AllocatePool instead of >> AllocatePages. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: James Bottomley >> Cc: Tobin Feldman-Fitzthum >> Signed-off-by: Dov Murik >> --- >> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) > > (1) The bugzilla ticket should be referenced in the commit message, > above your signoff: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > Will do. Maybe worth adding a mention of this requirement in your contributor guide [1]. [1] https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 > With that update: > > Reviewed-by: Laszlo Ersek Thanks! -Dov