From: "PierreGondois" <pierre.gondois@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: Alexei.Fedorov@arm.com, steven.price@arm.com,
Lorenzo.Pieralisi@arm.com, Matteo.Carlini@arm.com,
Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, ray.ni@intel.com,
zhichao.gao@intel.com, nd@arm.com
Subject: Re: [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.d spec
Date: Wed, 13 Jul 2022 14:22:40 +0200 [thread overview]
Message-ID: <857c480b-95ed-cb76-69f1-de4b0d7ec9a8@arm.com> (raw)
In-Reply-To: <20220712143141.18516-7-sami.mujawar@arm.com>
Hi Sami,
> +
> /**
> Helper Macro for populating the IORT Node header in the ACPI_PARSER array.
>
> @@ -108,15 +160,15 @@ ValidateItsIdArrayReference (
> @param [out] ValidateIdArrayReference Optional pointer to a function for
> validating the ID Array reference.
> **/
> -#define PARSE_IORT_NODE_HEADER(ValidateIdMappingCount, \
> - ValidateIdArrayReference) \
> - { L"Type", 1, 0, L"%d", NULL, (VOID**)&IortNodeType, NULL, NULL }, \
> - { L"Length", 2, 1, L"%d", NULL, (VOID**)&IortNodeLength, NULL, NULL }, \
> - { L"Revision", 1, 3, L"%d", NULL, NULL, NULL, NULL }, \
> - { L"Reserved", 4, 4, L"0x%x", NULL, NULL, NULL, NULL }, \
> - { L"Number of ID mappings", 4, 8, L"%d", NULL, \
> - (VOID**)&IortIdMappingCount, ValidateIdMappingCount, NULL }, \
> - { L"Reference to ID Array", 4, 12, L"0x%x", NULL, \
> +#define PARSE_IORT_NODE_HEADER(ValidateIdMappingCount, \
> + ValidateIdArrayReference) \
> + { L"Type", 1, 0, L"%d", NULL, (VOID**)&IortNodeType, NULL, NULL }, \
> + { L"Length", 2, 1, L"%d", NULL, (VOID**)&IortNodeLength, NULL, NULL }, \
> + { L"Revision", 1, 3, L"%d", NULL, (VOID**)&IortNodeRevision, NULL, NULL }, \
> + { L"Identifier", 4, 4, L"0x%x", NULL, NULL, NULL, NULL }, \
> + { L"Number of ID mappings", 4, 8, L"%d", NULL, \
> + (VOID**)&IortIdMappingCount, ValidateIdMappingCount, NULL }, \
> + { L"Reference to ID Array", 4, 12, L"0x%x", NULL, \
> (VOID**)&IortIdMappingOffset, ValidateIdArrayReference, NULL }
Sorry to come back on this patch, but it seems the identifier field was
16 bits long in rev E (=1) and increased to 32 bits in rev E.a (=2),
so unfortunately, an extra case should be created for this I believe.
Regards,
Pierre
next prev parent reply other threads:[~2022-07-13 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 14:31 [PATCH v5 0/8] IORT Rev E.d specification updates Sami Mujawar
2022-07-12 14:31 ` [PATCH v5 1/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Sami Mujawar
2022-07-12 14:31 ` [PATCH v5 2/8] DynamicTablesPkg: Handle error when IdMappingToken is NULL Sami Mujawar
2022-07-12 14:31 ` [PATCH v5 3/8] DynamicTablesPkg: IORT set reference to Id array only if present Sami Mujawar
2022-07-12 14:31 ` [PATCH v5 4/8] DynamicTablesPkg: IORT set reference to interrupt array " Sami Mujawar
2022-07-13 12:08 ` PierreGondois
2022-07-13 16:10 ` PierreGondois
2022-07-12 14:31 ` [PATCH v5 5/8] MdePkg: IORT header update for IORT Rev E.d spec Sami Mujawar
2022-07-13 7:42 ` 回复: [edk2-devel] " gaoliming
2022-07-12 14:31 ` [PATCH v5 6/8] ShellPkg: Acpiview: IORT parser " Sami Mujawar
2022-07-13 12:10 ` PierreGondois
2022-07-13 16:39 ` Sami Mujawar
2022-07-13 16:42 ` Sami Mujawar
2022-07-13 12:22 ` PierreGondois [this message]
2022-07-12 14:31 ` [PATCH v5 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.d Sami Mujawar
2022-07-12 14:31 ` [PATCH v5 8/8] DynamicTablesPkg: IORT generator updates for Rev E.d spec Sami Mujawar
2022-07-13 12:18 ` PierreGondois
2022-07-13 17:07 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857c480b-95ed-cb76-69f1-de4b0d7ec9a8@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox