From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 438057803D8 for ; Wed, 3 Jan 2024 11:34:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iiw/5yKQ7uALM+wJfdQ7tQcxjUkAd6doFBVRLLWziyI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704281645; v=1; b=V7ME+2uzKFkP3W30Unj6AQwwNmKKfh2rUwXraR3ZTo9L35l0jeQtgxI7DQquo5hdZYVP55tu RW4TcXMOhLMou7uJFgE2sZws3ENl9N1axFQlb2cb4XyTzApzKPh9cT92og37ooJzbZQYEGhXxen 2M+n1Euqy2q6Q+OMARb5PYJM= X-Received: by 127.0.0.2 with SMTP id yxmwYY7687511xzemizs1NVT; Wed, 03 Jan 2024 03:34:05 -0800 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.74]) by mx.groups.io with SMTP id smtpd.web10.15668.1704281643191653782 for ; Wed, 03 Jan 2024 03:34:04 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VKL4jj4SSl7sjuQNJ0HNsHGmrQMWZbZO80YNj5+35spp95MTuVecc6zexdLbwHGWF8TfAZv2YZ6FS38IzjLaRdCi/QzyD0BLaeRIZr+ErJSoEu8xV93P0dbJlQvMCIm+eZC5BcW5bFkGjnWUOe3ayjFGOFPkIcKIhyHW1vG3hm6KER4XcLyTFXaEwvtfeogcEmo83xR7CryJN/Q3676vt949E9GO2z0qQiD4KNELUjMYk19un4bho9FQbj0eaYFS0zT3J9fNJlW1mfJFnqGhnkyZhXb17xSZLNFevTyMJUlEzeRUFIjorVMrFpEnjK5lYhC9yWGhe/EZuEdAd+sv5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRFi69HqwJ/E7oLwQ2LlHzgK3TJBngg9xdYtPSkKv2s=; b=eViDowe/HdFf9ldL1qElBgnSRZIr+nSpkYeCg4rPqPMSGYbjGu5FSz0tqZOu68524nG7Daw/U7bygO83S8hGOOZ1AuguALwK0ba2twLcnZzn/vAP2wvvoBDbIlzA6dpSP/C5xlxRBGNWTxjmbgZdrkLodri02CadCtJeNgmxG+VVlj2k8A4TehQ6HE85mAuoQotY4zjK2v2INK6PbAobKe/hhKUtn9/srfUGU6zA6qfqJ9cQWYj9KrdtpVai50TOUf7i3Ep/A0o3pRbR28xgDmDJnDgWyD9RwJIXw3oU8iPVsdrmn1JZwqVd1n+zPQ4dJZRzW0dvGXoY9Yiq5BMHTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DUZPR01CA0277.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::21) by DBAPR08MB5608.eurprd08.prod.outlook.com (2603:10a6:10:1a5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 11:33:54 +0000 X-Received: from DU6PEPF00009527.eurprd02.prod.outlook.com (2603:10a6:10:4b9:cafe::b5) by DUZPR01CA0277.outlook.office365.com (2603:10a6:10:4b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13 via Frontend Transport; Wed, 3 Jan 2024 11:33:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009527.mail.protection.outlook.com (10.167.8.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 11:33:54 +0000 X-Received: ("Tessian outbound 3dfbe14a1a3c:v239"); Wed, 03 Jan 2024 11:33:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f364f7f29362fd6a X-CR-MTA-TID: 64aa7808 X-Received: from 868357ba3a07.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EFC0CC8E-E8E6-4C72-A9FA-105B8FC7EAC1.1; Wed, 03 Jan 2024 11:33:48 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 868357ba3a07.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Jan 2024 11:33:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hTJbgV1BoC5h/9OvoRiGFBCqnxnf2FUpDhP1/KjHVYuyzJ9177In+7GhK9qheAOUJ+EmDO+ahkmw2byLj7ZToOW0qFhOp/pdIkXR+avQ24NDkGxquN9DdcdHsmKf36JQ+2pPK/Soagl3iiJtoMn6UK5gJzhvIhPrM/wqcTfweingo8wuJ0sUP5X0DnfM91vl/T2Ozp35OrcXjvo1pzR02FyEKR/wYVInC0s1EbGNTbwr9MC5sNS5joS2wYfyBpd72nBtb7De8T5XheV4zMz2H6hRNLlhX2B1BSeKIizK1BFIsNtw/mDJ+RPgOjTgwWuMfM+6IVnjJN+/Wm/C5YCodg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRFi69HqwJ/E7oLwQ2LlHzgK3TJBngg9xdYtPSkKv2s=; b=I4oYg2Xdqpd8uHGYMipbEBMoIhIuk9hRehM1NOWQhNS7WQwbM5wY8Go+Lpbup9G3gXhAu1uIS9+AnvJvkjtb7jEryU3lGpvJXpz10mmR1RUSEh7vQC4NRuLhue11/v6/bZtCRzAJjDFlNM01ehCgIafpSsEzwWL+w/3ON3flkFZSJIuwK3peRCogCWRlQN4l5UqRnoSPby3Bgd01+kmd/M74SulyXd8xRGFVA7oE5/LExrnDvCr80fgcUAcrvNwNtKdCp+ELJdznZbq92Y59ZvkUsVUspoaBNzKpzRBQCDVse9tWM+kWW2NmeTidoKQ9xiY+dNntdwSEH17/7jSRtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PA4PR08MB7412.eurprd08.prod.outlook.com (2603:10a6:102:2a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 11:33:46 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 11:33:46 +0000 Message-ID: <857f6eac-d876-425e-96a1-b7684c61f06a@arm.com> Date: Wed, 3 Jan 2024 11:33:45 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors To: Abdul Lateef Attar , devel@edk2.groups.io CC: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO2P265CA0480.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::36) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PA4PR08MB7412:EE_|DU6PEPF00009527:EE_|DBAPR08MB5608:EE_ X-MS-Office365-Filtering-Correlation-Id: 069aaaf3-f465-46f8-1da3-08dc0c4fde1a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z+rTJnueKUsCJWDUftpvdRWwlxZdypSn6MyIN9kOoMILR8i/ivPSAdkRy8OyV+aj1Yf6PRlOE9E8627218QzbLlJ3oBaPQ5uL08oW9r0rbFqIY66esY254NVhJvSu2uBlhYh3Pk2YVdJkJB+OH5ljKVjx8/kXsKsePMMd8BHNBukSL4nbz7wrgQ94Nvz1fUKUArBNyHbO48LMP37FP0jKZgnUdsOjbsp7NjkHI7s+CJ1Fp4fSxViOJM26pOQ3R4Bc3lDt+hY+uXok05pkgQRjFHnqg75WQtnfZ1x+/VRW6mMflDiwbQJTcDZwJaZNTvD2UbuK6yfFfvGZYZ133IuwmiGvRXtF5MxkUmzE4GzzrGqg+foTU3+SQh/1i1e1PUhhSyGhh+7TplCt4pEnJBQfrf+0IMKD/azP9tM4Dbuvw5p0PjCtLqxMKZ/SYbrCDtGH0S+TpUNG0+vwzlsWQy3ayEGbLq/IwFY61wz+JPrRdE6SHmngPjecQZkzDd+TpqmfnkcKO3mI2v+LN/jyHX6ClTRknsVkoFTGaul+FONiAWvCAUgtjUBgkDoStOXNCYGh5EnP93fdHGhfM7XSE28Q0khHhlbZ5F6kEQPP00giPFkIm6EouEo1zPKemaOBP+pyPWI47ZtykMp+j7THYbRjR6oQTFDeHD6X9Jsb3ldthi0cEESauX9QtSgb3Msg0aA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(136003)(346002)(366004)(376002)(230173577357003)(230273577357003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(36756003)(31686004)(66476007)(53546011)(31696002)(6512007)(66556008)(6506007)(6486002)(86362001)(66946007)(38100700002)(83380400001)(41300700001)(2616005)(26005)(2906002)(478600001)(4326008)(8676002)(8936002)(44832011)(316002)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7412 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009527.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 12fb6654-69fa-48e0-0a12-08dc0c4fd90b X-Microsoft-Antispam-Message-Info: pKfJIpxNFF33iHaOGBApRxC95eGSDACAgzvadvvuPKjcoO8KMYuSHGlqUy7KVlSkmCmnsioxzmFp5cpmE3LYuz9EPEkGM02ElwdIHlk5Ao/fJeh1m1/hb+mTxUcM3dJ2wrTIEhRV18xY/u7BY8aF3k8B4sqI6T0VrFNnr4zSRoYh5lj28CKdJJAOqe1yTQR3c/o2Gjy4fX34QqELwNLg18aNSCMgzhPaSKXHAmn5Iw+RH27wJOmMNtrKqqy99xNbnWdG9p/hvwOw4UJTXfoFebSUVVG55PmtG58IwIf4dEf/5ic83kWnPD1pCst9yetxiHTY3z6BZ6m5sGw3tt8SzVi3q3ZVtSCvInBY/cwY/79Wvy2qAlT24T0l4cMNu+QkjF+cgm61Sz9v3/H0X33xrLJHC/vfzvAeI0zDbRryVIwRozydyWxM+7ho6BhbXEHjV4UbXUCJQQVyXhYSyTLWTGSi72XYHHeH1U/2ZC5VESaie3IvaD2ClGq8/j9F1Qa219nKv5sAt/7sqPC0ywyrdS/d2sqFHBpfL0JYI8ZRuEQbf84cSeB5+cDui0ie+4aUMF5PX+0c3spi5MyzgKvQLOweLP+yEh3KUlgyPGEhKWnxqoyrrU8RWHGjk4+ZnniBIaG+hFBdM5j5nzRHrlpRNyinIOW8NMbP90RUlIbiiaE9Vo7duCfIKG0E+8ASfCJcULWgAOqM+oa4rN/TN8/J7EXB2+e2hnZnICVhIbtcuysRVG/Xscyoi7heyvle1s+a7bDgZNeYaYfdMBUSeOQ9wDhZYuqsdFI2chl8l5ZxyVg= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 11:33:54.7970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 069aaaf3-f465-46f8-1da3-08dc0c4fde1a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009527.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5608 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A3Ab6hNVSD8xwYm0NqlyzhJGx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=V7ME+2uz; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abdul, Thank you for this patch. I have some minor suggestions=C2=A0 that I will fix before merging. Otherwi= se=20 this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > Add the support for X64 compilation to the CI. > - Fix the signed and unsigned variable comparision. > warning C4018: '>': signed/unsigned mismatch > - Fix the NOOPT build error for IA32 by replacing > 64bit shift operator with LShiftU64. > > Cc: Pierre Gondois > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > --- > DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- > .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 2 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dyn= amicTablesPkg.dsc > index a2db14efaf..2f35ac82f2 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.dsc > +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc > @@ -15,7 +15,7 @@ > PLATFORM_VERSION =3D 0.1 > DSC_SPECIFICATION =3D 0x0001001a > OUTPUT_DIRECTORY =3D Build/DynamicTables > - SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|X64 > + SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|IA32|X64 > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER =3D DEFAULT > =20 > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/Configuration= ManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Conf= igurationManagerObjectParser.c > index ce494816ed..c1a7528419 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManager= ObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManager= ObjectParser.c > @@ -1130,7 +1130,7 @@ ParseCmObjDesc ( > &RemainingSize, > 1 > ); > - if ((RemainingSize > CmObjDesc->Size) || > + if ((RemainingSize > (INTN)CmObjDesc->Size) || > (RemainingSize < 0)) > { > ASSERT (0); > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c= b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > index e33d6e656b..12c67b9811 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > @@ -170,7 +170,7 @@ AddAcpiHeader ( > CfgMfrInfo->OemId[2], > CfgMfrInfo->OemId[3] > ) | > - ((UINT64)Generator->AcpiTableSignature << 3= 2); > + LShiftU64 ((UINT64)Generator->AcpiTableSign= ature, 32); [SAMI] Minor alignment required to keep the line width within 80 characters= . > } > =20 > // UINT32 OemRevision > @@ -257,7 +257,7 @@ AddSsdtAcpiHeader ( > CfgMfrInfo->OemId[2], > CfgMfrInfo->OemId[3] > ) | > - ((UINT64)Generator->AcpiTableSignature << 32); > + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); > } > =20 > if (AcpiTableInfo->OemRevision !=3D 0) { -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113069): https://edk2.groups.io/g/devel/message/113069 Mute This Topic: https://groups.io/mt/103499170/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-