* [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors
@ 2024-01-03 9:52 Abdul Lateef Attar via groups.io
2024-01-03 9:52 ` [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix " Abdul Lateef Attar via groups.io
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Abdul Lateef Attar via groups.io @ 2024-01-03 9:52 UTC (permalink / raw)
To: devel; +Cc: Abdul Lateef Attar
From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
PR: https://github.com/tianocore/edk2/pull/5209
v2: Fix the IA32 compilation errors.
v1: Fix the X64 compilation errors.
Cc: Pierre Gondois pierre.gondois@arm.com
Cc: Sami Mujawar sami.mujawar@arm.com
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Abdul Lateef Attar (2):
DynamicTablesPkg: Fix X64 compilation errors
DynamicTablesPkg: Fix IA32 compilation errors
DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++-----
DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++--
.../Library/Common/AmlLib/AmlLib.inf | 2 ++
.../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++--
.../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++---
.../ConfigurationManagerObjectParser.c | 2 +-
.../Library/Common/TableHelperLib/TableHelper.c | 6 ++++--
.../Common/TableHelperLib/TableHelperLib.inf | 2 ++
8 files changed, 32 insertions(+), 15 deletions(-)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113062): https://edk2.groups.io/g/devel/message/113062
Mute This Topic: https://groups.io/mt/103499168/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 9+ messages in thread* [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors 2024-01-03 9:52 [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors Abdul Lateef Attar via groups.io @ 2024-01-03 9:52 ` Abdul Lateef Attar via groups.io 2024-01-03 11:33 ` Sami Mujawar 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 " Abdul Lateef Attar via groups.io 2024-01-03 14:54 ` [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 " Sami Mujawar 2 siblings, 1 reply; 9+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-03 9:52 UTC (permalink / raw) To: devel; +Cc: Abdul Lateef Attar, Pierre Gondois, Sami Mujawar From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Add the support for X64 compilation to the CI. Fix the compilation errors. Cc: Pierre Gondois <pierre.gondois@arm.com> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> --- DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- .../Library/Common/AmlLib/AmlLib.inf | 2 ++ .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- .../Library/Common/TableHelperLib/TableHelper.c | 2 ++ .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ 7 files changed, 29 insertions(+), 12 deletions(-) diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc index 9d4312c4e8..804fb00a85 100644 --- a/DynamicTablesPkg/DynamicTables.dsc.inc +++ b/DynamicTablesPkg/DynamicTables.dsc.inc @@ -2,6 +2,7 @@ # Dsc include file for Dynamic Tables Framework. # # Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.<BR> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -21,6 +22,17 @@ SmbiosStringTableLib|DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTableLib.inf [Components.common] + # + # Dynamic Table Factory Dxe + # + DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf + + # + # Dynamic Tables Manager Dxe + # + DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf + +[Components.ARM, Components.AARCH64] # # Generators # @@ -70,8 +82,3 @@ NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf } - # - # Dynamic Tables Manager Dxe - # - DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf - diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc index bd5084a900..a2db14efaf 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -3,6 +3,7 @@ # # Copyright (c) 2019, Linaro Limited. All rights reserved.<BR> # Copyright (c) 2019 - 2022, Arm Limited. All rights reserved.<BR> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -14,7 +15,7 @@ PLATFORM_VERSION = 0.1 DSC_SPECIFICATION = 0x0001001a OUTPUT_DIRECTORY = Build/DynamicTables - SUPPORTED_ARCHITECTURES = ARM|AARCH64 + SUPPORTED_ARCHITECTURES = ARM|AARCH64|X64 BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT @@ -44,10 +45,12 @@ DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf - DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTableLib.inf +[Components.ARM, Components.AARCH64] + DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf + [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf index 723de3ad44..6d0aa6ff93 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf @@ -2,6 +2,7 @@ # AML Generation Library # # Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -68,6 +69,7 @@ [LibraryClasses] AcpiHelperLib BaseLib + MemoryAllocationLib [BuildOptions] *_*_*_CC_FLAGS = -DAML_HANDLE diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index 893ace20ae..d4e3e252cb 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,7 +2,7 @@ AML Code Generation. Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.<BR> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> + Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -922,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status = AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c index bc713f30b2..bdeb5c78ae 100644 --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c @@ -2,6 +2,7 @@ Dynamic Platform Info Repository Copyright (c) 2021, Arm Limited. All rights reserved.<BR> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -287,8 +288,8 @@ GroupCmObjNodes ( CmObjDesc = &This->ArmCmObjArray[ArmObjIndex]; CmObjDesc->ObjectId = CmObjId; - CmObjDesc->Size = Size; - CmObjDesc->Count = Count; + CmObjDesc->Size = (UINT32)Size; + CmObjDesc->Count = (UINT32)Count; CmObjDesc->Data = GroupedData; return Status; @@ -340,7 +341,7 @@ DynamicPlatRepoFinalise ( // (the array is wrapped in a CmObjDesc). // - Add the Token/CmObj binding to the token mapper. for (ArmObjIndex = 0; ArmObjIndex < EArmObjMax; ArmObjIndex++) { - Status = GroupCmObjNodes (This, ArmObjIndex); + Status = GroupCmObjNodes (This, (UINT32)ArmObjIndex); if (EFI_ERROR (Status)) { ASSERT (0); // Free the TokenMapper. diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index 0decd3dc0e..e33d6e656b 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -2,6 +2,7 @@ Table Helper Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -16,6 +17,7 @@ #include <ConfigurationManagerObject.h> #include <Library/TableHelperLib.h> #include <Protocol/ConfigurationManagerProtocol.h> +#include <Library/AmlLib/AmlLib.h> /** The GetCgfMgrInfo function gets the CM_STD_OBJ_CONFIGURATION_MANAGER_INFO object from the Configuration Manager. diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf index abbf4bc38c..8df5ab848e 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf @@ -2,6 +2,7 @@ # Table Helper # # Copyright (c) 2017 - 2021, ARM Limited. All rights reserved. +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -25,3 +26,4 @@ [LibraryClasses] BaseLib + AmlLib -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113063): https://edk2.groups.io/g/devel/message/113063 Mute This Topic: https://groups.io/mt/103499169/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix " Abdul Lateef Attar via groups.io @ 2024-01-03 11:33 ` Sami Mujawar 0 siblings, 0 replies; 9+ messages in thread From: Sami Mujawar @ 2024-01-03 11:33 UTC (permalink / raw) To: Abdul Lateef Attar, devel; +Cc: Abdul Lateef Attar, Pierre Gondois, nd@arm.com Hi Abdul, Thank you for this patch. I have some minor suggestions that I will fix before merging. Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Add the support for X64 compilation to the CI. > Fix the compilation errors. > > Cc: Pierre Gondois <pierre.gondois@arm.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > --- > DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- > DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- > .../Library/Common/AmlLib/AmlLib.inf | 2 ++ > .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- > .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- > .../Library/Common/TableHelperLib/TableHelper.c | 2 ++ > .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ > 7 files changed, 29 insertions(+), 12 deletions(-) > > diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/DynamicTables.dsc.inc > index 9d4312c4e8..804fb00a85 100644 > --- a/DynamicTablesPkg/DynamicTables.dsc.inc > +++ b/DynamicTablesPkg/DynamicTables.dsc.inc > @@ -2,6 +2,7 @@ > # Dsc include file for Dynamic Tables Framework. > # > # Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.<BR> > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +22,17 @@ > SmbiosStringTableLib|DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTableLib.inf > > [Components.common] <SNIP> > + # > + # Dynamic Table Factory Dxe > + # > + DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf </SNIP> [SAMI] I think this should go in a separate section i.e. [Components.X64]. Similarly the patch 2/2 needs to extend this to add Components.IA32. > + > + # > + # Dynamic Tables Manager Dxe > + # > + DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf > + > +[Components.ARM, Components.AARCH64] > # > # Generators > # > @@ -70,8 +82,3 @@ > NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf > } > > - # > - # Dynamic Tables Manager Dxe > - # > - DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf > - > diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc > index bd5084a900..a2db14efaf 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.dsc > +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc > @@ -3,6 +3,7 @@ > # > # Copyright (c) 2019, Linaro Limited. All rights reserved.<BR> > # Copyright (c) 2019 - 2022, Arm Limited. All rights reserved.<BR> > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -14,7 +15,7 @@ > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x0001001a > OUTPUT_DIRECTORY = Build/DynamicTables > - SUPPORTED_ARCHITECTURES = ARM|AARCH64 > + SUPPORTED_ARCHITECTURES = ARM|AARCH64|X64 > BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > > @@ -44,10 +45,12 @@ > DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf > DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > - DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf > DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTableLib.inf > > +[Components.ARM, Components.AARCH64] > + DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf > + > [BuildOptions] > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf > index 723de3ad44..6d0aa6ff93 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf > +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf > @@ -2,6 +2,7 @@ > # AML Generation Library > # > # Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR> > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -68,6 +69,7 @@ > [LibraryClasses] > AcpiHelperLib > BaseLib > + MemoryAllocationLib > > [BuildOptions] > *_*_*_CC_FLAGS = -DAML_HANDLE > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index 893ace20ae..d4e3e252cb 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -2,7 +2,7 @@ > AML Code Generation. > > Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.<BR> > - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> > + Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -922,7 +922,7 @@ AmlCodeGenNameUnicodeString ( > Status = AmlCreateDataNode ( > EAmlNodeDataTypeRaw, > (CONST UINT8 *)String, > - StrSize (String), > + (UINT32)StrSize (String), > &DataNode > ); > if (EFI_ERROR (Status)) { > diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c > index bc713f30b2..bdeb5c78ae 100644 > --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c > +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c > @@ -2,6 +2,7 @@ > Dynamic Platform Info Repository > > Copyright (c) 2021, Arm Limited. All rights reserved.<BR> > + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -287,8 +288,8 @@ GroupCmObjNodes ( > > CmObjDesc = &This->ArmCmObjArray[ArmObjIndex]; > CmObjDesc->ObjectId = CmObjId; > - CmObjDesc->Size = Size; > - CmObjDesc->Count = Count; > + CmObjDesc->Size = (UINT32)Size; > + CmObjDesc->Count = (UINT32)Count; > CmObjDesc->Data = GroupedData; > > return Status; > @@ -340,7 +341,7 @@ DynamicPlatRepoFinalise ( > // (the array is wrapped in a CmObjDesc). > // - Add the Token/CmObj binding to the token mapper. > for (ArmObjIndex = 0; ArmObjIndex < EArmObjMax; ArmObjIndex++) { > - Status = GroupCmObjNodes (This, ArmObjIndex); > + Status = GroupCmObjNodes (This, (UINT32)ArmObjIndex); > if (EFI_ERROR (Status)) { > ASSERT (0); > // Free the TokenMapper. > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > index 0decd3dc0e..e33d6e656b 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > @@ -2,6 +2,7 @@ > Table Helper > > Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR> > + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -16,6 +17,7 @@ > #include <ConfigurationManagerObject.h> > #include <Library/TableHelperLib.h> > #include <Protocol/ConfigurationManagerProtocol.h> > +#include <Library/AmlLib/AmlLib.h> [SAMI] I think the AmlLib.h include can be moved just above the TableHelperLib.h include, so that they are ordered alphabetically. > > /** The GetCgfMgrInfo function gets the CM_STD_OBJ_CONFIGURATION_MANAGER_INFO > object from the Configuration Manager. > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > index abbf4bc38c..8df5ab848e 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > @@ -2,6 +2,7 @@ > # Table Helper > # > # Copyright (c) 2017 - 2021, ARM Limited. All rights reserved. > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -25,3 +26,4 @@ > > [LibraryClasses] > BaseLib > + AmlLib [SAMI] I prefer to order this section in alphabetical order. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113068): https://edk2.groups.io/g/devel/message/113068 Mute This Topic: https://groups.io/mt/103499169/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors 2024-01-03 9:52 [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors Abdul Lateef Attar via groups.io 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix " Abdul Lateef Attar via groups.io @ 2024-01-03 9:52 ` Abdul Lateef Attar via groups.io 2024-01-03 11:33 ` Sami Mujawar 2024-01-03 14:54 ` [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 " Sami Mujawar 2 siblings, 1 reply; 9+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-03 9:52 UTC (permalink / raw) To: devel; +Cc: Abdul Lateef Attar, Pierre Gondois, Sami Mujawar From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Add the support for X64 compilation to the CI. - Fix the signed and unsigned variable comparision. warning C4018: '>': signed/unsigned mismatch - Fix the NOOPT build error for IA32 by replacing 64bit shift operator with LShiftU64. Cc: Pierre Gondois <pierre.gondois@arm.com> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 2 +- DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc index a2db14efaf..2f35ac82f2 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -15,7 +15,7 @@ PLATFORM_VERSION = 0.1 DSC_SPECIFICATION = 0x0001001a OUTPUT_DIRECTORY = Build/DynamicTables - SUPPORTED_ARCHITECTURES = ARM|AARCH64|X64 + SUPPORTED_ARCHITECTURES = ARM|AARCH64|IA32|X64 BUILD_TARGETS = DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER = DEFAULT diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c index ce494816ed..c1a7528419 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c @@ -1130,7 +1130,7 @@ ParseCmObjDesc ( &RemainingSize, 1 ); - if ((RemainingSize > CmObjDesc->Size) || + if ((RemainingSize > (INTN)CmObjDesc->Size) || (RemainingSize < 0)) { ASSERT (0); diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c index e33d6e656b..12c67b9811 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c @@ -170,7 +170,7 @@ AddAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32); + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); } // UINT32 OemRevision @@ -257,7 +257,7 @@ AddSsdtAcpiHeader ( CfgMfrInfo->OemId[2], CfgMfrInfo->OemId[3] ) | - ((UINT64)Generator->AcpiTableSignature << 32); + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); } if (AcpiTableInfo->OemRevision != 0) { -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113064): https://edk2.groups.io/g/devel/message/113064 Mute This Topic: https://groups.io/mt/103499170/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 compilation errors 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 " Abdul Lateef Attar via groups.io @ 2024-01-03 11:33 ` Sami Mujawar 0 siblings, 0 replies; 9+ messages in thread From: Sami Mujawar @ 2024-01-03 11:33 UTC (permalink / raw) To: Abdul Lateef Attar, devel; +Cc: Abdul Lateef Attar, Pierre Gondois, nd@arm.com Hi Abdul, Thank you for this patch. I have some minor suggestions that I will fix before merging. Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Add the support for X64 compilation to the CI. > - Fix the signed and unsigned variable comparision. > warning C4018: '>': signed/unsigned mismatch > - Fix the NOOPT build error for IA32 by replacing > 64bit shift operator with LShiftU64. > > Cc: Pierre Gondois <pierre.gondois@arm.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > --- > DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- > .../Common/TableHelperLib/ConfigurationManagerObjectParser.c | 2 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc > index a2db14efaf..2f35ac82f2 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.dsc > +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc > @@ -15,7 +15,7 @@ > PLATFORM_VERSION = 0.1 > DSC_SPECIFICATION = 0x0001001a > OUTPUT_DIRECTORY = Build/DynamicTables > - SUPPORTED_ARCHITECTURES = ARM|AARCH64|X64 > + SUPPORTED_ARCHITECTURES = ARM|AARCH64|IA32|X64 > BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index ce494816ed..c1a7528419 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -1130,7 +1130,7 @@ ParseCmObjDesc ( > &RemainingSize, > 1 > ); > - if ((RemainingSize > CmObjDesc->Size) || > + if ((RemainingSize > (INTN)CmObjDesc->Size) || > (RemainingSize < 0)) > { > ASSERT (0); > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > index e33d6e656b..12c67b9811 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > @@ -170,7 +170,7 @@ AddAcpiHeader ( > CfgMfrInfo->OemId[2], > CfgMfrInfo->OemId[3] > ) | > - ((UINT64)Generator->AcpiTableSignature << 32); > + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); [SAMI] Minor alignment required to keep the line width within 80 characters. > } > > // UINT32 OemRevision > @@ -257,7 +257,7 @@ AddSsdtAcpiHeader ( > CfgMfrInfo->OemId[2], > CfgMfrInfo->OemId[3] > ) | > - ((UINT64)Generator->AcpiTableSignature << 32); > + LShiftU64 ((UINT64)Generator->AcpiTableSignature, 32); > } > > if (AcpiTableInfo->OemRevision != 0) { -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113069): https://edk2.groups.io/g/devel/message/113069 Mute This Topic: https://groups.io/mt/103499170/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors 2024-01-03 9:52 [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors Abdul Lateef Attar via groups.io 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix " Abdul Lateef Attar via groups.io 2024-01-03 9:52 ` [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 " Abdul Lateef Attar via groups.io @ 2024-01-03 14:54 ` Sami Mujawar 2024-01-04 2:11 ` Abdul Lateef Attar via groups.io [not found] ` <17A702FE941215EA.10454@groups.io> 2 siblings, 2 replies; 9+ messages in thread From: Sami Mujawar @ 2024-01-03 14:54 UTC (permalink / raw) To: devel, AbdulLateef.Attar, nd@arm.com, Pierre Gondois Hi Abdul, I have merged this series as d7d4f09ff815..2576cbafec98. Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it would be good to enable that in the edk2 CI. That way we do not accidently break the builds. To enable edk2 CI for AARCH64 using GCC, I had made the change at https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50 I am not sure what is required to support X64 and IA32 builds using VS2019. Can you provide a patch for that, please? Also, by any chance have you tried building DynamicTablesPkg with GCC for X64 and IA32? Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > PR: https://github.com/tianocore/edk2/pull/5209 > v2: Fix the IA32 compilation errors. > v1: Fix the X64 compilation errors. > > Cc: Pierre Gondois pierre.gondois@arm.com > Cc: Sami Mujawar sami.mujawar@arm.com > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Abdul Lateef Attar (2): > DynamicTablesPkg: Fix X64 compilation errors > DynamicTablesPkg: Fix IA32 compilation errors > > DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- > DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- > .../Library/Common/AmlLib/AmlLib.inf | 2 ++ > .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- > .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- > .../ConfigurationManagerObjectParser.c | 2 +- > .../Library/Common/TableHelperLib/TableHelper.c | 6 ++++-- > .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ > 8 files changed, 32 insertions(+), 15 deletions(-) > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113098): https://edk2.groups.io/g/devel/message/113098 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors 2024-01-03 14:54 ` [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 " Sami Mujawar @ 2024-01-04 2:11 ` Abdul Lateef Attar via groups.io [not found] ` <17A702FE941215EA.10454@groups.io> 1 sibling, 0 replies; 9+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-04 2:11 UTC (permalink / raw) To: Sami Mujawar, devel, nd@arm.com, Pierre Gondois Hi Sami Mujawar, Thanks for quick response, update and merge of the patch. Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain VS2019) and also using GCC 11.4 (tool-chain GCC). I'll take a look at edk2 CI. Thanks AbduL I'll take a look at edk2 CI and On 03-01-2024 20:24, Sami Mujawar wrote: > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Abdul, > > I have merged this series as d7d4f09ff815..2576cbafec98. > > Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it > would be good to enable that in the edk2 CI. That way we do not > accidently break the builds. > > To enable edk2 CI for AARCH64 using GCC, I had made the change at > https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50 > > > I am not sure what is required to support X64 and IA32 builds using > VS2019. Can you provide a patch for that, please? > > Also, by any chance have you tried building DynamicTablesPkg with GCC > for X64 and IA32? > > Regards, > > Sami Mujawar > > On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: >> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >> >> PR: https://github.com/tianocore/edk2/pull/5209 >> v2: Fix the IA32 compilation errors. >> v1: Fix the X64 compilation errors. >> >> Cc: Pierre Gondois pierre.gondois@arm.com >> Cc: Sami Mujawar sami.mujawar@arm.com >> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >> >> Abdul Lateef Attar (2): >> DynamicTablesPkg: Fix X64 compilation errors >> DynamicTablesPkg: Fix IA32 compilation errors >> >> DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- >> DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- >> .../Library/Common/AmlLib/AmlLib.inf | 2 ++ >> .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- >> .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- >> .../ConfigurationManagerObjectParser.c | 2 +- >> .../Library/Common/TableHelperLib/TableHelper.c | 6 ++++-- >> .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ >> 8 files changed, 32 insertions(+), 15 deletions(-) >> > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose > the contents to any other person, use it for any purpose, or store or > copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113111): https://edk2.groups.io/g/devel/message/113111 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <17A702FE941215EA.10454@groups.io>]
* Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors [not found] ` <17A702FE941215EA.10454@groups.io> @ 2024-01-04 4:04 ` Abdul Lateef Attar via groups.io 2024-01-04 10:21 ` Sami Mujawar 0 siblings, 1 reply; 9+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-04 4:04 UTC (permalink / raw) To: devel, Sami Mujawar, nd@arm.com, Pierre Gondois Hi Sami Mujawar, Looks like current edk2 CI handles the X64, IA32 for both GCC and VS2019 to build DynamicTablesPkg. I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below PR(which is expected). https://github.com/tianocore/edk2/pull/5215 Thanks AbduL On 04-01-2024 07:41, Abdul Lateef Attar via groups.io wrote: > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Sami Mujawar, > > Thanks for quick response, update and merge of the patch. > > Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain > VS2019) and also using GCC 11.4 (tool-chain GCC). > > I'll take a look at edk2 CI. > > Thanks > > AbduL > > > I'll take a look at edk2 CI and > > On 03-01-2024 20:24, Sami Mujawar wrote: >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abdul, >> >> I have merged this series as d7d4f09ff815..2576cbafec98. >> >> Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it >> would be good to enable that in the edk2 CI. That way we do not >> accidently break the builds. >> >> To enable edk2 CI for AARCH64 using GCC, I had made the change at >> https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50 >> >> >> >> I am not sure what is required to support X64 and IA32 builds using >> VS2019. Can you provide a patch for that, please? >> >> Also, by any chance have you tried building DynamicTablesPkg with GCC >> for X64 and IA32? >> >> Regards, >> >> Sami Mujawar >> >> On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: >>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>> >>> PR: https://github.com/tianocore/edk2/pull/5209 >>> v2: Fix the IA32 compilation errors. >>> v1: Fix the X64 compilation errors. >>> >>> Cc: Pierre Gondois pierre.gondois@arm.com >>> Cc: Sami Mujawar sami.mujawar@arm.com >>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>> >>> Abdul Lateef Attar (2): >>> DynamicTablesPkg: Fix X64 compilation errors >>> DynamicTablesPkg: Fix IA32 compilation errors >>> >>> DynamicTablesPkg/DynamicTables.dsc.inc | 17 >>> ++++++++++++----- >>> DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- >>> .../Library/Common/AmlLib/AmlLib.inf | 2 ++ >>> .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- >>> .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- >>> .../ConfigurationManagerObjectParser.c | 2 +- >>> .../Library/Common/TableHelperLib/TableHelper.c | 6 ++++-- >>> .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ >>> 8 files changed, 32 insertions(+), 15 deletions(-) >>> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose >> the contents to any other person, use it for any purpose, or store or >> copy the information in any medium. Thank you. > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113130): https://edk2.groups.io/g/devel/message/113130 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors 2024-01-04 4:04 ` Abdul Lateef Attar via groups.io @ 2024-01-04 10:21 ` Sami Mujawar 0 siblings, 0 replies; 9+ messages in thread From: Sami Mujawar @ 2024-01-04 10:21 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io, nd, Pierre Gondois Hi Abdul, Thanks for confirming. I think the matrix at https://github.com/tianocore/edk2/tree/master/.pytool needs updating. Can you send a patch to update that, please? Regards, Sami Mujawar On 04/01/2024, 04:05, "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com <mailto:AbdulLateef.Attar@amd.com>> wrote: Hi Sami Mujawar, Looks like current edk2 CI handles the X64, IA32 for both GCC and VS2019 to build DynamicTablesPkg. I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below PR(which is expected). https://github.com/tianocore/edk2/pull/5215 <https://github.com/tianocore/edk2/pull/5215> Thanks AbduL On 04-01-2024 07:41, Abdul Lateef Attar via groups.io wrote: > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Sami Mujawar, > > Thanks for quick response, update and merge of the patch. > > Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain > VS2019) and also using GCC 11.4 (tool-chain GCC). > > I'll take a look at edk2 CI. > > Thanks > > AbduL > > > I'll take a look at edk2 CI and > > On 03-01-2024 20:24, Sami Mujawar wrote: >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abdul, >> >> I have merged this series as d7d4f09ff815..2576cbafec98. >> >> Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it >> would be good to enable that in the edk2 CI. That way we do not >> accidently break the builds. >> >> To enable edk2 CI for AARCH64 using GCC, I had made the change at >> https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50 <https://github.com/tianocore/edk2/blob/master/.azurepipelines/templates/pr-gate-build-job.yml#L50> >> >> >> >> I am not sure what is required to support X64 and IA32 builds using >> VS2019. Can you provide a patch for that, please? >> >> Also, by any chance have you tried building DynamicTablesPkg with GCC >> for X64 and IA32? >> >> Regards, >> >> Sami Mujawar >> >> On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote: >>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com <mailto:AbdulLateef.Attar@amd.com>> >>> >>> PR: https://github.com/tianocore/edk2/pull/5209 <https://github.com/tianocore/edk2/pull/5209> >>> v2: Fix the IA32 compilation errors. >>> v1: Fix the X64 compilation errors. >>> >>> Cc: Pierre Gondois pierre.gondois@arm.com <mailto:pierre.gondois@arm.com> >>> Cc: Sami Mujawar sami.mujawar@arm.com <mailto:sami.mujawar@arm.com> >>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com <mailto:AbdulLateef.Attar@amd.com>> >>> >>> Abdul Lateef Attar (2): >>> DynamicTablesPkg: Fix X64 compilation errors >>> DynamicTablesPkg: Fix IA32 compilation errors >>> >>> DynamicTablesPkg/DynamicTables.dsc.inc | 17 >>> ++++++++++++----- >>> DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- >>> .../Library/Common/AmlLib/AmlLib.inf | 2 ++ >>> .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- >>> .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- >>> .../ConfigurationManagerObjectParser.c | 2 +- >>> .../Library/Common/TableHelperLib/TableHelper.c | 6 ++++-- >>> .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ >>> 8 files changed, 32 insertions(+), 15 deletions(-) >>> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose >> the contents to any other person, use it for any purpose, or store or >> copy the information in any medium. Thank you. > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113160): https://edk2.groups.io/g/devel/message/113160 Mute This Topic: https://groups.io/mt/103499168/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-01-04 10:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 9:52 [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors Abdul Lateef Attar via groups.io
2024-01-03 9:52 ` [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix " Abdul Lateef Attar via groups.io
2024-01-03 11:33 ` Sami Mujawar
2024-01-03 9:52 ` [edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Fix IA32 " Abdul Lateef Attar via groups.io
2024-01-03 11:33 ` Sami Mujawar
2024-01-03 14:54 ` [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 " Sami Mujawar
2024-01-04 2:11 ` Abdul Lateef Attar via groups.io
[not found] ` <17A702FE941215EA.10454@groups.io>
2024-01-04 4:04 ` Abdul Lateef Attar via groups.io
2024-01-04 10:21 ` Sami Mujawar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox