public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Moritz Fischer <moritzf@google.com>, devel@edk2.groups.io
Cc: "nd@arm.com" <nd@arm.com>,
	Pierre Gondois <pierre.gondois@arm.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string
Date: Mon, 9 Jan 2023 17:02:35 +0000	[thread overview]
Message-ID: <85905d2b-226c-c13c-3183-9cff96ba48e7@arm.com> (raw)
In-Reply-To: <20230109164218.3298310-1-moritzf@google.com>

Hi Morit,

Thank you for this patch.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 09/01/2023 04:42 pm, Moritz Fischer wrote:
> Linux's cpu DT bindings call out arm,armv8 while the code previously
> used arm,arm-v8, add second entry to support the arm,arm-v8 case.
>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser")
> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> index 2c72bd0c58..ee82f7a0b4 100644
> --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c
> @@ -23,6 +23,7 @@
>   STATIC CONST COMPATIBILITY_STR  CpuCompatibleStr[] = {
>     { "arm,arm-v7"     },
>     { "arm,arm-v8"     },
> +  { "arm,armv8"      },
>     { "arm,cortex-a15" },
>     { "arm,cortex-a7"  },
>     { "arm,cortex-a57" }

  reply	other threads:[~2023-01-09 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 16:42 [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string Moritz Fischer
2023-01-09 17:02 ` Sami Mujawar [this message]
2023-01-10 15:52 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85905d2b-226c-c13c-3183-9cff96ba48e7@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox