From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.77]) by mx.groups.io with SMTP id smtpd.web11.78205.1673283774652893614 for ; Mon, 09 Jan 2023 09:02:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Zlw+qD1m; spf=pass (domain: arm.com, ip: 40.107.20.77, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wf8ks8NoMGUPIxYxmMihVdbkuauFLUGvAlLSvdeW3oo=; b=Zlw+qD1mR0/632asgU1w2Nd2y+Ff++qo83thwOefM+di4evEDFedjADwko99SbFsgf07c4a/OKcyz410u6a31uNqob8g4HPiSuFydmKfXiLByu9lZf/zZCBHF5z+Ey5bJnVyEP7xtZVZdII4whyVwJebHhHaHGMpzua8oDsAeD0= Received: from DB9PR01CA0007.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::12) by AS4PR08MB7503.eurprd08.prod.outlook.com (2603:10a6:20b:4e7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 17:02:51 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::ac) by DB9PR01CA0007.outlook.office365.com (2603:10a6:10:1d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 17:02:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 17:02:51 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Mon, 09 Jan 2023 17:02:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a0a349288b18efb4 X-CR-MTA-TID: 64aa7808 Received: from c84f1dd056bf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D812FBFC-98BC-41E7-90BA-6C270657AFE0.1; Mon, 09 Jan 2023 17:02:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c84f1dd056bf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 17:02:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQXQtwSUFWuDCVXjtmir3F4xP9G1IWJ0E/5R6SCS14dmkwQWQkki8J1tfGrEGxbz2El2of/vPYyyMD18gO/EPkYl5fYHdmprmyqMMxa2+Fl6PwttDp9IQyhIdZXB7jXf20D6no/c1R2+Ybe0QQzL7nPDYBAidtxvQn5nYuHuKGUXYZd5pF1sS5mB+cAVyQL9aJL2U4Vcd+RwzUMdQdYax2rWac/3Rd9CUpF23hko4zCtCejyBM1RfvYpQwPkHGzMhkaw7cMPq1nbb4HqkR8Xd+QpZRKcGjIYkLmnwu0uUzuWoTEjqfJgWH3InryYqJ3xgf8+SGw1/y8U8KEIGwTJww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wf8ks8NoMGUPIxYxmMihVdbkuauFLUGvAlLSvdeW3oo=; b=WE+e1+fCWeMR950Ak90HpjEYNepaY8IL7EU5COsK/0WhWR1iqbQCAIWaAQgT/wJc7wiYxtdJdFM8k9gy56phqJUKDR4DVVcsjHqLVUozRlzI0OmuDn0Efn7HDrHyfoiBVbDI8dhiEy1D1HUPm9co1tWLu17zX60vvFmiSsd+lX86vz4tdygFbgIoQqBlkV4BJTZ31WijCAThCLl4eOT9DxKiK8IK1E5u+MJfbP3qZiiQ/MauAcekI96PVzCdYMFFiubiKD4rkEMo9YY8tSo2mZv/nzIz3NeIU5GZ0VDgCd1LyCw5aWPRTRQi1J/OmJNWD3oorgtU8rbA3mMJeYm6eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wf8ks8NoMGUPIxYxmMihVdbkuauFLUGvAlLSvdeW3oo=; b=Zlw+qD1mR0/632asgU1w2Nd2y+Ff++qo83thwOefM+di4evEDFedjADwko99SbFsgf07c4a/OKcyz410u6a31uNqob8g4HPiSuFydmKfXiLByu9lZf/zZCBHF5z+Ey5bJnVyEP7xtZVZdII4whyVwJebHhHaHGMpzua8oDsAeD0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB9PR08MB9489.eurprd08.prod.outlook.com (2603:10a6:10:458::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 17:02:37 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::5899:7a52:822b:56e0%9]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 17:02:37 +0000 Message-ID: <85905d2b-226c-c13c-3183-9cff96ba48e7@arm.com> Date: Mon, 9 Jan 2023 17:02:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string To: Moritz Fischer , devel@edk2.groups.io References: <20230109164218.3298310-1-moritzf@google.com> Cc: "nd@arm.com" , Pierre Gondois , Ard Biesheuvel From: "Sami Mujawar" In-Reply-To: <20230109164218.3298310-1-moritzf@google.com> X-ClientProxiedBy: LO4P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::22) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB9PR08MB9489:EE_|DBAEUR03FT033:EE_|AS4PR08MB7503:EE_ X-MS-Office365-Filtering-Correlation-Id: e24a4d1b-e8a2-4f29-a7f2-08daf26357c5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OhVtctwjUjYEutEAslUtZrEdXKeCsOy+36gD9Cswq3g4eosD10a9lhqGpWGqU6XS2r7W53PIWMdf1pc143Aec4raCR/R3yUGnO1WNCwJcQiyvGBDf8jnoFK5CVaG+fchN5GXRByYfWjZ5yRroq9CQUL73PrnZmCuPNbbgNYf1WR3E010nWWeUgmhYr3GOgszZCP71D5cCM9pg6Mza0NvvFxHxSOVDAGPDq8y1+Ym6gHT1+wzb1sJIMWybNp4KAuUyX5Mpv4xORYEO2G0H/m7AYa8vID/sxlT9ZWRCIj3paf04FCVpSATqt9ByKiUnDOrEjkl8Dpbh+Zk4+AnsC+hFTzkuZrAQqtQCkHvm6RrFyln/eN+qn+nZ4AUpPm310da2/B3k2MoGQ7o4i7WRfJSVMNAYmJvtX5vfh7S98LgZ2WpcMS5JCdgGMBOTCa7QpzpY+jkIwY1cbYttnkXFPEEQRB3L6bnG9p3xPA7cC0qm3YcSibmMDAmS9URewiXnWWGOtPqqWh8T93Njm1cyVrGtIYGaNsIWU9oBbvFOhJDoepKXjJiMat+fgtKPGF0Nz45UA+RHv6beB/besrgAXKuOv/6AqUtdd+CUncdPe8BZzKpZDhOf1u/0Dr3bnKtmKzAH6SpKGAv8WQWuxCoAYy4IVbk5H0nLuLcrssh+bDbFSyhgLVnH/Q1MR9qWYqcx0AMeCejZ+9vX8bfqJSRYGDZSF6OCnsgMHG232WscBf4494= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(451199015)(31686004)(2906002)(36756003)(2616005)(44832011)(5660300002)(8936002)(41300700001)(86362001)(66476007)(31696002)(4326008)(66556008)(26005)(66946007)(6512007)(186003)(8676002)(6506007)(53546011)(478600001)(54906003)(38100700002)(6486002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9489 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 34ffc37f-00a7-4f6e-c2c6-08daf2634ef9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8UYKvz8mmauySaA0ZJFRHNOiAQDAHBRUWkN4UHDwAx5+8AkTZew01IJ7xBqt4j3MJVj1Y/kTmLut7fDoy1XYkRfe1W1PChL2hhMi6mF3SzIP9kj3hrjMaMj6TQEP+C7xXwipqe/Zx7OATNVrDUYCgEgBkfHop8RGVBr8bMYSq+ExZLRv3YXQ7cj+s/n51Ey+GCQcntd61OqADUR7oNVYK+ShXpKetlEO8wuQO2och3hY6D1iJ/eVLw+xAEd+02lH3+GS2ZDXqoUzKzghR3J6n2QdYJY9UHYUVRPhr20Zbr5lkdhhZ3Ha2KuQHJ3xV5NOAavGLBNPsWYBeXvBhj7SNuyhKoMTFiAeiVvYTDUrm2e1L+XYENajAibvFDxs/ysvNc0rsuIOkZByGuroA9SsBE4cSZ2Cbb5XIDYxa5xUavjdeT43R1tmS3RVVk8Y4c+ivhkzqHmDRybGDtEKk+NJ6GrwwtVSWyWK0mfWz5bBRR0AWhIq+LAmFqY63UKs7xBtAN/6dg6XZQMBn02Bq1iVU3pq+9rkjM7YG5ZcRuVSl5lijt8/s47LX/IXDA8Q6OwtNSxFEDrwopzdyd23UwQNO99XJdz6D07rpjCw9QRG1JhHc8k7R1j7D4d0pzDP6KYyhcuRGIuEdSlk7FIohmtiwY+8LLtR0ARY1oMbc2cTR7UGR02gKL5Tt+a401sAWV2AVJ3C5nrYgC2LzZObzFjWoSf3xIzVReSO3iVwUf1Fgiw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(36840700001)(46966006)(40470700004)(36756003)(31696002)(40480700001)(40460700003)(86362001)(6506007)(6486002)(54906003)(316002)(5660300002)(478600001)(2906002)(44832011)(4326008)(70586007)(8676002)(70206006)(41300700001)(8936002)(36860700001)(107886003)(82740400003)(356005)(81166007)(2616005)(336012)(26005)(6512007)(186003)(53546011)(82310400005)(47076005)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 17:02:51.4601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e24a4d1b-e8a2-4f29-a7f2-08daf26357c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7503 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Morit, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/01/2023 04:42 pm, Moritz Fischer wrote: > Linux's cpu DT bindings call out arm,armv8 while the code previously > used arm,arm-v8, add second entry to support the arm,arm-v8 case. > > Cc: Sami Mujawar > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") > Signed-off-by: Moritz Fischer > --- > DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > index 2c72bd0c58..ee82f7a0b4 100644 > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > @@ -23,6 +23,7 @@ > STATIC CONST COMPATIBILITY_STR CpuCompatibleStr[] = { > { "arm,arm-v7" }, > { "arm,arm-v8" }, > + { "arm,armv8" }, > { "arm,cortex-a15" }, > { "arm,cortex-a7" }, > { "arm,cortex-a57" }