From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 94B61AC18E7 for ; Sun, 5 Nov 2023 15:19:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aR5mnGThYbm5ZlYnkNzrhJo5a9RREin4evVp+huwruU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699197560; v=1; b=rNzHh9UWNlOC3cN+MiAqSyh8JTZ0QPOCFad2lcgWZ1SH6n9AIlfD3QKpS8bnj/+4cB1lElaE u2CZFY3Hk7gTcmmNlOQ7KS+msfu7ePTwSNXawMygQGNOXtzq090FpI/hCAtjxHukMgUVPoKU53n UznkmqwxRC3rggwXHTMaccG0= X-Received: by 127.0.0.2 with SMTP id xRfgYY7687511xrG0i8U4hjr; Sun, 05 Nov 2023 07:19:20 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.31884.1699197559833388715 for ; Sun, 05 Nov 2023 07:19:19 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="369361949" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="369361949" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 07:19:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="738573010" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="738573010" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by orsmga006.jf.intel.com with ESMTP; 05 Nov 2023 07:19:17 -0800 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Abner Chang , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Date: Sun, 5 Nov 2023 23:18:54 +0800 Message-Id: <8594af88f257a5274215a8a31734c1097c4a8570.1699196971.git.wei6.xu@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uCQUX60NA7489NL0GiTFgo6Vx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rNzHh9UW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace Smst with Mmst. Remove unused UefiBootServicesTableLib reference. Cc: Abner Chang Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Wei6 Xu --- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 39 +++++-------------- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 7 ++-- 2 files changed, 12 insertions(+), 34 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c index 6282adc269f8..d05798d94866 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c @@ -2,15 +2,14 @@ A Library to support all BMC access via IPMI command during SMM Phase. @copyright - Copyright 1999 - 2021 Intel Corporation.
+ Copyright 1999 - 2023 Intel Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#include +#include #include #include -#include -#include +#include #include STATIC IPMI_TRANSPORT *mIpmiTransport = NULL; @@ -37,7 +36,7 @@ NotifyIpmiTransportCallback ( EFI_STATUS Status; Status = EFI_SUCCESS; if (mIpmiTransport == NULL) { - Status = gSmst->SmmLocateProtocol ( + Status = gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport @@ -60,15 +59,15 @@ InitializeIpmiBase ( { EFI_STATUS Status; if (mIpmiTransport == NULL) { - Status = gSmst->SmmLocateProtocol ( + Status = gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport ); if (EFI_ERROR (Status)) { - Status = gSmst->SmmRegisterProtocolNotify ( + Status = gMmst->MmRegisterProtocolNotify ( &gSmmIpmiTransportProtocolGuid, - (EFI_SMM_NOTIFY_FN) NotifyIpmiTransportCallback, + (EFI_MM_NOTIFY_FN) NotifyIpmiTransportCallback, &mEfiIpmiProtocolNotifyReg ); } @@ -104,30 +103,10 @@ IpmiSubmitCommand ( OUT UINT8 *ResponseData, IN OUT UINT32 *ResponseDataSize ) -/*++ - -Routine Description: - - Routine to send commands to BMC - -Arguments: - - NetFunction - Net function of the command - Command - IPMI Command - CommandData - Command Data - CommandDataSize - Size of CommandData - ResponseData - Response Data - ResponseDataSize - Response Data Size - -Returns: - - EFI_NOT_AVAILABLE_YET - IpmiTransport Protocol is not installed yet - ---*/ { EFI_STATUS Status; - Status = gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport); + Status = gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; @@ -164,7 +143,7 @@ GetBmcStatus ( { EFI_STATUS Status; - Status = gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport); + Status = gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf index 7ea688fc165f..df43c81e6493 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf @@ -1,7 +1,7 @@ ## @file # # @copyright -# Copyright 2010 - 2021 Intel Corporation.
+# Copyright 2010 - 2023 Intel Corporation.
# SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -11,7 +11,7 @@ FILE_GUID = 2B5AD78E-5CF8-45d2-B2AC-749A09425911 MODULE_TYPE = DXE_SMM_DRIVER VERSION_STRING = 1.0 - LIBRARY_CLASS = IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE + LIBRARY_CLASS = IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE MM_STANDALONE MM_CORE_STANDALONE [sources] SmmIpmiBaseLib.c @@ -21,9 +21,8 @@ IpmiFeaturePkg/IpmiFeaturePkg.dec [LibraryClasses] - UefiBootServicesTableLib DebugLib - SmmServicesTableLib + MmServicesTableLib [Protocols] gSmmIpmiTransportProtocolGuid -- 2.29.2.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110683): https://edk2.groups.io/g/devel/message/110683 Mute This Topic: https://groups.io/mt/102402215/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-