From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by mx.groups.io with SMTP id smtpd.web08.4389.1604007700394631911 for ; Thu, 29 Oct 2020 14:41:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=P2Z6zPM5; spf=pass (domain: nuviainc.com, ip: 209.85.210.196, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f196.google.com with SMTP id c20so3474380pfr.8 for ; Thu, 29 Oct 2020 14:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5g2o5n71sk0TZdrUcjE7eUh/UyXD0pjmhnzuQlFTLrs=; b=P2Z6zPM5YjvEzwEQU0vpPINM59h1CjwrxTbWYSM88pE4jeYx3DNOyKp6ZhUP7OqR1N AeHRrWxnJOgfoqhVj8Ji5YrEUD9VPBjnk/vkjl8NjSLwc9nSjNGQpBDUb60rBdFjSMS9 71dYNoyRDPyCv2tQCFqc11TzsgfvzVaAezdASjNVKve1iD5A7rF/NmuqCEsrfNlLelW6 h31A/001KH07/EvvrPhWxEJ9x7THsAgL+sXEeXWeN10WgVTp5f3x9Vcb7Q7K5wZ87xKA pp1PB9jzhJXz2ccD3RooflA4zlnsSo5oTxum51aBA5NBG/fvWiU2lKWJcGYfeqxhFGof V/lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5g2o5n71sk0TZdrUcjE7eUh/UyXD0pjmhnzuQlFTLrs=; b=E7N026lC7nBrWSfCFKQ8Op04C5uhyUJHfOqxa0ADQmNkBXBS7oJfobDlYVoShHnu+M MZs6M7ethRHJfMj4sWMgQdRIqyNEWtPjoFctfLZqgkesN1JMaHTnszhNGpZ5ZHyz/RaL LDdebNjpDiAkpgN/6W/4+jYCmFx6Ik6BIjJmCb+Yay4HQgqE/3oMIPb5KkOyBYxFDKS2 RkhIfC2kN24H6E4nT1O+T+VsFMezBhpTNIgeNJsnFRVizG6OnD7jwFfZDTinRoc+FAN8 p6cH9UTZtzkoCDXwOaaC25J4hzbqp/knoXWrK9ffrLjVEQpeD3xYOAt14Ax2HRh8s6Xp MaGw== X-Gm-Message-State: AOAM532wz2sVDao51gJ3GNI6wy8R3MvRmnj6OubYxYqOTUUptNaIzied rTm9Ke87YipgdtPuBB5tc2XkGw== X-Google-Smtp-Source: ABdhPJzg7683TktZgJ90u4Bg8fk/jP2W6gBq0W22zRiLEgjK+dx0Wt5Oigpm6fC8ntosFWteZOEs2g== X-Received: by 2002:a63:4247:: with SMTP id p68mr1352346pga.338.1604007699835; Thu, 29 Oct 2020 14:41:39 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (muon.bluestop.org. [65.103.231.193]) by smtp.gmail.com with ESMTPSA id b7sm4060431pfr.171.2020.10.29.14.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 14:41:39 -0700 (PDT) Subject: Re: [EXTERNAL] [edk2-devel] [Redfish Discover Header File PATCH] RedfishPkg/Include: EFI Redfish Discover Protocol header file To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao , Nickle Wang References: <20201013043343.21356-1-abner.chang@hpe.com> From: "Rebecca Cran" Message-ID: <85cf61cb-fb5b-32fe-3da8-d87c60762bcc@nuviainc.com> Date: Thu, 29 Oct 2020 15:41:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201013043343.21356-1-abner.chang@hpe.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US I think the header include guard should have a leading underscore - e.g. _EFI_REDFISH_DISCOVER_PROTOCOL_H_. And it's nice if there's a comment on the #endif to say what it's for. -- Rebecca Cran On 10/12/20 10:33 PM, Abner Chang wrote: > diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h b/RedfishPkg/Include/Protocol/RedfishDiscover.h > new file mode 100644 > index 0000000000..574d7a16a6 > --- /dev/null > +++ b/RedfishPkg/Include/Protocol/RedfishDiscover.h > @@ -0,0 +1,198 @@ > +/** @file > + This file defines the EFI Redfish Discover Protocol interface. > + > + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef EFI_REDFISH_DISCOVER_PROTOCOL_H_ > +#define EFI_REDFISH_DISCOVER_PROTOCOL_H_ > + >