public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message
Date: Thu, 17 Jan 2019 12:07:43 +0100	[thread overview]
Message-ID: <85d2d5e7-63af-1f80-19d0-151a40da5d19@redhat.com> (raw)
In-Reply-To: <CAKv+Gu84J6Em3cqYmZV2DDUhGhePOKZKXAKcT9UmiD-WRCSNcA@mail.gmail.com>

On 01/16/19 21:36, Ard Biesheuvel wrote:
> On Tue, 15 Jan 2019 at 09:23, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> When running with a graphical console, no message whatsoever is printed
>> when the systems hits an unexpected exception and hangs, because even
>> the minimal 'exception occurred' message is only sent to the serial port.
>>
>> So let's fix that, by updating DefaultExceptionHandlerLib to take the
>> availability of a console into account. (#5)
>>
>> This requires some preparatory decruftication so that we can safely refer
>> to the system table and console (#1 .. #4).
>>
>> Changes since v1:
>> - split off ArmVirtPkg patch (#3)
>> - always send minimal error message to the serial port before attempting to
>>   send it to console->stdout as well (which is more likely to fail) (#5)
>> - add Leif's R-b to the series
>>
>> Ard Biesheuvel (5):
>>   ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling
>>   ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context
>>   ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase
>>   ArmPkg/DefaultExceptionHandlerLib: drop BASE variant
>>   ArmPkg/DefaultExceptionHandlerLib: use console if available
>>
> 
> Series pushed as
> 
> 47d977733137 ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling
> 74a12eae9f2c ArmPkg/DefaultExceptionHandlerLib: declare the permitted
> usage context
> ef9f0bff477f ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase
> 1e32c49718c6 ArmPkg/DefaultExceptionHandlerLib: drop BASE variant
> 31f5388006fc ArmPkg/DefaultExceptionHandlerLib: use console if available
> 
> after applying the changes suggested by Laszlo. I failed to include
> Laszlo's R-b in 3/5, apologies for that.
> 

That's not a problem,
Laszlo


      reply	other threads:[~2019-01-17 11:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  8:23 [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message Ard Biesheuvel
2019-01-15  8:23 ` [PATCH v2 1/5] ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling Ard Biesheuvel
2019-01-15  8:23 ` [PATCH v2 2/5] ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context Ard Biesheuvel
2019-01-15  8:23 ` [PATCH v2 3/5] ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase Ard Biesheuvel
2019-01-15 10:12   ` Laszlo Ersek
2019-01-15  8:23 ` [PATCH v2 4/5] ArmPkg/DefaultExceptionHandlerLib: drop BASE variant Ard Biesheuvel
2019-01-15  8:23 ` [PATCH v2 5/5] ArmPkg/DefaultExceptionHandlerLib: use console if available Ard Biesheuvel
2019-01-15 10:09   ` Laszlo Ersek
2019-01-15 11:14     ` Ard Biesheuvel
2019-01-16 20:36 ` [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message Ard Biesheuvel
2019-01-17 11:07   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85d2d5e7-63af-1f80-19d0-151a40da5d19@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox