From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A40A21962301 for ; Thu, 17 Jan 2019 03:07:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF2B3552FC; Thu, 17 Jan 2019 11:07:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-32.rdu2.redhat.com [10.10.120.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id C75C65D6AA; Thu, 17 Jan 2019 11:07:44 +0000 (UTC) To: Ard Biesheuvel , "edk2-devel@lists.01.org" References: <20190115082345.3711-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <85d2d5e7-63af-1f80-19d0-151a40da5d19@redhat.com> Date: Thu, 17 Jan 2019 12:07:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 17 Jan 2019 11:07:45 +0000 (UTC) Subject: Re: [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:07:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/16/19 21:36, Ard Biesheuvel wrote: > On Tue, 15 Jan 2019 at 09:23, Ard Biesheuvel wrote: >> >> When running with a graphical console, no message whatsoever is printed >> when the systems hits an unexpected exception and hangs, because even >> the minimal 'exception occurred' message is only sent to the serial port. >> >> So let's fix that, by updating DefaultExceptionHandlerLib to take the >> availability of a console into account. (#5) >> >> This requires some preparatory decruftication so that we can safely refer >> to the system table and console (#1 .. #4). >> >> Changes since v1: >> - split off ArmVirtPkg patch (#3) >> - always send minimal error message to the serial port before attempting to >> send it to console->stdout as well (which is more likely to fail) (#5) >> - add Leif's R-b to the series >> >> Ard Biesheuvel (5): >> ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling >> ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context >> ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase >> ArmPkg/DefaultExceptionHandlerLib: drop BASE variant >> ArmPkg/DefaultExceptionHandlerLib: use console if available >> > > Series pushed as > > 47d977733137 ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling > 74a12eae9f2c ArmPkg/DefaultExceptionHandlerLib: declare the permitted > usage context > ef9f0bff477f ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase > 1e32c49718c6 ArmPkg/DefaultExceptionHandlerLib: drop BASE variant > 31f5388006fc ArmPkg/DefaultExceptionHandlerLib: use console if available > > after applying the changes suggested by Laszlo. I failed to include > Laszlo's R-b in 3/5, apologies for that. > That's not a problem, Laszlo