From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.1211.1610498682324914815
 for <devel@edk2.groups.io>;
 Tue, 12 Jan 2021 16:44:42 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IH0OlO3f;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1610498681;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=m6K0Qr7++1NFPAC6y+a9JZ3gFJyqeu5EoT5kgw7iz8w=;
	b=IH0OlO3fP/C6oKk1Uhmi/XS9Lv3FJllSZ4eXhJ58QIxVzOMRA4t1Xc/8jJBDPmWbxslRQV
	9WRIz5Dsg17/Pr/1Z2JfuD7MNTpPhYbcEHVgE7uzH2l56Azar8i7Dyuj/EqcD+X2oA0No0
	KTq/gZNthGNHQzr1vok+dg+4s8TUgvw=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-396-mji4yglrNqCehpVLMfKg2w-1; Tue, 12 Jan 2021 19:44:39 -0500
X-MC-Unique: mji4yglrNqCehpVLMfKg2w-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBEF9801AAA;
	Wed, 13 Jan 2021 00:44:37 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-31.ams2.redhat.com [10.36.112.31])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0D4A45C23A;
	Wed, 13 Jan 2021 00:44:34 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 2/9] ArmVirtPkg: Refactor with PciHostBridgeUtilityLib
To: devel@edk2.groups.io, cenjiahui@huawei.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Rebecca Cran <rebecca@bsdio.com>,
 Peter Grehan <grehan@freebsd.org>, Anthony Perard
 <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>,
 Leif Lindholm <leif@nuviainc.com>, Sami Mujawar <sami.mujawar@arm.com>,
 xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao <miaoyubo@huawei.com>
References: <20210112094549.10238-1-cenjiahui@huawei.com>
 <20210112094549.10238-3-cenjiahui@huawei.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <85da062f-b5ab-4f26-bd91-0ee985bceca1@redhat.com>
Date: Wed, 13 Jan 2021 01:44:34 +0100
MIME-Version: 1.0
In-Reply-To: <20210112094549.10238-3-cenjiahui@huawei.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/12/21 10:45, Jiahui Cen via groups.io wrote:
> Eliminate currently duplicated code in ArmVirtPkg with the common utility
> class PciHostBridgeUtilityLib.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
> ---
>  ArmVirtPkg/ArmVirtKvmTool.dsc                                  |  1 +
>  ArmVirtPkg/ArmVirtQemu.dsc                                     |  1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                               |  1 +
>  ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf |  2 +
>  ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c   | 44 ++------------------
>  5 files changed, 8 insertions(+), 41 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>