From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.48]) by mx.groups.io with SMTP id smtpd.web08.9604.1623141060719568042 for ; Tue, 08 Jun 2021 01:31:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=E1zaIh1/; spf=pass (domain: arm.com, ip: 40.107.8.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ax0cji5iOdVTFVrzsmRxRiEYuOuepJe9QMBmV9tACiM=; b=E1zaIh1/+38FSGub7FT3eia9msv0eDdP73+/IOWthUwPbmb7H2LDjb925G/kNQjG1JPYwdrDTl19yoWZD2z2COjPTJi52wr0WfPH2KV1owm8xUJooujbJ9K8mdXOqeglCWTpuxjBmJp+FowuTIKWtKw0921YP2+eSnARfz6Jlt4= Received: from AM5PR0101CA0032.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::45) by DBAPR08MB5766.eurprd08.prod.outlook.com (2603:10a6:10:1ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Tue, 8 Jun 2021 08:30:57 +0000 Received: from AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::8b) by AM5PR0101CA0032.outlook.office365.com (2603:10a6:206:16::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 8 Jun 2021 08:30:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT003.mail.protection.outlook.com (10.152.16.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21 via Frontend Transport; Tue, 8 Jun 2021 08:30:57 +0000 Received: ("Tessian outbound bf434e582664:v93"); Tue, 08 Jun 2021 08:30:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 97f4b899e7212246 X-CR-MTA-TID: 64aa7808 Received: from 8fcb9ca3e0e9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F7F1AC39-EDDC-45E2-A86C-A8AF643DEA97.1; Tue, 08 Jun 2021 08:30:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8fcb9ca3e0e9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Jun 2021 08:30:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCnBHADxWhje11tQCzW/lD96p02fyHxE6fJ8cR+Bqkng1UHK9FJ5+0btbrtF+Bds1hMqrjDgwZ4URW12qA05n7XveXQ4bsqzRgcBJ9sFJBRBbtzZjbS71rqE+pOQ+C601jLXWVN1265EVRroqRSxl413dFFs9F1M0loyocD/U69SnZ2T+ORaEtELhRQBurmmbZLYei2d/EX0E8v+AkZ+Rzbvbyd3A67EX7HrNJRgUOaTiYoqlnzm3nXPfYTm1xGeOGbOX8GnMozK8NgT2HiQg3kPmJWm3QY0/RcLvxmmsE6K47OuXCf5aeYLHzhTyK+V0wUS3Fiw/WDR4knWNBfi9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ax0cji5iOdVTFVrzsmRxRiEYuOuepJe9QMBmV9tACiM=; b=euq+mRtZ+O34dlbs+Q2n/HhAm0z7BSjcrXBIj/ykxkQpQXWJH6CDryI8G63WexnAq5CYzPHZWp2gaO0LhBHtkvL/8g/tuDMTi7Mh2UEKuaXmmSXYcUWl7aZTxvPdOLMy01zCoaVaW5JhKNkaur5d11IkydNU8eJx/9uiJfkgq0xSfmUQVGvC/yw9LY4tj9/bO57xx3gfBhOFUcC6ydjp+FckstQCz9Pqn6N/FJhqORjXzwdl7wVM1yty4SKftzjqSoVyFzX1YCxWnDiqhwk3F1jYDb+l/AX6XB/wNSY4pc95ensxUoLwNUDkMGv+t3tHApxh+Ax2Q/aFhbJZscAlLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ax0cji5iOdVTFVrzsmRxRiEYuOuepJe9QMBmV9tACiM=; b=E1zaIh1/+38FSGub7FT3eia9msv0eDdP73+/IOWthUwPbmb7H2LDjb925G/kNQjG1JPYwdrDTl19yoWZD2z2COjPTJi52wr0WfPH2KV1owm8xUJooujbJ9K8mdXOqeglCWTpuxjBmJp+FowuTIKWtKw0921YP2+eSnARfz6Jlt4= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.23; Tue, 8 Jun 2021 08:30:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4195.030; Tue, 8 Jun 2021 08:30:35 +0000 Subject: Re: [PATCH] Platform/ARM/Morello: Correct the private resources in PPTT To: Chandni Cherukuri , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , nd References: <20210519133438.28355-1-chandni.cherukuri@arm.com> From: "Sami Mujawar" Message-ID: <85eda244-dfc9-8992-3616-cf6cb5b0a69a@arm.com> Date: Tue, 8 Jun 2021 09:30:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210519133438.28355-1-chandni.cherukuri@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO4P123CA0333.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0333.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20 via Frontend Transport; Tue, 8 Jun 2021 08:30:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52cee480-5c7b-42be-3d29-08d92a57bd14 X-MS-TrafficTypeDiagnostic: AS8PR08MB6693:|DBAPR08MB5766: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MNlY+kt0zj3T69b9tJbBE9IxOZbhuzYcRkel1PjdhIQJIsdYy3KoB47veSnzAjbwz08dGe2AsYtwdxEnopHGgXjs8YAeUMjTKnxulvZVzR8N6ULTttJc+0IIwvui7TBldIvwtEka5AuJ8LYfQr6eqZhV3uQr/EcggOv3l0c6DNSd7MwVryQlcbyU8wo47V/Yy7MjLxWdsNGCFQgQmgRSrZHI1TjPH2wFlw38WfNNJAHjRh7gVUPOoPL4IFusHF1SwvH1GTjzWSHD+OJgN/k7QVu7TXNnGTfIR3pclIsuBWoBbqaUFbzWgnXyYbYuPhUfg2mN8CjXXzwk3vsJcFwJdM8V9F4eMn3myzqK9ES5YNoJGdtRqvy74s0uSKfhtXqwYULqxt6TqAJzuyPIu0VZKxrWdTlOWwakvjoM7TMpcSp4Z86ZRV27z76PMdvamuDvEuWoMkMPvKaPixD01hUu00XKcRZoHCaTB9iuOjw8C6O+pMvZx6EKDeF7QlA/hr26a3cBkcjNhlxi+dOUfKnTrs9X/pIyWgKscsJ8lIHTZgX+VZXwSkkIKlhH1NWaEog5HDofczfYRCUbHdHOU210j0QrSxj2W6iWRVqOD7qugxfcntXv4WajCfE9rgzlyWkpfa2J7eBsYJwnx+6EhKOmvQP8KtzJ1ZV9UX5idReiAkyGPjDSP9hkOBddbYrmw9jIXz3IEuZQZZCKDOZZCFhvbQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(366004)(376002)(136003)(8676002)(956004)(2616005)(66556008)(478600001)(44832011)(66476007)(8936002)(86362001)(52116002)(53546011)(31696002)(36756003)(316002)(2906002)(31686004)(26005)(16576012)(5660300002)(66946007)(54906003)(6486002)(38100700002)(16526019)(38350700002)(83380400001)(4326008)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UldYL3I0U3NQaHMyUFFkd1VDMGd1VzhZbEJmd0tqcld2dlVqLzQ0Qlhwc2ts?= =?utf-8?B?czNCODI1eWJONzNMK04zZGRJOHJJcis2b2dQQUFYOURSK2J4UkhvTkJXS0Yy?= =?utf-8?B?T0dnSWFGOXNreUpabkE2cFdVWDVUSi9lQTZmOXBoY081bC9UZW9DcW5sT01W?= =?utf-8?B?V3k3bkZXQ2JicFA4TFo3UXpUNlpXT3NKWVFiUm1DY0MxTEVJaS91TGFIdExu?= =?utf-8?B?dC9UK3k3bXhQMmFWU2crQzV4QmRSZmYycS9KalRHWGhFZkswSm0wZVc4MWVi?= =?utf-8?B?WkpRWmVaSFd6RjQ0Q3pxb0VCczg2NlZQaTRnWDh0QmRJZkxzbCtPbWthcmNO?= =?utf-8?B?STZJR0xpelpCbDJFcVJFZHMyRU1mYzh6dTNWa24vQ1RETEsvbUtIVVhUcnE5?= =?utf-8?B?VEZGakN3WEwyRFFuNHVZV0p5cDdhRXVNTmxvWnhFVWVOZFVxY1RrSHZzallQ?= =?utf-8?B?OEZzK3h6TmNjaTlqRHJwSDBmS0prN3E4TS81R2RMc3g2bVdBeTVrR3QwSlg5?= =?utf-8?B?MVlYdzNwcC9ndFRsbS91UHVkRmNtcjh2cnBRVW9JYmhPTEFBTnhET2hIaVhk?= =?utf-8?B?eFNEZnk3cGxlMlBlK2lLUjVzN1pXd212dW5VY3BVYnhLRWp6T0Y4aXRCTUk3?= =?utf-8?B?U01ZZUthck1wV3NDNkZKMjdKa0xRQVBqQkJFdzNyWUd0bUhjY0JybmV5Z2N2?= =?utf-8?B?N0M3VVpZQkxadVNMYU9HL1BXN0pkRHZLelFSbHBwRHkrSEcwdmlUSHlWaGQ1?= =?utf-8?B?eEVZaFFQZUducUxkai9adHBiOUdjZG9kVUU1T2w4bzk4Y3lzZjAvcjEwY3FI?= =?utf-8?B?TEFIVU9EMEZYNlFYanlEbFJuS2pBOVZEb3czUG00TWp4MzFITURqZGUvTUVp?= =?utf-8?B?ZHB4Q1pPd1FMNUxuUTd5UUhINHJ6ZnV0Y0NwRDBEanNreElpWW9EWDNseEgv?= =?utf-8?B?OS9qeWFSOXFJa3lDZmJtM2hTTUZNYkNtSU9GMDlvQ09pMHZCZkdTcHd6VnR1?= =?utf-8?B?dmZtUGVoMzcwT0lySlVsNHd0NGVDQWlqbkh1Vk5aOERORUtHTHRqR01YMXhL?= =?utf-8?B?L0VxelR6MkhQME9XMjZDUmRvYTFJUS9nQ2Vha3RPSmc2M0dDUWplMFd1cU14?= =?utf-8?B?UDV0Z3IrNzNuN1F6dDdzTHRLRGxHNG9DSlhadkt6cGdZNk9iZzJQVGtiRjhk?= =?utf-8?B?elpSSUNuOEsxVjFwYitZa09tSjR4SHk1TFlIUFhEaU84Ny9QV1ZvNHg4RGd5?= =?utf-8?B?eCtDc3l3ck04UDJ4WXI1Sk1VTkdSc1o4NnpVWEFBb3VUcTJSYm42MDZyN0xR?= =?utf-8?B?K0VwbU9kOHcvZTNJUDJ0UFhQdHVZVnFZTXk3bk9yUWFOVWlpNGtpQnFITzkw?= =?utf-8?B?ODN4YXlMa0xjV2NJeGRDZTZodzNxa0lSM25tVmdmK0JESEN6M04rYml5dUhq?= =?utf-8?B?UVRUMEY2dElYdzVRSVdaZm84Rm9aNUlsdCtjVjVBTFVQZWFhejloanN2aGF5?= =?utf-8?B?VEp6VVQ5UHZkcXV2ODRIOTU2WGpTZkUzZXJIdXhUTEFWcXV0V3dCVkJ6NXJG?= =?utf-8?B?cER5K3NCcENGd0Y3d2VTcTMwdmdnbkVQN1J3bUExYWhqNE8xWHg5VGZYVERZ?= =?utf-8?B?TzJwaEo5OEVVcXpwa1poSnFNN1VscUZpUE5LRzk0QWt4RGlXU0ZLbmk2TERJ?= =?utf-8?B?YWNUQU5MemZJd0laQ1ZnUzRhN3F4dnVSczBXYVBQTGZtNmNhcDJHYm50NEp1?= =?utf-8?Q?OsVKOjZYy2ssTPmPMU4I1ttF9eboHS3ASq84bmM?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1722d552-2d1d-4a6b-40f1-08d92a57afce X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 78zkwlE9M+Hzjtf3/CmWXKIRLJor0XRLjyd6TMzhiDrgTsSl+XrjdEQliFJ137tbVlsgxJV2H2Q3PG1xQ364g6BzJ5GQvIMUSiJIdrDH3aOHAE9RS7s7uMrVxGevbEWGpU3UsCL9l8g2DRfAAXbF7aghE/QIhp/WBBtW0fktfyl1Au+lr/Q+zD+9NrVF5vtGZ+kW3rSyJauR1euG4CxyFsXLPBMRCiI+60UNqK0nEUZjSqKYZSsi/nk2JYrO7SSv/u64MaclvhW0LpCsz0gXW1dqxdBQsdJdMtZVyV/GnAE8f8rJA+4Mkm+D2lZmdX/ZlIkwgwuGQYcXszBekAbeK0zhfr1NXsI7FQHXL7gN4OYG4lTBpf/hkPjVF4+Wlf2ZSrkgpSMh6KZyG1o+NGhW7QU8N+ibZrHNRFDgb4QpZmZzOTIKadw47NY7iReEQVq8nvReUddpi+pWPYOLlkylwhdW1WKsTyCiu1XeHFbr49lHiPEEEtYqVcaXJzfxagqtHKixEU3ruG87ZtPoo+VxuOBnz8bi3LOZZw3AckqZZ/O+IblzNOArHc19rpE7RXbU+cj7GcvHib3yy/28oGN991kJlDLdYxTwCiCer2pdzCpVPWB6X0aA9zoCQyflzcMOJ9BfE56ZblrKLgba6Vn8+7lPEnv3cvT7OEfGNNXZ3SlSL76rYV+Zu5M9BZILCUQz X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(136003)(376002)(46966006)(36840700001)(53546011)(44832011)(356005)(8676002)(82310400003)(8936002)(336012)(31696002)(86362001)(6486002)(478600001)(47076005)(82740400003)(2906002)(31686004)(26005)(81166007)(186003)(4326008)(16526019)(316002)(16576012)(83380400001)(70586007)(36860700001)(2616005)(956004)(54906003)(36756003)(5660300002)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2021 08:30:57.1567 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52cee480-5c7b-42be-3d29-08d92a57bd14 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5766 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Pushed as 7bf73ecc3c47..442dfd5da647 Thanks. Regards, Sami Mujawar On 19/05/2021 02:34 PM, Chandni Cherukuri wrote: > As per ACPI specification, only the head of the list needs to be > listed as a resources by a processore node, as cache node itself > contains a link to the next level of cache. > > Signed-off-by: Chandni Cherukuri > --- > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 3 +-- > Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > index 89fadbcb03..7c949812ec 100644 > --- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > +++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > @@ -389,8 +389,7 @@ EDKII_COMMON_PLATFORM_REPOSITORY_INFO CommonPlatformInfo = { > // Resources private to each individual 'core instance in Cluster > { > { REFERENCE_TOKEN (CacheInfo[1]) }, // -> 'core's L1 I-cache in Cluster > - { REFERENCE_TOKEN (CacheInfo[2]) }, // -> 'core's L1 D-cache in Cluster > - { REFERENCE_TOKEN (CacheInfo[3]) } // -> 'core's L2 cache in Cluster > + { REFERENCE_TOKEN (CacheInfo[2]) } // -> 'core's L1 D-cache in Cluster > }, > > // Resources private to the SoC > diff --git a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > index fea4a0efd2..09ebc9a842 100644 > --- a/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > +++ b/Platform/ARM/Morello/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > @@ -205,9 +205,8 @@ HandleCmObjectRefByToken ( > /** The number of resources private to 'core instance > - L1 data cache > - L1 instruction cache > - - L2 cache > */ > -#define CORE_RESOURCE_COUNT 3 > +#define CORE_RESOURCE_COUNT 2 > > /** The number of resources private to SoC > - slc cache