Re: [PATCH v3 4/4] BaseTools/PatchCheck.py: Check the committer email address

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/9/20 11:49 AM, Philippe Mathieu-Daude wrote:
> To avoid patches committed with incorrect email address,
> use the EmailAddressCheck class on the committer email too.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>

Sorry wrong Cc list, I'll respin.

> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index e7b3c3bae47a..fe8e6a64f2bb 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -561,6 +561,8 @@ class CheckGitCommits:
>                   else:
>                       blank_line = True
>                   print('Checking git commit:', commit)
> +            email = self.read_committer_email_address_from_git(commit)
> +            self.ok &= EmailAddressCheck(email, 'Committer').ok
>               patch = self.read_patch_from_git(commit)
>               self.ok &= CheckOnePatch(commit, patch).ok
>           if not commits:
> @@ -579,6 +581,10 @@ class CheckGitCommits:
>           # Run git to get the commit patch
>           return self.run_git('show', '--pretty=email', '--no-textconv', commit)
>   
> +    def read_committer_email_address_from_git(self, commit):
> +        # Run git to get the committer email
> +        return self.run_git('show', '--pretty=%cn <%ce>', '--no-patch', commit)
> +
>       def run_git(self, *args):
>           cmd = [ 'git' ]
>           cmd += args
>