From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.4929.1571232954302073478 for ; Wed, 16 Oct 2019 06:35:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=vqJlLqgH; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.67, mailfrom: pete@akeo.ie) Received: by mail-wm1-f67.google.com with SMTP id a6so2942266wma.5 for ; Wed, 16 Oct 2019 06:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3WeE/kUyaJmrGD436Boe/dRKIwc88mTDYnxoxER5fpM=; b=vqJlLqgH52DV28wlPeex2bMjNL6zwlkoQTM++nCGHwGjMckf88QY4hNw+y6Y8cTT5v KXF2PHYfOMI+Tr66Zuq0Rw34PIYcvArwU80mnUsTOmTNVnKFJcoWhrSpcKIljEuiMPqY f6veFx3L1taBpzas+qITrbDQD9+I/cQQuqQQ376qh7ZjM/SZwIQuqmJi67L+yeFAPh4i eZi7xXHSRhTUngl/HnADzIYpD9cYJzSPNxrhCp+HmKsFzWsF2jqzkPlhauK01HMSjIIt tv7nemL3lEDkq1eAqt4NFV6W8v2YYowz3gmIRSeSj/NmDmtxHCt3dZAlXASZQHx6Hy/Z 395w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3WeE/kUyaJmrGD436Boe/dRKIwc88mTDYnxoxER5fpM=; b=aXh2hc6O26/CILEEmXXipo/mwOC9csdkqNhAylzYMaw9Q1gzmaNJJu2m9bFSFbDpab PSEPuveS/3x7X5Il8u8Nq6ePel6Hej8Oxxl+C3mUtNS4RgCnf0CRo3IRUClqFJFtpwoF c4zOPxgpw75dnGrvJTms03/OcaiSOsOjV0a7vN2CZSm2KYetXQ9YRDTyjiJIlJlM/j2q kDyxfB8+jIzYJf70zAmZQQiykt4w1Fghxafh2kVVkylo3lMAhrHGJvlEkJ+ZSB6MBUsp Be8JVQkXc0hJCgUxFPbrjs/PRA9oCmLP51P+ku0IVMmjpphNvnbs0f0rEqRC1DfR7rnc m8Jg== X-Gm-Message-State: APjAAAX4TJOk+Fd6sVZB8CuWVS+g0sEKRoBqX/jEWdsqpIEfvwvJHwuX 3yXzBh9uDVUA4zeVhKvz9F2q2w== X-Google-Smtp-Source: APXvYqwgXlZvmbq5jfVWTU+zA1doJX1EhHyZf4IFyLgvg19Kn6de2QcrJtVCkqr8oOw6ajz8nSi3nQ== X-Received: by 2002:a1c:7311:: with SMTP id d17mr3294569wmb.49.1571232952659; Wed, 16 Oct 2019 06:35:52 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.68.221]) by smtp.googlemail.com with ESMTPSA id x129sm3481312wmg.8.2019.10.16.06.35.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Oct 2019 06:35:51 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility To: Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org References: <20191016114341.10732-1-pete@akeo.ie> <0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com> <20191016132401.GS25504@bivouac.eciton.net> From: "Pete Batard" Message-ID: <85f7d60f-9c57-3ae2-6b36-cdb9c302483f@akeo.ie> Date: Wed, 16 Oct 2019 14:35:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191016132401.GS25504@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2019.10.16 14:24, Leif Lindholm wrote: > > On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote: >> On 10/16/19 1:43 PM, Pete Batard wrote: >>> DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use. >> >> Oops. > > +1 Yeah, my bad here. I was under the impression that PatchCheck would report those, so I didn't pay enough attention to the debug facility name. And I also only built RELEASE when validating the new patchset that added this new feature. Lesson learned. ;) If anything, this makes a good case for CI, as I picked this issue through the semi-automated builds I carry out for the Rpi3 firmware [1]. Regards, /Pete [1] https://github.com/pbatard/RPi3 > >> Reviewed-by: Philippe Mathieu-Daude > > And > Reviewed-by: Leif Lindholm > Pushed as bd26e4137525. > > Thanks Pete. > > / > Leif >> >>> >>> Signed-off-by: Pete Batard >>> --- >>> Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c >>> index 5abc82b8d363..c72a749b6a2a 100644 >>> --- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c >>> +++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c >>> @@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 ( >>> mMemArrMapInfoType19.EndingAddress = 256 * 1024; >>> Status = mFwProtocol->GetModelRevision (&BoardRevision); >>> if (Status != EFI_SUCCESS) { >>> - DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status)); >>> + DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status)); >>> } else { >>> // www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md >>> // Bits [20-22] indicate the amount of memory starting with 256MB (000b) >>> >>