From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D49820988455 for ; Tue, 3 Jul 2018 02:54:12 -0700 (PDT) Received: by mail-pg0-x241.google.com with SMTP id n15-v6so734914pgv.4 for ; Tue, 03 Jul 2018 02:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2C5YKlbXI02D1SJ4h8nxDuMYbGs5W0+O3eCwARv7vwk=; b=Pimlgp4pKfSFXIpnRrQLy0+i9uthQ0thy/jO3TDdhWzfe3FC+PPS67keGKxw5OWqve yRBsL1pN8PIruCdOYem+7FunBU4nGkHM/jJmlAxu7cfILTpWrewV+xBuK+uC0Hy73RU0 gmQX0PP3ZF+4v1wKGR9tjh2+1YcoAOR7HarKQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2C5YKlbXI02D1SJ4h8nxDuMYbGs5W0+O3eCwARv7vwk=; b=I1wVWy5Xkp8gMH/ANex0MrTy3XJeHGRQRVeZkAZJEH7Xe+ZkuRyIMJ+spuO89765JT 4C9wblU7Jl7HywT9nZnLJ8JLg+RFPYG672qo6yCnLagF3BurSPVkyjzy3SZ3vuPtuis/ AGBhitBOkG89imhKzUe/LsFu75NqubzO4lI2d1SBVB5s8T8nbaJQZcEjVCRHDn6UGjQr N2xTYIcA6pMAbJtT9vNUC1bLErlhb6LLrp5+zBAP53QLCSeB/c3Fy1D6JZu2mJED4QV0 2FC4tIUQM/tPTXrTr5rp6xcGAAbwZ1cWm0FpoJfjYi4/7mDtZjyDIuJAngeToQD9ccR7 8qig== X-Gm-Message-State: APt69E04A3H3d6EZ1RWJM6r9ocPOzEGXpi8M0qB31jgQF2z+PcKFj1AC 83/3ojsd4r0WtKbomTtHbP2HWg== X-Google-Smtp-Source: AAOMgpeK2Jce69z+AtrhsdETppn1yl88aFy7FkSvKAbuZNZfqYHgfnsce8Ua3DDc7Qh2ZxwivToJ6w== X-Received: by 2002:a62:6b44:: with SMTP id g65-v6mr5913043pfc.226.1530611651824; Tue, 03 Jul 2018 02:54:11 -0700 (PDT) Received: from [10.28.1.122] ([64.64.108.182]) by smtp.gmail.com with ESMTPSA id e189-v6sm1844686pfe.52.2018.07.03.02.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 02:54:11 -0700 (PDT) To: Ard Biesheuvel Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo References: <20180627070443.42886-1-ming.huang@linaro.org> <20180627070443.42886-2-ming.huang@linaro.org> From: Ming Message-ID: <8600c362-c35f-e955-1ea5-8e145e4e96dc@linaro.org> Date: Tue, 3 Jul 2018 17:53:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH edk2-platforms v1 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 09:54:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 在 27/06/2018 15:20, Ard Biesheuvel 写道: > On 27 June 2018 at 09:04, Ming Huang wrote: >> The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early. >> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >> gDS->SetMemorySpaceAttributes is invoked by several drivers. >> >> Add several drives to APRIORI scope for implementing the ordering. >> > > Please solve this by adding DEPEXes on gEfiCpuArchProtocolGuid to the > drivers in question. > If solve this by adding depexes, there are many drivers which should add depexes. CpuDxe depend on ArmGicDxe SfcDxeDriver and RealTimeClockRuntimeDxe depend on CpuDxe VariableRuntimeDxe depend on SfcDxeDriver and many other drivers depend on VariableRuntimeDxe Should I add depexes to these drivers? Especially,RealTimeClockRuntimeDxe is in edk2/EmbeddedPkg. Why does other platforms do not have this problem? Thanks. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Platform/Hisilicon/D03/D03.fdf | 10 +++++++++- >> Platform/Hisilicon/D05/D05.fdf | 6 +++++- >> 2 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf >> index 1383aa1091..027b53a6cf 100644 >> --- a/Platform/Hisilicon/D03/D03.fdf >> +++ b/Platform/Hisilicon/D03/D03.fdf >> @@ -146,6 +146,14 @@ READ_STATUS = TRUE >> READ_LOCK_CAP = TRUE >> READ_LOCK_STATUS = TRUE >> >> + APRIORI DXE { >> + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf >> + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> + } >> + >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> >> @@ -153,6 +161,7 @@ READ_LOCK_STATUS = TRUE >> # >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> # >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf >> >> @@ -186,7 +195,6 @@ READ_LOCK_STATUS = TRUE >> >> # Simple TextIn/TextOut for UEFI Terminal >> >> - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> >> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf >> index 4503776d63..37d9cc0c18 100644 >> --- a/Platform/Hisilicon/D05/D05.fdf >> +++ b/Platform/Hisilicon/D05/D05.fdf >> @@ -148,6 +148,10 @@ READ_LOCK_STATUS = TRUE >> >> APRIORI DXE { >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf >> + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf >> } >> >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> @@ -157,6 +161,7 @@ READ_LOCK_STATUS = TRUE >> # >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> # >> + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf >> >> @@ -190,7 +195,6 @@ READ_LOCK_STATUS = TRUE >> >> # Simple TextIn/TextOut for UEFI Terminal >> >> - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> >> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> -- >> 2.17.0 >>