From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web12.874.1589905977221125996
 for <devel@edk2.groups.io>;
 Tue, 19 May 2020 09:32:58 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jU8SL+ys;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1589905976;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=owxV/eKmd2IhUgA/dtWHeiVRcieu7wYcNnyNfOOfkQg=;
	b=jU8SL+ysVEKUXzW9jdspOwy3OBsr0Zpa8Jy3Pt5XJW+8q5RtR44kM9J7vKeWh0UXwvu4QH
	O+/KGpyhuk6p+hp/0QPbOsPvv06Dc8Frz3dyLFk0uODJZjeMA2oTixqQsVgokyXy9zTZWt
	dNw7J+njB5rg3CCl3NUObCllvSN05Us=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-462-AZJqGF7eN36KGFdonJ1nkA-1; Tue, 19 May 2020 12:32:54 -0400
X-MC-Unique: AZJqGF7eN36KGFdonJ1nkA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EF30107ACCA;
	Tue, 19 May 2020 16:32:53 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-149.ams2.redhat.com [10.36.114.149])
	by smtp.corp.redhat.com (Postfix) with ESMTP id DA6B25D9C5;
	Tue, 19 May 2020 16:32:51 +0000 (UTC)
Subject: Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings
To: Ard Biesheuvel <ard.biesheuvel@arm.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, graeme.gregory@linaro.org, tanmay.jagdale@linaro.org,
 sami.mujawar@arm.com
References: <20200519122351.18405-1-ard.biesheuvel@arm.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <861df9de-1c60-492e-02e5-0e88f2fb309d@redhat.com>
Date: Tue, 19 May 2020 18:32:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200519122351.18405-1-ard.biesheuvel@arm.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 05/19/20 14:23, Ard Biesheuvel wrote:
> Add build time checks for serial terminal settings, so we don't end up
> with a non-functional serial console if the PCDs are set incorrectly
> 
> v1 was just the second patch. v2 adds the first patch switching to
> STATIC_ASSERT first, and then uses STATIC_ASSERT in the second one
> as well.
> 
> Ard Biesheuvel (2):
>   ArmPkg/PlatformBootManagerLib: use static assertion for console type
>   ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit
>     count
> 
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo