From: "Laszlo Ersek" <lersek@redhat.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Phillips, D Scott" <d.scott.phillips@intel.com>
Subject: Re: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency
Date: Wed, 12 Jun 2019 09:58:24 +0200 [thread overview]
Message-ID: <862b419a-0715-7430-1f68-bbf54143f7b7@redhat.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8EC967@SHSMSX104.ccr.corp.intel.com>
Ray,
On 06/12/19 04:13, Wu, Hao A wrote:
>> -----Original Message-----
>> From: Ni, Ray
>> Sent: Wednesday, June 12, 2019 10:04 AM
>> To: Wu, Hao A; David Woodhouse; Justen, Jordan L; devel@edk2.groups.io
>> Cc: Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott
>> Subject: RE: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg
>> dependency
>>
>> Hao,
>> Will the CSM duplication cause any code change that may impact CSM
>> functionality?
>
> Hello Ray,
>
> I think there should be no functional impact for the duplication.
> There is no change to the .C/.H files.
>
> Best Regards,
> Hao Wu
>
>> If no, how about firstly duplicate them first?
>>
>> David,
>> Will this approach work for you?
It will not work for me.
Here's the problem:
- I'm not comfortable approving the duplication (or move) under OvmfPkg,
until David ACKs the patch -- the first patch in the series -- that
spells out his reviewership for the CSM modules,
- I believe David is not comfortable ACKing that patch until he can get
the CSM build to work again.
Thanks
Laszlo
next prev parent reply other threads:[~2019-06-12 7:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 1:43 [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 1/6] OvmfPkg/PlatformPei: Remove redundant reference of framework pkg DEC Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 3/6] OvmfPkg/PlatformBootManagerLib: Use PcdShellFile defined in OvmfPkg Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 4/6] OvmfPkg/DSC: Remove the consume of PcdShellFile in framework package Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 5/6] OvmfPkg: Copy LegacyBios protocol definitions from IntelFrameworkPkg Wu, Hao A
2019-06-11 1:43 ` [PATCH v2 6/6] OvmfPkg/IncompatiblePciDeviceSupportDxe: Drop framework pkg dependency Wu, Hao A
2019-06-11 6:49 ` [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency Ard Biesheuvel
2019-06-11 7:35 ` Jordan Justen
2019-06-11 7:37 ` David Woodhouse
2019-06-11 7:49 ` Wu, Hao A
2019-06-11 8:01 ` David Woodhouse
2019-06-11 8:06 ` Wu, Hao A
2019-06-12 1:19 ` Wu, Hao A
2019-06-12 2:04 ` Ni, Ray
2019-06-12 2:13 ` Wu, Hao A
2019-06-12 7:58 ` Laszlo Ersek [this message]
2019-06-12 8:03 ` David Woodhouse
2019-06-12 11:52 ` Laszlo Ersek
2019-06-12 12:08 ` [edk2-devel] " David Woodhouse
2019-06-13 5:47 ` Wu, Hao A
2019-06-12 15:15 ` David Woodhouse
2019-06-12 16:28 ` Laszlo Ersek
2019-06-12 9:50 ` [edk2-devel] " Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=862b419a-0715-7430-1f68-bbf54143f7b7@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox