From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 12 Jun 2019 00:58:31 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 4A268F44CE;
	Wed, 12 Jun 2019 07:58:31 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-191.ams2.redhat.com [10.36.117.191])
	by smtp.corp.redhat.com (Postfix) with ESMTP id B7B595D9D1;
	Wed, 12 Jun 2019 07:58:25 +0000 (UTC)
Subject: Re: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg dependency
To: "Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
 David Woodhouse <dwmw2@infradead.org>,
 "Justen, Jordan L" <jordan.l.justen@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 "Phillips, D Scott" <d.scott.phillips@intel.com>
References: <20190611014313.12160-1-hao.a.wu@intel.com>
 <156023851748.468.9950138266923344967@jljusten-skl>
 <453b7e3c48014bd651717ccf9d9380356530bc82.camel@infradead.org>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8E4FAF@SHSMSX104.ccr.corp.intel.com>
 <abc1db5b19a72e79fb481c381d06d7af3057515d.camel@infradead.org>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8EC920@SHSMSX104.ccr.corp.intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C1B3908@SHSMSX104.ccr.corp.intel.com>
 <B80AF82E9BFB8E4FBD8C89DA810C6A093C8EC967@SHSMSX104.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <862b419a-0715-7430-1f68-bbf54143f7b7@redhat.com>
Date: Wed, 12 Jun 2019 09:58:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8EC967@SHSMSX104.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 12 Jun 2019 07:58:31 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Ray,

On 06/12/19 04:13, Wu, Hao A wrote:
>> -----Original Message-----
>> From: Ni, Ray
>> Sent: Wednesday, June 12, 2019 10:04 AM
>> To: Wu, Hao A; David Woodhouse; Justen, Jordan L; devel@edk2.groups.io
>> Cc: Laszlo Ersek; Ard Biesheuvel; Phillips, D Scott
>> Subject: RE: [PATCH v2 0/6] Ovmf: Drop IntelFramework[Module]Pkg
>> dependency
>>
>> Hao,
>> Will the CSM duplication cause any code change that may impact CSM
>> functionality?
> 
> Hello Ray,
> 
> I think there should be no functional impact for the duplication.
> There is no change to the .C/.H files.
> 
> Best Regards,
> Hao Wu
> 
>> If no, how about firstly duplicate them first?
>>
>> David,
>> Will this approach work for you?

It will not work for me.

Here's the problem:

- I'm not comfortable approving the duplication (or move) under OvmfPkg,
until David ACKs the patch -- the first patch in the series -- that
spells out his reviewership for the CSM modules,

- I believe David is not comfortable ACKing that patch until he can get
the CSM build to work again.

Thanks
Laszlo