From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.45314.1622473604537507779 for ; Mon, 31 May 2021 08:06:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QiLHrDRo; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622473603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ubKsX0TqrWf3EmsomupW4aKa7E1wNVoWW3sp1uF55Co=; b=QiLHrDRoL2fspoFLHLVmYGY7hX5nyJKXUzsAdYcavkYP1MLwyXhIRGtkLp44x6ZkCf5b1U hdnTGSt4WSCbXELzbngUd6qLvzuovdgL5uRL/TPyHD8QYbC+htAwHVy5ZAwUr8p7HLTYoy vWUdoNxnOcOBL7DyN7cxd+W1vmbGyyI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-bzq5t5rLNt2d25Kl_WVX1g-1; Mon, 31 May 2021 11:06:37 -0400 X-MC-Unique: bzq5t5rLNt2d25Kl_WVX1g-1 Received: by mail-wr1-f72.google.com with SMTP id x10-20020adfc18a0000b029010d83c83f2aso4077354wre.8 for ; Mon, 31 May 2021 08:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ubKsX0TqrWf3EmsomupW4aKa7E1wNVoWW3sp1uF55Co=; b=X1TZGGn1ZC5894/6y7MvnIG2jILpbCDvL763SmVJz1l/xzG7OgRtSTdTv7xCVhpQdt dQKDju5yRIp8IU3laB8Ohkgj+5DvRmWGIYe2uXBAxlEuN8YHGoEsk+XQb0r/jNbTOJgV rqO7Gm2n6tDHDgi8e+UZ1y1lHFFyhp4p9+rDY3IOgnjD9xXiYDFk8eflzvPj7hNj9SdJ eRpMAjicTttlvfcYpjvirBCMu8ewVoFlCXehKTZd8MRJt5OfPwuCXUwItvi9N3FSDkQa /QFbieoI3mzdZGrh+ui/uQpDvtx6Rge7bFau5BmwyUaY0RxhURYWeTVK50WxxofWJ2ZZ EcNw== X-Gm-Message-State: AOAM530/2uKjKrYT1oJdFgnNzYXIrWQPLxwmCxLz7x89FXXoVvZAtb4F zJQIG/oVlUTRqPnKKKrUu2+lUMELEHhMDisA2adp9v/1tGTtmuwV1UMHHPMOjDyAJFoe75v6rra oQKy6ekZpAqJv5w== X-Received: by 2002:adf:f805:: with SMTP id s5mr4550678wrp.231.1622473596023; Mon, 31 May 2021 08:06:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJPKsK6JqNqjR/siNUjTRoZw0diTSMnimKqwl2fM/+ZSfb/lm0djcRWFgB9lDeOr6XRPTSQQ== X-Received: by 2002:adf:f805:: with SMTP id s5mr4550640wrp.231.1622473595824; Mon, 31 May 2021 08:06:35 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id c6sm17621429wrt.20.2021.05.31.08.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 08:06:35 -0700 (PDT) Subject: Re: [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc To: Laszlo Ersek , Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Michael D Kinney , Min Xu , Peter Grehan , Rebecca Cran , Tom Lendacky References: <20210526201446.12554-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <8653efc8-6e63-c71a-35a9-80a8986117f6@redhat.com> Date: Mon, 31 May 2021 17:06:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/27/21 10:55 AM, Laszlo Ersek wrote: > On 05/27/21 09:34, Ard Biesheuvel wrote: >> On Wed, 26 May 2021 at 22:15, Laszlo Ersek wrote: >>> >>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 >>> Repo: https://pagure.io/lersek/edk2.git >>> Branch: xen_split_bz_2122 >>> >>> This patch set removes dynamic Xen enlightenment from the following >>> platforms: >>> >>> OvmfPkg/OvmfPkgIa32.dsc >>> OvmfPkg/OvmfPkgIa32X64.dsc >>> OvmfPkg/OvmfPkgX64.dsc >>> >>> In Xen guests, the following platform should be used: >>> >>> OvmfPkg/OvmfXen.dsc >>> >> For the series, >> >> Reviewed-by: Ard Biesheuvel > > Thank you, Ard! > > I hope the large patch count (with the small patch bodies and the > not-so-short commit messages) didn't get on your nerves! I really did > make an effort to find a good balance. E.g. in the "clean up and sort > #includes & INF files" patches. I certainly prefer a long series of little patches (so I can stop / resume the review) rather than a short one of big patches which burn my review cycle quicker. This one in particular made a complex refactor easy to review, thanks! Phil.