From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.80]) by mx.groups.io with SMTP id smtpd.web10.5774.1634722816946876180 for ; Wed, 20 Oct 2021 02:40:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=mNOaGCOC; spf=pass (domain: arm.com, ip: 40.107.7.80, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OIeg52Ju7OWXB9YTn1gFQBjkXcLuq1R4fccF4c3pWOY=; b=mNOaGCOC1FzBtd45z/xinlYoPLrJOAG0yIWGlFyfsdbpoXI//p+KOWSjlQtVzC/8CFeTzIGgsMlxEvqud0nmWF8AyLs7NXsCnuoHqmrI1Vijp4BTAEzTZ2kveSqAAEueQDRgnZgarUQC7hq1+q0PaUESPok4B3GBL5f/C5dBqBI= Received: from AS8PR04CA0130.eurprd04.prod.outlook.com (2603:10a6:20b:127::15) by AM0PR08MB5267.eurprd08.prod.outlook.com (2603:10a6:208:158::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct 2021 09:40:13 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::2a) by AS8PR04CA0130.outlook.office365.com (2603:10a6:20b:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend Transport; Wed, 20 Oct 2021 09:40:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 09:40:13 +0000 Received: ("Tessian outbound a8bfe25d7364:v103"); Wed, 20 Oct 2021 09:40:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: be1f93d83eac195b X-CR-MTA-TID: 64aa7808 Received: from a89f6ffa01e6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9882EDE3-D2D2-4E27-A599-2FA9AA8E98E6.1; Wed, 20 Oct 2021 09:40:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a89f6ffa01e6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Oct 2021 09:40:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWcYelGlZya5rvolclvJDKsceKS79h6c4W9PoynU7hYbWIQcfpMjd0JMvvPiOebKkJJysMrD0SuFklYMXpNlRp55d68yOlaYmDn+SdD3VHvPsW9udENX+nahnOT2SwYNUZSFBvogeXGLof3OKFlLseGTHqu0RkwQoKYYve52E+4zfcCkhjEce8YUOBqLDlPDrRGtXGT4amGMrGzjN925hRYdcxPGfLU7gWiKTSaktooImynDfXoBz/hGkinXOKoR6J81oGUndHnam4cbu/GV0usZqxjOs4pibzrP8g1gJrLsWH490uaT15FQwoCH+YMEGr57zpPoZ/K2C2nGWSFfiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OIeg52Ju7OWXB9YTn1gFQBjkXcLuq1R4fccF4c3pWOY=; b=kXP9JvTBT+V71XFCDmiVpw0LlAtnB4G1/6ZHnjk+rTx4Uc4wGsu5jQOK45dl/X/ylhqJjigE2W6FheDJIetinDpltZX3k5EQUaKorLgzq9MLrT87YMB13PC4j8v9pB5sCmGhsGwUVRXxJ36guB2POT8u8OfvbzHHX1lMKZ8gtz9wsGjYZzkVCtfqZil6JL5PPvN1oz53zSwk6UBPHdnNmrpD8z2ssJ56yWuiHAAz4tUns3XV3nZ52K2K6mPtLyPjwj0zFovRYFg51HTKABh4+q6dVwLjHmajGadZTZ0Ow0dOLK/9Me6+R6P8Ug0H+m5hZ5Z0LApFPM0VMD+8gB31KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OIeg52Ju7OWXB9YTn1gFQBjkXcLuq1R4fccF4c3pWOY=; b=mNOaGCOC1FzBtd45z/xinlYoPLrJOAG0yIWGlFyfsdbpoXI//p+KOWSjlQtVzC/8CFeTzIGgsMlxEvqud0nmWF8AyLs7NXsCnuoHqmrI1Vijp4BTAEzTZ2kveSqAAEueQDRgnZgarUQC7hq1+q0PaUESPok4B3GBL5f/C5dBqBI= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6568.eurprd08.prod.outlook.com (2603:10a6:20b:338::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 09:40:04 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 09:40:03 +0000 Subject: Re: [PATCH] DynamicTablesPkg: Fix unitialized variable use To: Moritz Fischer , devel@edk2.groups.io Cc: Alexei Fedorov , nd References: <20211020052118.1227640-1-moritzf@google.com> From: "Sami Mujawar" Message-ID: <86648b45-863a-9e27-6db1-7127bb8ed7ed@arm.com> Date: Wed, 20 Oct 2021 10:40:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211020052118.1227640-1-moritzf@google.com> X-ClientProxiedBy: LO2P265CA0179.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0179.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 09:40:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4556e916-cf20-4d05-dd75-08d993ad9dcb X-MS-TrafficTypeDiagnostic: AS8PR08MB6568:|AM0PR08MB5267: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2449;OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5t5oLGuU+aGiBCZrUUgNGPR+QT4fPsMa+5qtrRk+oCULuP30ddc0JfDs+wYV/wKuM7Y3DPDUj1DH6WHu7v/xr6/c0o/vBsVz1CJgONeo39u0MVUxnDXJ8VWKBRb4BpNV9AzjDoMIS6L47rLfLuvmAoFsMauoQxfnS+OObplTv5tF/5CM1qyVuefg+JS7H2zbBZyVF26xvn63y/igK64qVuL34DoH8Ri9oh9ri5jw4SMLkbkV2jVv1NrHX+NmXGL/ehUJojwAuE6/6XIpvOD9YTksjncAYAWiO7Tb0ZVi0CEFk9O8IGPp2pzmJlBbCJUMExhkA/lXZDdkK1se9q5fVyqnWakWrJe6vNFmKgX8DYJ+OU8KkkN8nSVF+JxHhpXOLKnuajWZ6bNwJNKH0UKbTsuQwnAIfNWYlARZp5X+Z9OmicXxl0qV34c5qPgKDqooOU1IM4r6BHF9NwwNQCI8mPVS2aVIi8xqOeVLDNfsD1G6DwycEuyAR/OdgS3ysG3RpjaIDDXeNbgK2B15lYp3XaTkUxZqlYenHlL35ylwxUUSx4XbNEAeJuwr6BuIeL2R1wjMJJzW/lcW5oNufZ1pobZTyMPz9d4DPeIMhljHt8XSmW1ilI8p7qx/+ex456uWiuO7rcFbDpyrhwEJ79jjL/HtutWrxXdEDhwZQ3H1Doy6ET/UjyCMkDTUlLC0t+CDwdoXsFX3elyXVe6S+zS/w9sccjsELqIgvDzgZCySNpakayGKocsSjXXLUHqa1R/Fw3rsYfQ96zs3yqqHZz2ijA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(53546011)(38350700002)(66476007)(38100700002)(66556008)(31696002)(66946007)(36756003)(54906003)(26005)(44832011)(2906002)(2616005)(508600001)(5660300002)(86362001)(83380400001)(52116002)(8936002)(16576012)(316002)(6486002)(186003)(31686004)(956004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6568 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: efcdd9c5-5c51-4492-c9f5-08d993ad97f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U8UYFV25sEYGVuQM205W8iGWS4LQoh1ZQ9mCoAw2TVsS0OPcVFrF8RwivtGFtHVhS62Y+0iPmNA2e2OBWLCYo05ZTsblH0XXP4dhM4q3/GgQAcyAgEds+6lLtsp1IEjMNDDrJc1BSeUIbX2NBIFTNaOKhE6LXKN+41FYyUSHv54ApDaWWlXyvbtW8BUwAFgy3XMpDx505OljnnfEINBLPVGntCIeiOhWB1SbZVNX1TjyZgIFU2p3c5Nr6tp8HLhjyZ7ymfe6OdqroXnkYvBQ9lrs7EoRxlxC8A8joLgJDnV/cDbIfVvIQkF/HlFj5z7qLFN6PDhbxGMERVN9HXUo7pEn3nD0UlXnYTdj2SThx0WkgsI1fuOcb9iHqU6ECTHaBD+lnc4IUpZ4DhuxZ0TjUnWnXn85uI+zvV2gSN4r6lMP0RNP+PnerSXItm9NeWYsPHXi4IqL1kw+vXHceCufigImbabP1AnruCKdbsjhq6ISHlJTjwU5R9B0uM4/UKEboIHVL/i+W9JWpzRqBd1T1o3TOpaP869cbO6nXo6O0E9BsctwaK/badUfvJS0H1zi2QavfmG7/zXNUl4sdAR769AdcHUL/Ddm1wqM6Ql4T/Q+2Xcxt0VO1zxWC/HysUeD7gFuKh5RdScgrXx5KQkLTz9GDBwyElMJpKYewMmfIXQXbr3qrD4pL3an0aP0DRgyE3sJnfBb0Q8difcv5HaK5ybujQe95YQ9KQlPn7kCUOk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(47076005)(31696002)(26005)(508600001)(2906002)(4326008)(356005)(81166007)(31686004)(36756003)(53546011)(86362001)(82310400003)(186003)(8936002)(83380400001)(8676002)(54906003)(16576012)(316002)(70206006)(44832011)(70586007)(956004)(36860700001)(5660300002)(6486002)(2616005)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 09:40:13.4936 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4556e916-cf20-4d05-dd75-08d993ad9dcb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5267 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Moritz, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/10/2021 06:21 AM, Moritz Fischer wrote: > In the success case we should return EFI_SUCCESS rather than returning > a potentially unitialized value of Status. > > Cc: Sami Mujawar > Cc: Alexei Fedorov > Signed-off-by: Moritz Fischer > --- > .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > index 0bdb6c24c5bb..e9e1a85ede63 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c > @@ -91,7 +91,7 @@ LinkRdNode ( > *NewRdNode = RdNode; > } > > - return Status; > + return EFI_SUCCESS; > > error_handler: > Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);