From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mx.groups.io with SMTP id smtpd.web11.1042.1683037384847172468 for ; Tue, 02 May 2023 07:23:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=bp/ddHaP; spf=pass (domain: bsdio.com, ip: 64.147.123.25, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 822313200936; Tue, 2 May 2023 10:23:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 02 May 2023 10:23:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683037383; x=1683123783; bh=NEBF9fi5uuy9Gc7+7dt4OPI+zZ+Vcnavbyr /wOBAKMo=; b=bp/ddHaPgfBr3w5uqHW8I68t/Pk0occkMPw4/Y0cBgozjxkHbmf CzFP1m7nI1ENf2PbyeZKJcZZ8n12V0hsNeBmvZyc39IsZVTVshxWi1Ps4HaaCmeU EEAOu3iyau0cL/s9m+sLZEsjXGuOZu2f1i8kYiiPwNQthDzfneM2VAHgqPU6AIkQ hROsKCnR33ubeDo+uF/31bK+DlPDlvPcT3NcWB7of4kCgChHeo/NFbkp1+a8UCXU Lw99DKCUWspJjsK5Xeh+Z2D6GsgO5/5QpMj18KLkIVetxLb2AZMX0VyiiGbeHplE d9JW8CRh1PyQA258XfCiiCxTbNjeTTCkw+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683037383; x= 1683123783; bh=NEBF9fi5uuy9Gc7+7dt4OPI+zZ+Vcnavbyr/wOBAKMo=; b=Y 3HUFujkrn5/PkUSDtQQA5E1Y8kLc3QD9Pfsrqmw+Wzmj7KdxZopUghLrKhhxDu4B IselB7oeATu0u4Tj8eSlcMBd95cWvW7VAH98teX++tqki2M0GbMaVISSxy0hKoUI tuw11rs0CIUrIT6q7DO7YZEr4TJD+R8Os43ClZCrnfQ0N1GcyWT8qaTicYuzHMMi P0FG/d4OogFrwyMghoqnftjuVajZWiGnsDJEDwJGX/z9VE+yk6d4eQXz2qBruQUM HDLVGl1clGiWcPvqYBwFd2w1jNnH4AzrcTH53HN4/5/Xmq9HRUi5n34BWtRpb9IC pYyet2eDi7QeKvTob4OZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedviedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepueehffegfeeluedufefffeejieeugeegvdefgffhueetheeuheegieeftddu feehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 May 2023 10:23:01 -0400 (EDT) Message-ID: <86788472-2e1d-fa5d-30f1-9b2a7f139339@bsdio.com> Date: Tue, 2 May 2023 08:23:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , Andrew Fish , "Ni, Ray" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Zeng, Star" References: <20230501160839.884391-1-rebecca@bsdio.com> <20230501160839.884391-9-rebecca@bsdio.com> <8387e266-9e03-38ea-340b-2db994971bd0@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/2/23 00:35, Yao, Jiewen wrote: > Have you evaluated size impact with this new compiler option? Especially crypto library. > Bigger? Smaller? The increase in size when we disable LTO doesn't seem too bad: With LTO: -rwxrwxr-x 1 bcran bcran   13M May  2 08:11 CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug -rwxrwxr-x 1 bcran bcran   13M May  2 08:11 CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug -rwxrwxr-x 1 bcran bcran   11M May  2 08:11 CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug -rwxrwxr-x 1 bcran bcran   11M May  2 08:11 CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug -rwxrwxr-x 1 bcran bcran  8.5M May  2 08:11 CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug -rwxrwxr-x 1 bcran bcran  8.3M May  2 08:11 CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug -rwxrwxr-x 1 bcran bcran  8.0M May  2 08:11 CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug -rwxrwxr-x 1 bcran bcran  7.8M May  2 08:11 CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug -rwxrwxr-x 1 bcran bcran  7.0M May  2 08:11 BaseCryptLibUnitTestShell.debug -rwxrwxr-x 1 bcran bcran  7.0M May  2 08:11 CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug -rwxrwxr-x 1 bcran bcran  6.9M May  2 08:11 CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug -rwxrwxr-x 1 bcran bcran  6.7M May  2 08:11 CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug -rwxrwxr-x 1 bcran bcran  6.7M May  2 08:11 CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug -rwxrwxr-x 1 bcran bcran  6.5M May  2 08:11 CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug -rwxrwxr-x 1 bcran bcran  6.2M May  2 08:11 CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug -rwxrwxr-x 1 bcran bcran  6.2M May  2 08:11 CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug -rw-rw-r-- 1 bcran bcran 1005K May  2 08:11 CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi -rw-rw-r-- 1 bcran bcran  903K May  2 08:11 CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi -rw-rw-r-- 1 bcran bcran  811K May  2 08:11 CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi -rw-rw-r-- 1 bcran bcran  755K May  2 08:11 CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi -rw-rw-r-- 1 bcran bcran  724K May  2 08:11 CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi -rw-rw-r-- 1 bcran bcran  710K May  2 08:11 CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi -rw-rw-r-- 1 bcran bcran  654K May  2 08:11 CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi -rw-rw-r-- 1 bcran bcran  623K May  2 08:11 CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi -rw-rw-r-- 1 bcran bcran  585K May  2 08:11 CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi -rw-rw-r-- 1 bcran bcran  560K May  2 08:11 BaseCryptLibUnitTestShell.efi -rw-rw-r-- 1 bcran bcran  555K May  2 08:11 CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi -rw-rw-r-- 1 bcran bcran  500K May  2 08:11 CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi -rw-rw-r-- 1 bcran bcran  485K May  2 08:11 CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi -rw-rw-r-- 1 bcran bcran  485K May  2 08:11 CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi -rw-rw-r-- 1 bcran bcran  454K May  2 08:11 CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi -rw-rw-r-- 1 bcran bcran  454K May  2 08:11 CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi Without LTO: -rwxrwxr-x 1 bcran bcran   14M May  2 08:13 CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug -rwxrwxr-x 1 bcran bcran   14M May  2 08:13 CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug -rwxrwxr-x 1 bcran bcran   12M May  2 08:13 CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug -rwxrwxr-x 1 bcran bcran   12M May  2 08:13 CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug -rwxrwxr-x 1 bcran bcran  9.5M May  2 08:13 CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug -rwxrwxr-x 1 bcran bcran  9.2M May  2 08:13 CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug -rwxrwxr-x 1 bcran bcran  8.9M May  2 08:13 CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug -rwxrwxr-x 1 bcran bcran  8.7M May  2 08:13 CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug -rwxrwxr-x 1 bcran bcran  8.0M May  2 08:13 CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug -rwxrwxr-x 1 bcran bcran  7.9M May  2 08:13 BaseCryptLibUnitTestShell.debug -rwxrwxr-x 1 bcran bcran  7.9M May  2 08:12 CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug -rwxrwxr-x 1 bcran bcran  7.7M May  2 08:12 CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug -rwxrwxr-x 1 bcran bcran  7.7M May  2 08:13 CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug -rwxrwxr-x 1 bcran bcran  7.4M May  2 08:13 CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug -rwxrwxr-x 1 bcran bcran  7.2M May  2 08:12 CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug -rwxrwxr-x 1 bcran bcran  7.2M May  2 08:13 CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug -rw-rw-r-- 1 bcran bcran  1.1M May  2 08:13 CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi -rw-rw-r-- 1 bcran bcran 1011K May  2 08:13 CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi -rw-rw-r-- 1 bcran bcran  914K May  2 08:13 CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi -rw-rw-r-- 1 bcran bcran  823K May  2 08:13 CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi -rw-rw-r-- 1 bcran bcran  813K May  2 08:13 CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi -rw-rw-r-- 1 bcran bcran  789K May  2 08:13 CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi -rw-rw-r-- 1 bcran bcran  722K May  2 08:13 CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi -rw-rw-r-- 1 bcran bcran  687K May  2 08:13 CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi -rw-rw-r-- 1 bcran bcran  644K May  2 08:13 CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi -rw-rw-r-- 1 bcran bcran  632K May  2 08:13 BaseCryptLibUnitTestShell.efi -rw-rw-r-- 1 bcran bcran  610K May  2 08:13 CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi -rw-rw-r-- 1 bcran bcran  567K May  2 08:12 CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi -rw-rw-r-- 1 bcran bcran  543K May  2 08:12 CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi -rw-rw-r-- 1 bcran bcran  543K May  2 08:13 CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi -rw-rw-r-- 1 bcran bcran  508K May  2 08:12 CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi -rw-rw-r-- 1 bcran bcran  508K May  2 08:13 CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi > > Why we add "-flto" for "NOLTO" ? >>> + *_GCCNOLTO_IA32_CC_FLAGS = -flto >>> + *_GCCNOLTO_IA32_DLINK_FLAGS = -flto I don't know why -flto was added for the GCC49 flags, but when I created the GCCNOLTO flags I copied it because I presume there's a reason this specific test package requires it. -- Rebecca Cran