From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.4155.1622104760851302509 for ; Thu, 27 May 2021 01:39:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NTpBecMr; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2rLpupO0xq+VKhWLqGP263bA+FUF4BSyQiacn+gIEt4=; b=NTpBecMrfacNjPXpYJZCYG7kt6H6z1KYmQnLWOuqyH3MbZHSBVxr37vgnfs/5j6sjPPanY hfkk/8nABwGU4r+NqkwGC96gixkKtybeXoYRANwr1oO/z/Rnyw9vDdjWnj0rOft+kmQ53K ibNQYoz1g9gZmCOOonYz197D4wG3y84= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-J8-CRZ9LM-SRg6MfRgiACQ-1; Thu, 27 May 2021 04:39:18 -0400 X-MC-Unique: J8-CRZ9LM-SRg6MfRgiACQ-1 Received: by mail-wm1-f69.google.com with SMTP id b68-20020a1c80470000b02901846052c7a7so1079836wmd.2 for ; Thu, 27 May 2021 01:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2rLpupO0xq+VKhWLqGP263bA+FUF4BSyQiacn+gIEt4=; b=RXBG/YTOkS29r7gTjNdNF2GHdYT3z+4Aa1nLI1+4iGx3EQtKGLbzt0Kx/LWNrm6BbU oj7R/tHqhfB4nT9WtFm5h5kwpDW1qrMd0EqO313RIfsPlKccSeu3MvMIqvRZevtoE1J3 NtG+/N/PfSqaN3w328SSjNJDNpZrQ9D4BSbwHivdHYE+fXAM7Kg39SpXu/veZZFrAFXl /ggdVIqZovSZC7YLprbHGFVV4vwOmb1zh5CLVx3x8hNuE6UBhLF79rfP11B9E6kxSGWM qW0oCRZ6jUM49eKR2dhE0eeY02Sp/rOesLp4Bpc0qfUuyt2xWsM+9m5RRdZ9/iK2ec4/ 8kMg== X-Gm-Message-State: AOAM5336CirQdGYu0rQprHjj56sBDRrjFhte6QnRXmS+tTldwYk8ADwi lgQvoEPCiv0AIktY1woqL/l9Y59q/hVz29ywNjDWhOZjiyVelI2J08nBCa0uI3TAFht3S8SbS9L 65cj4uNZjN4H4rw== X-Received: by 2002:adf:8bc9:: with SMTP id w9mr1373273wra.378.1622104756764; Thu, 27 May 2021 01:39:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8etw+8ONBLDAwSsQEOuP6DXVWN61i6cEa49SoedMCVwPxC1uZt5KEM39ET8sKcTpa3IuUpg== X-Received: by 2002:adf:8bc9:: with SMTP id w9mr1373257wra.378.1622104756573; Thu, 27 May 2021 01:39:16 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id l188sm6066051wmf.27.2021.05.27.01.39.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:39:16 -0700 (PDT) Subject: Re: [PATCH 14/43] OvmfPkg/XenAcpiPlatformDxe: remove QEMU fw_cfg dependency To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-15-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <86b90cc9-a80c-344d-8438-e2789c827dbf@redhat.com> Date: Thu, 27 May 2021 10:39:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-15-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The QemuDetected() function wraps QemuFwCfgIsAvailable(); it always fails > on Xen. Because of that, we can eliminate the QemuDetected() call itself > from the Xen ACPI platform driver, and then the rest of "Qemu.c" becomes > useless -- the workhorse function of that source file is > QemuInstallAcpiTable(), which we no longer call. > > Remove any dependencies that are no longer needed by the > XenAcpiPlatformDxe driver. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 9 - > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.h | 14 - > OvmfPkg/XenAcpiPlatformDxe/AcpiPlatform.c | 9 +- > OvmfPkg/XenAcpiPlatformDxe/Qemu.c | 511 -------------------- > 4 files changed, 1 insertion(+), 542 deletions(-) Reviewed-by: Philippe Mathieu-Daude