From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C900B21CE73F6 for ; Thu, 13 Jul 2017 13:07:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AB2C7F3ED; Thu, 13 Jul 2017 20:09:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9AB2C7F3ED Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9AB2C7F3ED Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-47.phx2.redhat.com [10.3.116.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECB7561F25; Thu, 13 Jul 2017 20:09:31 +0000 (UTC) To: Leif Lindholm , Alexei Fedorov Cc: "edk2-devel@lists.01.org" , "liming.gao@intel.com" , Ard Biesheuvel References: <20170713124844.23556-1-ard.biesheuvel@linaro.org> <20170713124844.23556-2-ard.biesheuvel@linaro.org> <20170713141147.GD26676@bivouac.eciton.net> <20170713173119.GG26676@bivouac.eciton.net> From: Laszlo Ersek Message-ID: <86c37ee5-71d2-6fd5-7706-5505d38ba380@redhat.com> Date: Thu, 13 Jul 2017 22:09:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170713173119.GG26676@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 13 Jul 2017 20:09:33 +0000 (UTC) Subject: Re: [PATCH 2/2] BaseTools/tools_def AARCH64: avoid SIMD register in XIP code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 20:07:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/13/17 19:31, Leif Lindholm wrote: > How are you ending up with all of those -O3? Sorry for butting in, but personally I consider -O3 "suicidal". The only -O3's I can currently see in BaseTools are: > Conf/tools_def.template:DEBUG_CLANG38_IA32_DLINK2_FLAGS = DEF(GCC5_IA32_DLINK2_FLAGS) -O3 > Conf/tools_def.template:RELEASE_CLANG38_IA32_DLINK2_FLAGS = DEF(GCC5_IA32_DLINK2_FLAGS) -O3 > Conf/tools_def.template:DEBUG_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) -O3 > Conf/tools_def.template:RELEASE_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) -O3 Since I don't use CLANG, I don't mind these, but for gcc, I would. In the past, Liming once suggested -O3 for the build tools themselves (via -Ofast) -- meaning full well, of course! --, and I protested: http://mid.mail-archive.com/ed237dbc-25f0-d0a9-3252-9a503de67ee4@redhat.com And so we have commit 202726b3ceb3 ("BaseTools Makefile: Enable O2 option for GCC tool chain", 2016-09-29) today. ... I realize my email can appear as FUD, but I think there's a reason most distros build their packages with -O2. Even upstream Linux uses -O2 generally (the only mention of -O3 I find right now in "Makefile" is about problems it causes with gcc-4.8). Thanks Laszlo