From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.11905.1620905098792184599
 for <devel@edk2.groups.io>;
 Thu, 13 May 2021 04:24:59 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ud6g4igZ;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1620905098;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mmlIm2AKSSyICMR5JPJxXlLpfJ4fVpFfcRNMhMxGJCY=;
	b=Ud6g4igZUbU5LfwPVe+SXr5d6hAI1uR86E49fKjtf8XlxZx8Z6WbXLCQ57mBxp/SKY+dvN
	PkXnC3WNEFM3UsIIBFs4gzNi6FZUt5bLe0k6P1200sONET0jaHGmRmeFRX5U5UhctQG9P0
	ukgC1alp3GH8QVxkcuPdRDqeBgNfq2U=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-573-ErrGUHqcM4SmAqGdsm6V2w-1; Thu, 13 May 2021 07:24:56 -0400
X-MC-Unique: ErrGUHqcM4SmAqGdsm6V2w-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30135806680;
	Thu, 13 May 2021 11:24:54 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-183.ams2.redhat.com [10.36.112.183])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 3CCEA687D7;
	Thu, 13 May 2021 11:24:52 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter
To: Brijesh Singh <brijesh.singh@amd.com>, devel@edk2.groups.io
Cc: James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Erdem Aktas <erdemaktas@google.com>
References: <20210507203838.23706-1-brijesh.singh@amd.com>
 <20210507203838.23706-14-brijesh.singh@amd.com>
 <3c85698e-0b5e-38b0-f752-30204cb78cad@redhat.com>
 <41c63c63-554d-1f7d-5d27-bd649261e897@amd.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <86e36df7-e60b-c0c9-6b5c-f14f7259e509@redhat.com>
Date: Thu, 13 May 2021 13:24:51 +0200
MIME-Version: 1.0
In-Reply-To: <41c63c63-554d-1f7d-5d27-bd649261e897@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 05/11/21 19:45, Brijesh Singh wrote:

> The  internal function is used for clearing the mask for both system RAM
> as well as Mmio, so we need a way to tell the internal function that
> call is for the Mmio range. I thought making all the changes in a single
> file makes sense but I see it can get harder for the review. I guess I
> could split the work in two patches
> 
> 1) Drop the cache flush param from high level
> MemEncryptSev{Set,Clear}PageEncMask and don't touch anything in the
> SetMemoryEncDec()
> 
> 2) Rename the Flush parameter to Mmio in the SetMemoryEncDec()
> 
> Does it makes sense to you ?

Yes, sounds good. In (2), you can explain the motivation.

Thanks
Laszlo