From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.75839.1674745701770427646 for ; Thu, 26 Jan 2023 07:08:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EczBBVEF; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: maz@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F89461856; Thu, 26 Jan 2023 15:08:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F2AC433D2; Thu, 26 Jan 2023 15:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674745700; bh=jvYNaGBlp6iY/WCDujyJagrlyU8GSRwtw6T8MyUynNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EczBBVEFXqphWs1oIV9kil5Sb+UHDkoKqOcT6U4FerSaBK/F4on/Bpumv3yp4MHYo WMJj6+PQxZeKzMbakFn9KdxNsy5g5wfnai9v4jq2jxt/3TP+gRp/VnHnhvVhTCvBFO 2RD0E2kS8Er00cCRAffgIo1fLJGv1Qn34NQuhb5czJntsb6B7WPoZG/yTEVC9qS0rU HK05tyaEcmlSbvL2xj6Z5ShRJ+/Jann3kSzU7TT+7AtzhG1jrvl2LaxD0Lu8UBQ++8 Jdr3APRwAFDKKA91YwePyAY0Xy3E1vlSa4d8O4B5KQfTt+QTFyDFh+UYIWOiu37jb5 d+Cne9fCQpcsQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pL3rO-004rW0-D3; Thu, 26 Jan 2023 15:08:18 +0000 Date: Thu, 26 Jan 2023 15:08:18 +0000 Message-ID: <86wn59l4f1.wl-maz@kernel.org> From: Marc Zyngier To: Gerd Hoffmann Cc: Ard Biesheuvel , devel@edk2.groups.io, osteffen@redhat.com, dann.frazier@canonical.com Subject: Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX In-Reply-To: <20230126144613.a5vtxwnqgbj7ob7c@sirius.home.kraxel.org> References: <20230119120021.4yohqindvj3ghwky@sirius.home.kraxel.org> <20230126120151.kqxphknorphulcb5@sirius.home.kraxel.org> <86zga5l84j.wl-maz@kernel.org> <20230126144613.a5vtxwnqgbj7ob7c@sirius.home.kraxel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kraxel@redhat.com, ardb@kernel.org, devel@edk2.groups.io, osteffen@redhat.com, dann.frazier@canonical.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Content-Type: text/plain; charset=US-ASCII On Thu, 26 Jan 2023 14:46:13 +0000, Gerd Hoffmann wrote: > > On Thu, Jan 26, 2023 at 01:48:12PM +0000, Marc Zyngier wrote: > > On Thu, 26 Jan 2023 12:01:51 +0000, > > Gerd Hoffmann wrote: > > > > > > > > Thanks for the koji link, Gerd. > > > > > > > > > > It works with 6.1.7-200.fc37.aarch64. > > > > > Perfect. > > > > > > > > > > Thanks Ard, thanks Marc! > > > > > > > > > > > > > Thanks for the report. Up to this point, Marc is the only one who had > > > > managed to reproduce this afaik, so having another data point where > > > > the fix works as intended is rather nice. > > > > > > One more data point: This also gets things working again on the > > > raspberry pi 3. Well, sort of. There still is some timer problem > > > (it waits forever on the splash screen). That might also be some > > > qemu bug though ... > > > > RPi3 as a host? Using the QEMU-provided GIC emulation? > > Yes. > > > I wouldn't be surprised if that broke ages ago as nobody really tests > > this configuration. > > Understandable. 1G is enough for simple smoke tests but not much > beyond that. And it is the odd child in the gang which hasn't a gic. I suspect that it is that last point that has broken. The kernel handling of that configuration has always been super sketchy, and it would take almost nothing for that to break. I'm almost thinking of writing an in-kernel GICv2 emulation just to get rid of the rest of the hacks that have proliferated in the timer and PMU code. But is it worth it for such an odd machine? The alternative would be to move on and stop supporting KVM on this wonky setup. :-/ > > If you can pinpoint the last state where this actually worked, I'll > > try and have a look. > > Don't have that at hand. Need try downgrade stuff and see what I find. > Tried with edk2 already back a year or so without success. Didn't try > downgrading qemu / kernel yet. Right. Let me know if you get somewhere with that at some point. > > But this sounds unrelated to the page fault handling that my patch was > > fixing. > > Yes, unrelated bug. But the page fault bug reproduces on the rpi3 too, > without the fix the firmware hangs before printing the first log line. > Wanted report that because Ard mentioned it is hard to reproduce. Right, thanks for that. Very interesting data point indeed. Cheers, M. -- Without deviation from the norm, progress is not possible.