From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.43548.1674129359665151639 for ; Thu, 19 Jan 2023 03:55:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T32dcYHI; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: maz@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1200C61BB0; Thu, 19 Jan 2023 11:55:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B89C433F0; Thu, 19 Jan 2023 11:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674129358; bh=rtCLtcVtg1xbftFcSi3fOK6sJRGk8X1xGQ4bebq03V0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T32dcYHIctbwIvYpguRDABIuvoEDKwUws6FHxxE8SKixoZEvp6JpEbnIT9tJUCuu2 1iJjj/ky1/nIFkVWBe1D1tGl/yw4ZbhV76ugnl+/2ym5Dlj6rPVu+VcEWOaq4spXg6 XCw6Fckjgo7GEad2GxCqGKnWk7M0Xo8XReYvfXhJ6C/kNexjEPZ+hXbwWQDZ6Ar4Yp JAyD5gH4ytAEwNlK7x01wQCvfwCQ5L6oh84grsW4CVbvEC2IaZZ8b88qd4r45ID0mE j7i2ZWHsArfgVsYFEGuHQg285p9bY09fEBIDZ6l0ejhtBRMJo+NwOIORZwHxXbRymI eOO52jEKo9rbw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pITWO-0034AR-5k; Thu, 19 Jan 2023 11:55:56 +0000 Date: Thu, 19 Jan 2023 11:55:55 +0000 Message-ID: <86y1pyn3g4.wl-maz@kernel.org> From: Marc Zyngier To: Ard Biesheuvel , Oliver Steffen Cc: devel@edk2.groups.io, dann.frazier@canonical.com, kraxel@redhat.com Subject: Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX In-Reply-To: References: <20230105162528.1430368-1-ardb@kernel.org> <20230105162528.1430368-2-ardb@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ardb@kernel.org, osteffen@redhat.com, devel@edk2.groups.io, dann.frazier@canonical.com, kraxel@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Content-Type: text/plain; charset=US-ASCII On Thu, 19 Jan 2023 11:11:34 +0000, Ard Biesheuvel wrote: > > (cc Marc) > > Context: > - on my TX2 (with the S1PTW r/o memslot fix applied), the new version > of ArmVirtQemu that uses an initial ID map in emulated NOR flash works > fine. > - in Oliver's case (which is a slightly different flavor of TX2), it > crashes extremely early, presumably at the point where this ID map is > activated. Oliver seems to have a vintage ThunderX (aka the worst arm64 implementation in history!), so it is indeed a very different beat from TX2. Without the kernel patch[1], I can trigger the issue pretty reliably, specially in the absence of THP. It all depends on the layout of the EDK2 object and the order in which pages get mapped. The first course of action would be to make sure that the patch is applied to the host kernel. If this still fails to boot, I'm happy to help investigating it. M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch?id=406504c7b0405d74d74c15a667cd4c4620c3e7a9 -- Without deviation from the norm, progress is not possible.