From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C83C203555E5 for ; Thu, 16 Nov 2017 04:30:02 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id z3so9346828wme.3 for ; Thu, 16 Nov 2017 04:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LXo98DsGP/yfBPNtZmeohO1sU7mToaHY5db3d9ioE+w=; b=AzBeJPPmtxD8hQyxcD2Bv4MokdpHtt1eQXk+UisYZdk7VbitxaDpzI+nsXl4oecyu3 rokzo57+D+Sbmg2ZQLEDcUVzeAJ198umOvSp9aQS+kHiezX7XhRxKqJHsZ+fG+mNUsJc 0rSmYQOq5bpeetwqg807EPMWoE35IKY8lqAoo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LXo98DsGP/yfBPNtZmeohO1sU7mToaHY5db3d9ioE+w=; b=FyQPr4JmxhbCd7sMceuTOHVk7QU3eYVBAlgovd0q07/H04lwZbKHA6TRDhXuBGeUOZ W1rqMpqbLBMHgS1OXRkiOgq2DvkGdV5/q8at6usWoUUa7+zUgK9u8sp7L+KQKmA6VIG6 ACox6jBHkA0P+gzwXULjz/Xy1W8ECWJX2aE9UG7zqoiYBWv4yLIOsBazRZKVb5Wpvp3s totOQgUmi6WH3/1nPCZe4T/FddLaNABTUr5XmNgxKjWRmSr45daTnVoRiipQCOajpzC0 fzWRheA95QR1IYD6d0dvR0GJG517G6NnaFbv58FAs8IGBR15VU985YWzx1KlOwLpDyMo kZCg== X-Gm-Message-State: AJaThX4MKz9DU6KBu6gdCbZL5fbfOU9GTg429rwrwNK4Co1Yo3GdNkzA ERSa3GvDbPs1vIIBgsBYtRRlG/DAe5k= X-Google-Smtp-Source: AGs4zMYNTbC3TfcHr6/pUQb+6qPeytwTYuHQVb+WF+4VSfbG6JpPGCDOHHA3i7kOsKmdWDR5a3Cf3A== X-Received: by 10.80.179.246 with SMTP id t51mr2531532edd.176.1510835650331; Thu, 16 Nov 2017 04:34:10 -0800 (PST) Received: from [105.136.73.53] ([105.136.73.53]) by smtp.gmail.com with ESMTPSA id h2sm982388edf.39.2017.11.16.04.34.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Nov 2017 04:34:09 -0800 (PST) Mime-Version: 1.0 (1.0) From: Ard Biesheuvel X-Mailer: iPhone Mail (15A432) In-Reply-To: <20171116115914.foym7hu3p676foer@bivouac.eciton.net> Date: Thu, 16 Nov 2017 12:34:06 +0000 Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Message-Id: <8702245A-4A13-4B96-9274-B22CC2B2F148@linaro.org> References: <20171115140319.32570-1-ard.biesheuvel@linaro.org> <20171116115914.foym7hu3p676foer@bivouac.eciton.net> To: Leif Lindholm Subject: Re: [PATCH] ArmVirtPkg: remove ArmPlatformSysConfigLib dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 12:30:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > On 16 Nov 2017, at 11:59, Leif Lindholm wrote: >=20 >> On Thu, Nov 16, 2017 at 09:40:58AM +0000, Ard Biesheuvel wrote: >>> On 15 November 2017 at 14:03, Ard Biesheuvel = wrote: >>> Now that the PL031 RTC driver library no longer depends on the ARM >>> platform specific ArmPlatformSysConfigLib, we no longer need to >>> implement ArmPlatform.h or have a resolution for that library. >>> This allows us to get rid of a rather dodgy practice of including >>> platform headers using compiler flags, which is a bad idea at various >>> levels. >>>=20 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> PL031 patch is on-list and pending. >>>=20 >>> ArmVirtPkg/ArmVirtQemu.dsc | 7 -= ---- >>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 -= --- >>> ArmVirtPkg/ArmVirtXen.dsc | 6 -= --- >>> ArmVirtPkg/Include/ArmPlatform.h | 33 -= ------------------- >>> ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/QemuVirtMem.c | 1 -= >>> ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/RelocatableVirt.c | 1 -= >>> ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c | 1 -= >>> ArmVirtPkg/Library/ArmVirtPlatformLib/VirtMem.c | 1 -= >>> ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/RelocatableVirt.c | 1 -= >>> ArmVirtPkg/Library/ArmXenRelocatablePlatformLib/XenVirtMem.c | 1 -= >>> ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c | 7 += +++- >>> 11 files changed, 6 insertions(+), 59 deletions(-) >>>=20 >>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >>> index 8a60b61f2aa6..d1b3849d856a 100644 >>> --- a/ArmVirtPkg/ArmVirtQemu.dsc >>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >>> @@ -49,7 +49,6 @@ [LibraryClasses.common] >>> QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.i= nf >>>=20 >>> ArmPlatformLib|ArmVirtPkg/Library/ArmVirtPlatformLib/ArmVirtPlatformLi= b.inf >>> - ArmPlatformSysConfigLib|ArmPlatformPkg/Library/ArmPlatformSysConfigLi= bNull/ArmPlatformSysConfigLibNull.inf >>>=20 >>> TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf >>> NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib= .inf >>> @@ -71,12 +70,6 @@ [LibraryClasses.common] >>> [LibraryClasses.common.UEFI_DRIVER] >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf >>>=20 >>> -[BuildOptions] >>> - RVCT:*_*_ARM_PLATFORM_FLAGS =3D=3D --cpu Cortex-A15 -I$(WORKSPACE)/Ar= mVirtPkg/Include >>> - GCC:*_*_ARM_PLATFORM_FLAGS =3D=3D -mcpu=3Dcortex-a15 -I$(WORKSPACE)/A= rmVirtPkg/Include >>=20 >> Oops. I will need to retain the -mcpu setting here, or the 'hvc' >> instruction will be rejected by the assembler. >=20 > Don't we have source-level overrides for that? > At least ".arch_extension virt" for GNU. >=20 Yeah, or at least move the cflags override to the .inf of the library that u= ses the hvc instruction=