From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7754.1621405056573286381 for ; Tue, 18 May 2021 23:17:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Jre/2jh2; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621405055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q5ZVGdUtnHejDh3KVgpO/BQWprIMyJB8PznmvT/i16g=; b=Jre/2jh2mAU23Y2Udnrq824st0fNO9UEH7w0wG+Pbv6Hkf+UsibN6NFcXu/LWBWmD3Vn6s HYTqjd0rBBcWxe0dR/BXbec5ynJLQxgOi7xsiikmeo32ZAlhjiJuLvpglJNx2l7mkAWF5O d48iyx/DqkQXyN+tqw7pPBePg8lBkrc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-NLWsylv4MiSbdwsDYdvUWg-1; Wed, 19 May 2021 02:17:32 -0400 X-MC-Unique: NLWsylv4MiSbdwsDYdvUWg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A6833107ACE4; Wed, 19 May 2021 06:17:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-238.ams2.redhat.com [10.36.112.238]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC8DF78620; Wed, 19 May 2021 06:17:28 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 2/5] MdeMoudlePkg: introduce new PCD for Acpi/rsdp To: devel@edk2.groups.io, jianyong.wu@arm.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com Cc: hao.a.wu@intel.com, justin.he@arm.com, Jian J Wang References: <20210517065032.82423-1-jianyong.wu@arm.com> <20210517065032.82423-3-jianyong.wu@arm.com> From: "Laszlo Ersek" Message-ID: <87101062-957e-84c1-42b9-6f06509b2850@redhat.com> Date: Wed, 19 May 2021 08:17:27 +0200 MIME-Version: 1.0 In-Reply-To: <20210517065032.82423-3-jianyong.wu@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/17/21 08:50, Jianyong Wu wrote: > As there is lack of a machnism in Cloud Hypervisor to pass the base > address of Rsdp in Acpi, so a PCD varialbe is introduced here to > feed it. > > Cc: Hao A Wu > Cc: Jian J Wang > Signed-off-by: Jianyong Wu > --- > MdeModulePkg/MdeModulePkg.dec | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 148395511034..4c8baac35a9e 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -910,6 +910,13 @@ [PcdsFixedAtBuild] > # @Expression 0x80000001 | (gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable == 0xFFFFFFFFFFFFFFFF || gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable <= 0x0FFFFFFFFFFFFFFF) > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadModuleAtFixAddressEnable|0|UINT64|0x30001015 > > + ## > + # This is the physical address of rsdp which is the core struct of Acpi. > + # Some hypervisor may has no way to pass rsdp address to the guest, so a PCD > + # is worth for those. > + # > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiRsdpBaseAddress|0x0|UINT64|0x30001056 > + > ## Progress Code for OS Loader LoadImage start.

> # PROGRESS_CODE_OS_LOADER_LOAD = (EFI_SOFTWARE_DXE_BS_DRIVER | (EFI_OEM_SPECIFIC | 0x00000000)) = 0x03058000
> # @Prompt Progress Code for OS Loader LoadImage start. > This PCD is not useful enough to be placed in MdeModulePkg -- it is only used in the next two patches, which are for ArmVirtPkg. (1) Therefore, please add the PCD to the "ArmVirtPkg.dec" file. (2) The PCD should arguably refer to "CloudHv" in the name. (3) In my opinion, this patch (once reimplemented for ArmVirtPkg.dec) should be squashed into the CloudHvAcpiPlatformDxe patch. The PCD is being introduced *for* CloudHvAcpiPlatformDxe, and *only* for that driver. In such cases, we usually keep the DEC modifications in the same patch as the driver addition, assuming the PCD goes in the same package as the driver. (4) "some hypervisor" in the DEC comment is bogus. Please be as explicit about the use case as possible. Thanks Laszlo