From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.56]) by mx.groups.io with SMTP id smtpd.web11.857.1684855024259315560 for ; Tue, 23 May 2023 08:17:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=dAVp+Hm3; spf=pass (domain: arm.com, ip: 40.107.22.56, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tsD3zvj3Gt6mLry6w2qFC/sdJmDbIk0aFRLXwwPYnWQ=; b=dAVp+Hm3vAnOha1TTPLTzdjQfoMPNFjH9saTkqc+/WwtelUhyjA4lO/pMpSythjBF7YoWk507w6yztlVT8MHG5nt6zKAqrr9VxBaMwLpUV4lgtKJYwWRgp+ozM0fOIKNibX7qieZZ3UmDsX4Sc3E+CJKxZlEGec8wAcCuRK049Q= Received: from DUZPR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::14) by AS8PR08MB7838.eurprd08.prod.outlook.com (2603:10a6:20b:529::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 15:16:57 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46b:cafe::85) by DUZPR01CA0027.outlook.office365.com (2603:10a6:10:46b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 15:16:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 23 May 2023 15:16:56 +0000 Received: ("Tessian outbound 3570909035da:v136"); Tue, 23 May 2023 15:16:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9f162b3ae6f4cdbf X-CR-MTA-TID: 64aa7808 Received: from 55cc348eec0e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9BACC5D8-1FB6-4406-A369-D53AC03DB7DE.1; Tue, 23 May 2023 15:16:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 55cc348eec0e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 15:16:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UW/qB7HF9JgkmCXcd52/IkgQ+l29qer6BADg4nW9HXzS1FUQN+N3iEtgIkmUZ7IEsP6MFqmrNUGF1cVd4jVRpjgWZ6QWQDP4uB6oVXywCDfc74ZxpffCoBIook+oO28oK4Xs08h/4OWZGj9U82kXUQmvSwvNCayLzek4Y5X9EQS+Y5Z3WwxyrCOq9ZA/2bBt785jpL/OPlWggW1hioeRaJIv/uk2/X4uEgm8nqSb66KWIsdKN9Zh7KnZ9mNeLbhiVEXWPDDrU+iVVFTAMoW0WWm87GGZj9GYIhtgxtDBx1quOCrso2p3jjSIgxkwnEbDWR3JKJjk/ttOEjIS4TZzSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tsD3zvj3Gt6mLry6w2qFC/sdJmDbIk0aFRLXwwPYnWQ=; b=Osnk3TG9ZkeoaZZVyAbnNr0EF0jqkxqfWR6mttxNRLNvnR+F66hWG0lUHdODrVtJ+i+OcG/FdKnw4EVmfOMoe6stdXtRro70uza2TyH58sgTsOCna9P6px2DG2hREJ5hBRtkfK+jS5lSf4xR8UkRuRqSSDb9Qe4Rr0XTNqnGJgTGAoFDa26b73e1+YB4CXLnCjIdr1L92AgCZLcH2t2F12fw3QzPVTKcqaFlWKVgwR6tzvIPzF/m0FO/et3hhaR8Q22psal2DfCHnYLgMyzQr8W56sR8+u8ytYHxW/C5eQpnMGzq9SPcAydrL4ijcs7Jpf7aCKFzO8MtVaAYrX2jZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tsD3zvj3Gt6mLry6w2qFC/sdJmDbIk0aFRLXwwPYnWQ=; b=dAVp+Hm3vAnOha1TTPLTzdjQfoMPNFjH9saTkqc+/WwtelUhyjA4lO/pMpSythjBF7YoWk507w6yztlVT8MHG5nt6zKAqrr9VxBaMwLpUV4lgtKJYwWRgp+ozM0fOIKNibX7qieZZ3UmDsX4Sc3E+CJKxZlEGec8wAcCuRK049Q= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB3PR08MB8985.eurprd08.prod.outlook.com (2603:10a6:10:43f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 15:16:43 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6411.029; Tue, 23 May 2023 15:16:42 +0000 Message-ID: <872d7d4e-b1af-9f5a-d694-54b533b49a61@arm.com> Date: Tue, 23 May 2023 16:16:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 02/12] ArmPkg: Fix data type used for GicInterruptInterfaceBase To: Pedro Falcato CC: devel@edk2.groups.io, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, neil.jones@blaize.com, pierre.gondois@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, Sibel.Allinson@arm.com, nd@arm.com References: <20230523130421.10804-1-sami.mujawar@arm.com> <20230523130421.10804-3-sami.mujawar@arm.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0650.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB3PR08MB8985:EE_|DBAEUR03FT062:EE_|AS8PR08MB7838:EE_ X-MS-Office365-Filtering-Correlation-Id: 3449bc24-e49d-4f40-401b-08db5ba0bf75 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tm1uncR9UIyUNnXb9E+uISV0bPBZuRgcDc9QvY4v3ncBVLPu7Bdzxqyo4CjVbdLqa/ke0Fxh3QGH1xApjma6y1tn0D4gWHcNpVr7YcJ5g9I2oKwaj3Snn3zJmwyREjkbEBiw6PeSSdjTRotWvRjtrmN3z+FZmyXvsyQeLHspAovfZfzGjFrv7uEmf958jVEtxTj2oeqv7Ow3qlx2U+W13QWk5NuBxhH1d0ZieFuEndPhW4umbJvViSDSpNL9OOkF7KMjFi6ILE/lWdh7rhJS0wx2Aa50iRxd1qPNDLscPRX0nouZfNvf2dOSEp5R0PMMEQl6Dl+FeGfoxXVdFR0oVSKdp23908qU10X3+04axxCEODkrAGvN+8hBDzmdsiW9ZDmsTOzH2uGslyd0x1RvUR3n9WoUFK9soRlJQkqNfmiMteZXpFZzDxRjOA2jEO5r1fLlKMptLHcmTPa4FTE2bkPMgEc+izd5Pj6nvbuNKNalAd3xB6CVpqLAbk6lvpYU6bapaipOH37uH1fbtyWPOQFjpwloH2NjuX2frvN5P2U0hrIfYP6LFz+/hiwhFjSsMGSztC0xJ7aILjbFQU1FjFsDHeAzzq8oSlnQtYcwXlLymddMommfcbOIGxo8fKIjsPb2VAFSqFhfUE72H9e2KQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(136003)(366004)(346002)(376002)(451199021)(41300700001)(6486002)(31686004)(478600001)(31696002)(19627235002)(316002)(4326008)(6916009)(66946007)(66556008)(66476007)(86362001)(5660300002)(8936002)(8676002)(38100700002)(44832011)(2906002)(26005)(6512007)(6506007)(186003)(53546011)(83380400001)(2616005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8985 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6677b719-f703-44af-64ba-08db5ba0b6fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jE91IS1Z8f+BKU1ZqcZRM3WeJw2UUlChGgh1iYhFZiXDTlT3aZh4BHdU6MX8VxabmRV++rLH2bt+jh+db6+9NFMh5n/L7FF6Feb80rl8MbFsGDSkgCrgS5WYD8bXC6pIpBwSi+0mE6rdGPO4k6U9/VHAL1tbNw+RCn0+LB2jChRLljh99gsz1B+H7sIytRwPY6ZGBypbqMlblIWyQjYL84xdskBy5mpq3PJj+hE+1ZE26zV4/INbzpV/ZrPU+OcgjwygyCs8m/iM4keBFsrbuQrAlDJEbxaEYmmyldRAuw42pcORmuK5i+0lplvgYCORnxvlSijpJmJMiWdTH67S18PWk4NbBpEA5Pxk48nviyvo99hyJLzD/WBocRDUaUUUOUN86OpjjaVJJ3FFRmwJRjHs+7v7HU1KaWNjCoVu8uZ5sIh+7ylE1NpPA+eATxJpI4RUSlY0Hf9D+5tkJedgqnJ2+OttS8njlNKckw7evlqxeEAeSbUUTEqygKKV8Mne9QahewZ1gM34iIrh0sqT59873nGI2AZskkDBzoBlBCdSkxvFgq7AfHPt99wYr+n1OF3oV6VsUZ7XIX/cXAV5j6aFGQM++iGVtlBm8XxGgt+0xpWDsiR3CbRa0OVGieru/Z1OXhzdypji6WKA/RldyViOaxIpWNEJx6xwBxE4LT9bIXot0SWgFhlfoK26ic7einaBnfNHBms1Ngo8BENobnwY4VQ3zSA+Vw6vNwEasbBCZk4U/wK1AEPQseBEIlS5Wyn3lc/Ak49FHii7Mmg2Bg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(46966006)(36840700001)(40470700004)(31696002)(41300700001)(6486002)(82310400005)(316002)(4326008)(356005)(70586007)(81166007)(70206006)(82740400003)(5660300002)(8936002)(8676002)(86362001)(19627235002)(478600001)(31686004)(6862004)(44832011)(47076005)(83380400001)(6506007)(26005)(6512007)(2906002)(40460700003)(53546011)(186003)(36860700001)(36756003)(2616005)(40480700001)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 15:16:56.8084 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3449bc24-e49d-4f40-401b-08db5ba0bf75 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7838 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Pedro, Thank you for the feedback. Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 23/05/2023 02:35 pm, Pedro Falcato wrote: > On Tue, May 23, 2023 at 2:04=E2=80=AFPM Sami Mujawar wrote: >> The data type used by variables representing the >> GicInterruptInterfaceBase has been inconsistently >> used in the ArmGic driver and the library. >> The PCD defined for the GIC Interrupt interface >> base address is UINT64. However, the data types >> for the variables used is UINTN, INTN, and at >> some places UINT32. >> >> Therefore, update the data types to use UINTN and >> add necessary typecasts when reading values from >> the PCD. This should then be consistent across >> AArch32 and AArch64 builds. >> >> Signed-off-by: Sami Mujawar >> --- >> ArmPkg/Drivers/ArmGic/ArmGicLib.c | 13 ++++++++++--- >> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 2 +- >> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c | 6 +++--- >> ArmPkg/Include/Library/ArmGicLib.h | 18 +++++++++--------= - >> 4 files changed, 23 insertions(+), 16 deletions(-) >> >> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/A= rmGicLib.c >> index 6e44e89390fcdaa89302d6505f75c43c84ce3535..78edc7e76a087caa5b91d896= f9bd316d6530a668 100644 >> --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c >> +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c >> @@ -104,10 +104,17 @@ GicGetCpuRedistributorBase ( >> return 0; >> } >> >> +/** >> + Return the GIC CPU Interrupt Interface ID. >> + >> + @param GicInterruptInterfaceBase Base address of the GIC Interrupt I= nterface. >> + >> + @retval CPU Interface Identification information. >> +**/ >> UINTN >> EFIAPI >> ArmGicGetInterfaceIdentification ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ) >> { >> // Read the GIC Identification Register >> @@ -400,7 +407,7 @@ ArmGicDisableDistributor ( >> VOID >> EFIAPI >> ArmGicEnableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ) >> { >> ARM_GIC_ARCH_REVISION Revision; >> @@ -418,7 +425,7 @@ ArmGicEnableInterruptInterface ( >> VOID >> EFIAPI >> ArmGicDisableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ) >> { >> ARM_GIC_ARCH_REVISION Revision; >> diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/= ArmGic/GicV2/ArmGicV2Dxe.c >> index b7d67d830e46b663e4054990e7456660fb22cda9..b952c3ae31c060ecbb43c080= 0d34e57664a8262a 100644 >> --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c >> +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c >> @@ -400,7 +400,7 @@ GicV2DxeInitialize ( >> // the system. >> ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gHardwareInterruptProtocol= Guid); >> >> - mGicInterruptInterfaceBase =3D PcdGet64 (PcdGicInterruptInterfaceBase= ); >> + mGicInterruptInterfaceBase =3D (UINTN)PcdGet64 (PcdGicInterruptInterf= aceBase); >> mGicDistributorBase =3D (UINTN)PcdGet64 (PcdGicDistributorBas= e); >> mGicNumInterrupts =3D ArmGicGetMaxNumInterrupts (mGicDistri= butorBase); >> > ASSERT'ing for PCD <=3D MAX_UINTN may be desirable here, for both bases? [SAMI] I will address this in the v2 series. > >> diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c b/ArmPkg/Dr= ivers/ArmGic/GicV2/ArmGicV2NonSecLib.c >> index 85c2a920a54a1acaccb98a94b5591ce36d20697c..832f21644233655ef2f359f1= e175071d2a493b7c 100644 >> --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c >> +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c >> @@ -1,6 +1,6 @@ >> /** @file >> * >> -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. >> +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. >> * >> * SPDX-License-Identifier: BSD-2-Clause-Patent >> * >> @@ -13,7 +13,7 @@ >> VOID >> EFIAPI >> ArmGicV2EnableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ) >> { >> /* >> @@ -26,7 +26,7 @@ ArmGicV2EnableInterruptInterface ( >> VOID >> EFIAPI >> ArmGicV2DisableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ) >> { >> // Disable Gic Interface >> diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library= /ArmGicLib.h >> index 72dbd1ca8d626c69d9bb8727d77fd34b4ab3af28..41bbf1da6a6cbb683df4bb30= c4b1a1762dc7814f 100644 >> --- a/ArmPkg/Include/Library/ArmGicLib.h >> +++ b/ArmPkg/Include/Library/ArmGicLib.h >> @@ -113,7 +113,7 @@ >> UINTN >> EFIAPI >> ArmGicGetInterfaceIdentification ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> // GIC Secure interfaces >> @@ -122,7 +122,7 @@ EFIAPI >> ArmGicSetupNonSecure ( >> IN UINTN MpId, >> IN UINTN GicDistributorBase, >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> VOID >> @@ -136,13 +136,13 @@ ArmGicSetSecureInterrupts ( >> VOID >> EFIAPI >> ArmGicEnableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> VOID >> EFIAPI >> ArmGicDisableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> VOID >> @@ -203,8 +203,8 @@ ArmGicEndOfInterrupt ( >> UINTN >> EFIAPI >> ArmGicSetPriorityMask ( >> - IN INTN GicInterruptInterfaceBase, >> - IN INTN PriorityMask >> + IN UINTN GicInterruptInterfaceBase, >> + IN INTN PriorityMask >> ); >> >> VOID >> @@ -252,19 +252,19 @@ EFIAPI >> ArmGicV2SetupNonSecure ( >> IN UINTN MpId, >> IN UINTN GicDistributorBase, >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> VOID >> EFIAPI >> ArmGicV2EnableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> VOID >> EFIAPI >> ArmGicV2DisableInterruptInterface ( >> - IN INTN GicInterruptInterfaceBase >> + IN UINTN GicInterruptInterfaceBase >> ); >> >> UINTN >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >> >