From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D53FEAC0EEC for ; Sat, 28 Oct 2023 11:08:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gBtWIU8nrV7GXGAhybsRjP9AKzn6R/mjdvVX4+ayOSc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698491300; v=1; b=omJxO9A7oE8pZYI1CfP5YX5uUZxAki0O8XH+WdAnWaZtj0k+94/07Ea8kBRdcKqju9q4PUtw tUXF76gtvSuDGERfQlNVkqfwW7cgtk09KW72VCOVC+fddjJw2u6pq71fgwQauXlcNqsYdoZjlOG waVxBVmiR7oBP6aaoVQ2AWRo= X-Received: by 127.0.0.2 with SMTP id s15EYY7687511xLRn0OjZzgb; Sat, 28 Oct 2023 04:08:20 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16035.1698491299862514872 for ; Sat, 28 Oct 2023 04:08:20 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-O9EI0QuOMnGQfqkoNTev8w-1; Sat, 28 Oct 2023 07:08:13 -0400 X-MC-Unique: O9EI0QuOMnGQfqkoNTev8w-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12E6F811E7B; Sat, 28 Oct 2023 11:08:13 +0000 (UTC) X-Received: from [10.39.192.70] (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B9291121319; Sat, 28 Oct 2023 11:08:12 +0000 (UTC) Message-ID: <876327d5-0586-9fbb-5479-de700ac434af@redhat.com> Date: Sat, 28 Oct 2023 13:08:11 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv. To: "Ni, Ray" , "Xu, Wei6" , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Sami Mujawar References: From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xcAo2MjxHpKpV5Id6IiXhiElx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=omJxO9A7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/27/23 07:49, Ni, Ray wrote: > Wei, > Thanks for fixing the 3 issues. > Can you kindly separate the one patch to at least 2 patches? > One patch is to fix minor issues. > The other is to add support of nested uncompressed FV. Yes please! I'd even prefer a separate patch per individual issue fix (especially if you count the recursion limiting too). Thanks! Laszlo > > Thanks, > Ray > ------------------------------------------------------------------------ > *From:* Xu, Wei6 > *Sent:* Friday, October 27, 2023 8:59 AM > *To:* devel@edk2.groups.io > *Cc:* Xu, Wei6 ; Laszlo Ersek ; > Ard Biesheuvel ; Sami Mujawar > ; Ni, Ray > *Subject:* [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed > inner fv. >   > V1: > This patch is to fix the issue that StandaloneMmCore fails to detect > uncompressed inner FV. > PR: https://github.com/tianocore/edk2/pull/4943 > > > V2: > Based on V1, fix some other issues > 1. Add Missing object size checks before casting pointers to header types >   a. InnerFvHeader = (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; >      This is introduced in V1, add the size check on SectionDataSize > against EFI_FIRMWARE_VOLUME_HEADER >   b. Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); >      Use FfsFindSection instead of FfsFindSectionData to avoid pointer > casting. > 2. Fix potential memory leak issue that ScratchBuffer is not freed when > page allocation for DstBuffer fails. > PR: https://github.com/tianocore/edk2/pull/4965 > > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > > Wei6 Xu (1): >   StandaloneMmPkg: Fix some issues in function MmCoreFfsFindMmDriver. > >  StandaloneMmPkg/Core/FwVol.c | 34 ++++++++++++++++++++++++++-------- >  1 file changed, 26 insertions(+), 8 deletions(-) > > -- > 2.29.2.windows.2 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110241): https://edk2.groups.io/g/devel/message/110241 Mute This Topic: https://groups.io/mt/102212657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-