From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D23C2034C5C6 for ; Mon, 20 Nov 2017 10:37:17 -0800 (PST) Received: by mail-wm0-x231.google.com with SMTP id 128so12209728wmo.3 for ; Mon, 20 Nov 2017 10:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hA/GI3hf61lNQsz1npY2vCL7nf5cp5fJqo2Ei3x4bXA=; b=F2Yf/S9o9MF3F4WVVXvg365oR9RiitOwvr8Jv8i8iOi2/QrVZ7aGscgJWGOO5ltx9X QI3UnhXzFQWYBwE5DLoyaLTfHW8WHVVcQH9VseufRqksKq+wIwtbQp4NmTMIZADTsnfo RojUhWXpYFXBOoW87nNPCD3NYXc38YfOaIpaFC2vMZSR60GyqZUTHaBpDTrGoY9zMMVv l9vn8i8l/yT9JtQJY3RvVRo2TWCHrFba9DKSq7PfUjj8FuXhZS0tcvn9va9cqRHjII9x RC6KfYlk1YoElDRQLeJDRSAs8f+Fojva9nk8CN3wos6ejdMgAeiv8fb6iV5F6hmvd8Rh 4jVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hA/GI3hf61lNQsz1npY2vCL7nf5cp5fJqo2Ei3x4bXA=; b=BfsglPhriBcHMzZVjsN1O8MY3dnUvW8e4NXx+gIA5IBDDKJjWKjKy5/LLXh7tTS67o CllOoxuy7AsWfmW2BKAs8L+vaw+MGsusWEiUJ1LM3WLCuh8cCLQ+136sOS6runi71/pF vxVHbR9R1mL7meMNX0BEguCRd0LVst1px6jvEHSnrMPGdz9H4PY5UZPQwDplZHUmElxN Z6l90hq4ols8XzghOxlVAG2e1gZzMPI7GwIGr4CI8F2z/Gt+4TPD6VYktbZ98RGYl8ya zUm+1o8m0S/blSEoqtdzh2vnBCkqtH256ykig113eKkRFqMOHdJY27/iXQk6oi/YPHl4 rJjw== X-Gm-Message-State: AJaThX4ey67r9FvtmpQYMTaMNbF+tcrfYHK62fKumEw4qNACrfD9conC tgd8pnWaRCyWzRzEQJssA9SzLg== X-Google-Smtp-Source: AGs4zMb925HUhSZJLJVMVENCwroTIqD4EXGLHUiS4mAwbuKQbkewONLpJEdNklVvtcTRiCxzGMi/nQ== X-Received: by 10.80.215.218 with SMTP id m26mr19254174edj.27.1511203289444; Mon, 20 Nov 2017 10:41:29 -0800 (PST) Received: from [10.0.0.101] ([84.203.48.71]) by smtp.googlemail.com with ESMTPSA id c33sm3610904edd.36.2017.11.20.10.41.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2017 10:41:28 -0800 (PST) To: "edk2-devel@lists.01.org" References: <20171117130837.9164-1-pete@akeo.ie> <20171117130837.9164-3-pete@akeo.ie> <4A89E2EF3DFEDB4C8BFDE51014F606A14E18099E@SHSMSX104.ccr.corp.intel.com> From: Pete Batard Cc: "Gao, Liming" Message-ID: <8770dd47-c295-c875-7448-46893f1471b4@akeo.ie> Date: Mon, 20 Nov 2017 18:41:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E18099E@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH v2 2/4] BaseTools: Add VS2017 tool chain in BaseTools tools_def.template X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 18:37:17 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Liming, On 2017.11.20 08:46, Gao, Liming wrote: > Here, I suggest to mention VS version 15.2 or above, because vswhere.exe depends on this version. > After later, you may also update this version to 15.4 for ARM and AARCH64 support. I assume you mean replacing the "Microsoft Visual Studio 2017 Professional or Community Edition" from the comment with something like "Microsoft Visual Studio 2017 version 15.2 or later", right? If so, I will do that and submit a v3. Do you think the possibility of adding vswhere.exe to BaseTools\Bin\Win32 is also worth exploring? For one thing this would solve the issue of locating 15.2 VS 2017 (as well as nonstandard installations that may have removed the installer directory), and the executable is both Open Source (MIT) and redistributable. The other possibility of course is to let pre 15.2 VS2017 fail the detection process, and expect users to get a hint that they need an updated version from the comments in tools_def... Regards, /Pete