Re: [PATCH] RFC : Ping : Fix for loss of first ping packet

[Laszlo Ersek <lersek@redhat.com>]

Hi Meenakshi,

On 02/15/18 13:08, Meenakshi Aggarwal wrote:
> Hi,
> 
> Any comment?

I don't see your original patch email on the list, either in my personal
folder, or in the archive at
<https://lists.01.org/pipermail/edk2-devel/2018-February/thread.html>.
Can you resend?

Also, I suggest a subject line like:

  [RFC] ShellPkg/Ping: fix loss of first packet

In other words, "RFC" should only be in the bracketed part (= the
subject prefix). You can change the [PATCH] prefix into [RFC] by adding

  --subject-prefix=RFC

to the git-format-patch command line.

Thanks
Laszlo

>> -----Original Message-----
>> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
>> Sent: Tuesday, February 13, 2018 8:52 PM
>> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org
>> Cc: Udit Kumar <udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>;
>> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet
>>
>> Issue:
>> Reply for first ping packet was getting dropped.
>>
>> Cause:
>> Sometimes reply message comes even before trasmit
>> function returns, hence missing 1st reply
>>
>> Fix:
>> Prepare the TxList before calling Transmit function.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> ---
>>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> index bec9535..46ba701 100644
>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
>> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>>    }
>>
>>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
>> +
>> +  InsertTailList (&Private->TxList, &TxInfo->Link);
>> +
>>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
>>> Token);
>>
>>    if (EFI_ERROR (Status)) {
>> +    RemoveEntryList (&TxInfo->Link);
>>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>>      return Status;
>>    }
>>
>> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>>    Private->TxCount++;
>>
>>    return EFI_SUCCESS;
>> --
>> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>