From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Prabin CA <prabin.ca@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Thomas Abraham <thomas.abraham@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont
Date: Sun, 31 Mar 2024 12:55:36 +0100 [thread overview]
Message-ID: <87903e06-e218-42ec-87d0-021601915436@arm.com> (raw)
In-Reply-To: <20240311131416.823580-8-prabin.ca@arm.com>
Hi Prabin,
Thank you for this patch.
This patch does not cleanly apply on the latest edk2-platforms master
branch. Can you check, please?
Regards,
Sami Mujawar
On 11/03/2024 01:14 pm, Prabin CA wrote:
> Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a
> 16 core platform with Poseidon CPU. Each of the CPUs include
> 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache.
> The platform also includes system level cache of 32MB and 8GB of RAM.
>
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 5 +++++
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c | 5 ++++-
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c | 5 ++++-
> Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c | 1 +
> Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 6 ++++++
> 5 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> index 6fa39d407bc9..acfa45910aed 100644
> --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
> @@ -51,6 +51,10 @@
> #define RD_V2_PART_NUM 0x7F2
> #define RD_V2_CONF_ID 0x1
>
> +// RD-Fremont Platform Identification values
> +#define RD_Fremont_PART_NUM 0x7EE
> +#define RD_Fremont_CONF_ID 0x1
> +
> #define SGI_CONFIG_MASK 0x0F
> #define SGI_CONFIG_SHIFT 0x1C
> #define SGI_PART_NUM_MASK 0xFFF
> @@ -90,6 +94,7 @@ typedef enum {
> RdN2Cfg1,
> RdN2Cfg2,
> RdV2,
> + RdFremont,
> } ARM_RD_PRODUCT_ID;
>
> // Arm ProductId look-up table
> diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
> index edf2a5f63c63..9c28b051ebc2 100644
> --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
> +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
> @@ -34,7 +34,8 @@
> "RdN2\0" \
> "RdN2Cfg1\0" \
> "RdN2Cfg2\0" \
> - "RdV2\0"
> + "RdV2\0" \
> + "RdFremont\0"
>
> typedef enum {
> ManufacturerName = 1,
> @@ -74,6 +75,8 @@ STATIC GUID mSmbiosUid[] = {
> {0xd2946d07, 0x8057, 0x4c26, {0xbf, 0x53, 0x78, 0xa6, 0x5b, 0xe1, 0xc1, 0x60}},
> /* Rd-V2 */
> {0x3b1180a3, 0x0744, 0x4194, {0xae, 0x2e, 0xed, 0xa5, 0xbc, 0x2e, 0x43, 0x45}},
> + /* Rd-Fremont */
> + {0x904b28d6, 0x0662, 0x11ed, {0xb9, 0x39, 0x02, 0x42, 0xac, 0x12, 0x00, 0x02}},
> };
>
> /* System information */
> diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
> index ee269f707714..c39c1553f6aa 100644
> --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
> +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
> @@ -44,6 +44,7 @@
> "Neoverse-N2\0" \
> "Neoverse-N2\0" \
> "Neoverse-V2\0" \
> + "Neoverse-Poseidon\0" \
> "000-0\0" /* Serial number */ \
> "783-3\0" \
> "786-1\0" \
> @@ -54,7 +55,8 @@
> "7B7-1\0" \
> "7B6-1\0" \
> "7B7-1\0" \
> - "7F2-1\0"
> + "7F2-1\0" \
> + "7EE-1\0"
>
> typedef enum {
> PartNumber = 1,
> @@ -181,6 +183,7 @@ InstallType4ProcessorInformation (
> case RdN2:
> case RdN2Cfg1:
> case RdV2:
> + case RdFremont:
> mArmRdSmbiosType4.Base.CoreCount = CoreCount;
> mArmRdSmbiosType4.Base.EnabledCoreCount = CoreCount;
> mArmRdSmbiosType4.Base.ThreadCount = CoreCount;
> diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
> index 4af72919a3f1..4cdea5b3b763 100644
> --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
> +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
> @@ -335,6 +335,7 @@ InstallType7CacheInformation (
> mArmRdSmbiosType7[4].Base.Associativity = CacheAssociativity16Way;
> break;
> case RdV2:
> + case RdFremont:
> /* L1 instruction cache */
> mArmRdSmbiosType7[0].Base.MaximumCacheSize2 = 64; // 64KB
> mArmRdSmbiosType7[0].Base.InstalledSize2 = 64; // 64KB
> diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> index 14b06796ae9c..ae31be142d12 100644
> --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c
> @@ -85,6 +85,12 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[] = {
> RD_V2_CONF_ID,
> 0
> },
> + {
> + RdFremont,
> + RD_Fremont_PART_NUM,
> + RD_Fremont_CONF_ID,
> + 0
> + },
> };
>
> EFI_BOOT_MODE
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117258): https://edk2.groups.io/g/devel/message/117258
Mute This Topic: https://groups.io/mt/104862636/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-31 11:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:14 [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform Prabin CA
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 11:58 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 12:01 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 12:01 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms Prabin CA
2024-03-11 14:33 ` levi.yun
2024-03-31 10:31 ` Sami Mujawar
2024-03-31 11:57 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 5/9] Platform/Sgi: Add ACPI tables for RD-Fremont platform Prabin CA
2024-03-11 14:34 ` levi.yun
2024-03-31 12:02 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support " Prabin CA
2024-03-11 14:34 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 11:55 ` Sami Mujawar [this message]
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 8/9] Platform/Sgi: Low Power Idle States " Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 9/9] Platform/Sgi: Add CPPC support for RD-Fremont platform Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-31 12:06 ` [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add " Sami Mujawar
2024-04-03 17:40 ` Prabin CA
2024-03-31 12:09 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87903e06-e218-42ec-87d0-021601915436@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox